Ref T2222. Ref T3886. Converts parsing and construction of commit messages to be driven by CustomField.
Details
Details
- Reviewers
btrahan - Maniphest Tasks
- Restricted Maniphest Task
T2222: Implement ApplicationTransactions in Differential - Commits
- Restricted Diffusion Commit
rPae3c1f781939: Perform commit message parsing and construction with new CustomFields
This is a huge, messy change. I've made an effort to test it exhasutively, but suspect I probably missed a few behaviors. Roughly:
- Enumerted all current fields (fields implementing shouldAppearOnCommitMessage()) and tried to test them one by one.
- Used arc diff --edit repeatedly to manipulate each field (this workflow hits both the parse and construct steps).
- Used arc amend --show to examine construct output (this does not activate the "edit" mode).
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Lint
Lint Skipped - Unit
Tests Skipped