Page MenuHomePhabricator
Differential D8425

Update `differential.close` to use DifferentialTransactionEditor
ClosedPublic
Actions

Authored by epriestley on Mar 6 2014, 4:33 PM.
Tags
None
Referenced Files
F13081883: D8425.diff
Wed, Apr 24, 9:54 PM
Unknown Object (File)
Sun, Apr 21, 4:10 PM
Unknown Object (File)
Sat, Apr 20, 6:34 PM
Unknown Object (File)
Wed, Apr 17, 3:15 PM
Unknown Object (File)
Tue, Apr 16, 8:24 AM
Unknown Object (File)
Thu, Apr 11, 7:32 AM
Unknown Object (File)
Mar 21 2024, 9:45 PM
Unknown Object (File)
Feb 19 2024, 6:17 PM
View All Files
Subscribers
aran

Details

Reviewers
btrahan
Maniphest Tasks
T2222: Implement ApplicationTransactions in Differential
Commits
Restricted Diffusion Commit
rP75514cc0f713: Update `differential.close` to use DifferentialTransactionEditor
Summary

Ref T2222. Straightforward update to new stuff.

Test Plan
  • Tried to close an uncloseable revision.
  • Closed a closeable revision.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

btrahan accepted this revision.Mar 6 2014, 10:43 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Mar 6 2014, 10:43 PM
epriestley closed this revision.Mar 7 2014, 4:10 PM

Closed by commit rP75514cc0f713 (authored by @epriestley).

Revision Contents
Changeset List

PathSize
src/
applications/
differential/
conduit/
3 lines
37 lines
transactions/
editor/
10 lines

Diff 20023

View Options

src/applications/differential/conduit/ConduitAPI_differential_Method.php

Loading...
View Options

src/applications/differential/conduit/ConduitAPI_differential_close_Method.php

Loading...
View Options

src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php

Loading...
Phabricator · Built by Phacility