Page MenuHomePhabricator
Differential D8425

Update `differential.close` to use DifferentialTransactionEditor
ClosedPublic
Actions

Authored by epriestley on Mar 6 2014, 4:33 PM.
Tags
None
Referenced Files
F18561203: D8425.id20003.diff
Tue, Sep 9, 12:36 AM
F18462787: D8425.id.diff
Mon, Sep 1, 11:14 PM
F18442680: D8425.diff
Sun, Aug 31, 5:35 PM
F18107050: D8425.id.diff
Aug 10 2025, 11:37 PM
F18022503: D8425.id20023.diff
Aug 2 2025, 8:35 PM
F17886446: D8425.id.diff
Jul 29 2025, 1:01 AM
F17856568: D8425.diff
Jul 27 2025, 5:29 PM
F17840544: D8425.diff
Jul 26 2025, 9:16 PM
View All Files
Subscribers
aran

Details

Reviewers
btrahan
Maniphest Tasks
T2222: Implement ApplicationTransactions in Differential
Commits
Restricted Diffusion Commit
rP75514cc0f713: Update `differential.close` to use DifferentialTransactionEditor
Summary

Ref T2222. Straightforward update to new stuff.

Test Plan
  • Tried to close an uncloseable revision.
  • Closed a closeable revision.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

btrahan accepted this revision.Mar 6 2014, 10:43 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Mar 6 2014, 10:43 PM
epriestley closed this revision.Mar 7 2014, 4:10 PM

Closed by commit rP75514cc0f713 (authored by @epriestley).

Revision Contents
Changeset List

PathSize
src/
applications/
differential/
conduit/
3 lines
37 lines
transactions/
editor/
10 lines

Diff 20023

View Options

src/applications/differential/conduit/ConduitAPI_differential_Method.php

Loading...
View Options

src/applications/differential/conduit/ConduitAPI_differential_close_Method.php

Loading...
View Options

src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php

Loading...
Phabricator · Built by Phacility