Page MenuHomePhabricator
Differential D8425

Update `differential.close` to use DifferentialTransactionEditor
ClosedPublic
Actions

Authored by epriestley on Mar 6 2014, 4:33 PM.
Tags
None
Referenced Files
F19146896: D8425.id20023.diff
Wed, Dec 10, 3:48 PM
F19060019: D8425.diff
Sat, Nov 29, 7:36 AM
F19059393: D8425.diff
Sat, Nov 29, 5:16 AM
F18903705: D8425.id20003.diff
Nov 8 2025, 6:03 AM
F18882639: D8425.id.diff
Nov 6 2025, 11:10 PM
F18875339: D8425.diff
Nov 5 2025, 5:37 PM
F18790520: D8425.id20003.diff
Oct 15 2025, 3:12 PM
F18763469: D8425.id.diff
Oct 7 2025, 12:20 AM
View All Files
Subscribers
aran

Details

Reviewers
btrahan
Maniphest Tasks
T2222: Implement ApplicationTransactions in Differential
Commits
Restricted Diffusion Commit
rP75514cc0f713: Update `differential.close` to use DifferentialTransactionEditor
Summary

Ref T2222. Straightforward update to new stuff.

Test Plan
  • Tried to close an uncloseable revision.
  • Closed a closeable revision.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

btrahan accepted this revision.Mar 6 2014, 10:43 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Mar 6 2014, 10:43 PM
epriestley closed this revision.Mar 7 2014, 4:10 PM

Closed by commit rP75514cc0f713 (authored by @epriestley).

Revision Contents
Changeset List

PathSize
src/
applications/
differential/
conduit/
3 lines
37 lines
transactions/
editor/
10 lines

Diff 20023

View Options

src/applications/differential/conduit/ConduitAPI_differential_Method.php

Loading...
View Options

src/applications/differential/conduit/ConduitAPI_differential_close_Method.php

Loading...
View Options

src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php

Loading...
Phabricator · Built by Phacility