Page MenuHomePhabricator

Use CustomField, not AuxiliaryField, to power RevisionView
ClosedPublic

Authored by epriestley on Feb 27 2014, 6:27 PM.
Tags
None
Referenced Files
F19507070: D8361.id19874.diff
Fri, Jan 9, 5:11 PM
F19506969: D8361.id19875.diff
Fri, Jan 9, 5:09 PM
F19504100: D8361.id19878.diff
Fri, Jan 9, 3:35 AM
F19504099: D8361.id19875.diff
Fri, Jan 9, 3:35 AM
F19503906: D8361.id19874.diff
Fri, Jan 9, 2:27 AM
F19503905: D8361.id.diff
Fri, Jan 9, 2:27 AM
F19054903: D8361.id.diff
Nov 28 2025, 3:08 PM
F19050015: D8361.diff
Nov 27 2025, 6:47 PM
Subscribers

Details

Summary

Ref T2222. This will probably have some rough edges for a bit (e.g., weird cases I didn't remember or think of), but there's no change to the underlying data and we can easily revert if things get too messy.

Test Plan

Looked at a variety of revisions and saw sensible output.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley updated this revision to Unknown Object (????).Feb 27 2014, 6:30 PM
  • Fix a spelling issue.
  • Remove an unused property.
conf/default.conf.php
790

As far as I know, only Facebook uses this. The modern event-based version has been available for something like 18 months.