Page MenuHomePhabricator

Use CustomField, not AuxiliaryField, to power RevisionView
ClosedPublic

Authored by epriestley on Feb 27 2014, 6:27 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Feb 27, 8:14 PM
Unknown Object (File)
Thu, Feb 27, 8:14 PM
Unknown Object (File)
Thu, Feb 27, 8:14 PM
Unknown Object (File)
Mon, Feb 24, 11:33 AM
Unknown Object (File)
Fri, Feb 21, 6:54 AM
Unknown Object (File)
Sun, Feb 16, 9:31 PM
Unknown Object (File)
Sun, Feb 16, 12:27 AM
Unknown Object (File)
Sat, Feb 15, 9:35 AM
Subscribers

Details

Summary

Ref T2222. This will probably have some rough edges for a bit (e.g., weird cases I didn't remember or think of), but there's no change to the underlying data and we can easily revert if things get too messy.

Test Plan

Looked at a variety of revisions and saw sensible output.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley updated this revision to Unknown Object (????).Feb 27 2014, 6:30 PM
  • Fix a spelling issue.
  • Remove an unused property.
conf/default.conf.php
790

As far as I know, only Facebook uses this. The modern event-based version has been available for something like 18 months.