Page MenuHomePhabricator
Differential D8403

Add an explcit "Changes Planned" state for Differential
ClosedPublic
Actions

Authored by epriestley on Mar 5 2014, 2:18 AM.
Tags
None
Referenced Files
F15585969: D8403.diff
Thu, May 8, 11:53 AM
F15575542: D8403.id19970.diff
Tue, May 6, 5:25 AM
F15575541: D8403.id19957.diff
Tue, May 6, 5:25 AM
F15575540: D8403.id.diff
Tue, May 6, 5:25 AM
F15575539: D8403.diff
Tue, May 6, 5:24 AM
F15559882: D8403.id19970.diff
Tue, Apr 29, 11:38 AM
F15556360: D8403.id.diff
Mon, Apr 28, 4:25 PM
F15549247: D8403.diff
Sun, Apr 27, 4:41 AM
View All Files
Subscribers
aran

Details

Reviewers
btrahan
Maniphest Tasks
T2222: Implement ApplicationTransactions in Differential
T4481: Differential Update Feedback / Rough Edges / Status
Commits
Restricted Diffusion Commit
rP4ef87eeac832: Add an explcit "Changes Planned" state for Differential
Summary

Ref T2222. Ref T4481. This fixes the issue where "Plan Changes" could immediately trigger a state change (e.g., back to accepted) because of state-based transitions out of the NEEDS_REVISION state.

Test Plan

Planned changes an "accepted" revision, it didn't immediately return to being accepted.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

btrahan accepted this revision.Mar 5 2014, 6:36 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Mar 5 2014, 6:36 PM
epriestley closed this revision.Mar 5 2014, 6:48 PM

Closed by commit rP4ef87eeac832 (authored by @epriestley).

Revision Contents
Changeset List

Diff 19970

View Options

src/applications/differential/constants/DifferentialRevisionStatus.php

Loading...
View Options

src/applications/differential/controller/DifferentialRevisionViewController.php

Loading...
View Options

src/applications/differential/editor/DifferentialRevisionEditor.php

Loading...
View Options

src/applications/differential/editor/DifferentialTransactionEditor.php

Loading...
View Options

src/applications/differential/view/DifferentialRevisionListView.php

Loading...
Phabricator · Built by Phacility