Page MenuHomePhabricator

Add an explcit "Changes Planned" state for Differential
ClosedPublic

Authored by epriestley on Mar 5 2014, 2:18 AM.
Tags
None
Referenced Files
F14067040: D8403.diff
Tue, Nov 19, 1:01 PM
F13994001: D8403.diff
Wed, Oct 23, 3:03 AM
F13989438: D8403.id19957.diff
Mon, Oct 21, 8:29 PM
F13988011: D8403.id19970.diff
Mon, Oct 21, 12:36 PM
Unknown Object (File)
Oct 7 2024, 7:39 AM
Unknown Object (File)
Sep 26 2024, 9:18 PM
Unknown Object (File)
Sep 15 2024, 12:56 PM
Unknown Object (File)
Sep 15 2024, 8:37 AM
Subscribers

Details

Summary

Ref T2222. Ref T4481. This fixes the issue where "Plan Changes" could immediately trigger a state change (e.g., back to accepted) because of state-based transitions out of the NEEDS_REVISION state.

Test Plan

Planned changes an "accepted" revision, it didn't immediately return to being accepted.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

btrahan edited edge metadata.
This revision is now accepted and ready to land.Mar 5 2014, 6:36 PM