Page MenuHomePhabricator

Use timeline view in Differential and make inlines somewhat usable again
ClosedPublic

Authored by epriestley on Feb 13 2014, 8:09 PM.
Tags
None
Referenced Files
F19152012: D8215.id19549.diff
Thu, Dec 11, 12:10 AM
F19050707: D8215.id19549.diff
Nov 27 2025, 9:09 PM
F18878318: D8215.id.diff
Nov 6 2025, 4:53 PM
F18876243: D8215.diff
Nov 5 2025, 10:53 PM
F18821221: D8215.id19557.diff
Oct 22 2025, 8:37 PM
F18808421: D8215.diff
Oct 19 2025, 6:28 AM
F18764992: D8215.id.diff
Oct 7 2025, 8:59 AM
F18764881: D8215.diff
Oct 7 2025, 8:22 AM
Subscribers

Details

Summary

Ref T2222. This gets rid of Differential's custom view and uses a standard view instead.

This also mostly fixes the rendering logic for inlines.

This is headed to the tmp.differential branch.

Test Plan

{F112696}

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

src/applications/differential/view/DifferentialTransactionView.php
19–21

I think I can put the grouping stuff in the core after we merge with a method like isThisKindOfTransactionAnInlineComment(), but the rendering I probably can't merge unless we change one of the applications.

epriestley updated this revision to Unknown Object (????).Feb 13 2014, 8:28 PM
  • Fix local anchor.
epriestley updated this revision to Unknown Object (????).Feb 13 2014, 8:50 PM

Fixes T1790.