Page MenuHomePhabricator

Use timeline view in Differential and make inlines somewhat usable again
ClosedPublic

Authored by epriestley on Feb 13 2014, 8:09 PM.
Tags
None
Referenced Files
F17682163: D8215.id19548.diff
Sun, Jul 13, 8:20 PM
Unknown Object (File)
Sun, Jun 29, 12:01 AM
Unknown Object (File)
Jun 9 2025, 1:56 AM
Unknown Object (File)
May 20 2025, 5:47 PM
Unknown Object (File)
May 19 2025, 11:53 PM
Unknown Object (File)
May 8 2025, 11:39 AM
Unknown Object (File)
May 6 2025, 5:15 AM
Unknown Object (File)
May 6 2025, 5:15 AM
Subscribers

Details

Summary

Ref T2222. This gets rid of Differential's custom view and uses a standard view instead.

This also mostly fixes the rendering logic for inlines.

This is headed to the tmp.differential branch.

Test Plan

{F112696}

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

src/applications/differential/view/DifferentialTransactionView.php
19–21

I think I can put the grouping stuff in the core after we merge with a method like isThisKindOfTransactionAnInlineComment(), but the rendering I probably can't merge unless we change one of the applications.

epriestley updated this revision to Unknown Object (????).Feb 13 2014, 8:28 PM
  • Fix local anchor.
epriestley updated this revision to Unknown Object (????).Feb 13 2014, 8:50 PM

Fixes T1790.