Page MenuHomePhabricator

Use timeline view in Differential and make inlines somewhat usable again
ClosedPublic

Authored by epriestley on Feb 13 2014, 8:09 PM.
Tags
None
Referenced Files
F18583422: D8215.id19548.diff
Thu, Sep 11, 10:21 AM
F18469555: D8215.id.diff
Tue, Sep 2, 4:53 PM
F18447770: D8215.diff
Sun, Aug 31, 10:58 PM
F18220668: D8215.id19548.diff
Tue, Aug 19, 3:33 PM
F18106961: D8215.id.diff
Aug 10 2025, 11:34 PM
F17988311: D8215.id19557.diff
Aug 1 2025, 11:02 PM
F17980567: D8215.id.diff
Aug 1 2025, 6:48 PM
F17937067: D8215.diff
Jul 31 2025, 12:49 AM
Subscribers

Details

Summary

Ref T2222. This gets rid of Differential's custom view and uses a standard view instead.

This also mostly fixes the rendering logic for inlines.

This is headed to the tmp.differential branch.

Test Plan

{F112696}

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

src/applications/differential/view/DifferentialTransactionView.php
19–21

I think I can put the grouping stuff in the core after we merge with a method like isThisKindOfTransactionAnInlineComment(), but the rendering I probably can't merge unless we change one of the applications.

epriestley updated this revision to Unknown Object (????).Feb 13 2014, 8:28 PM
  • Fix local anchor.
epriestley updated this revision to Unknown Object (????).Feb 13 2014, 8:50 PM

Fixes T1790.