Page MenuHomePhabricator

Use timeline view in Differential and make inlines somewhat usable again
ClosedPublic

Authored by epriestley on Feb 13 2014, 8:09 PM.
Tags
None
Referenced Files
F14044597: D8215.id19548.diff
Tue, Nov 12, 6:25 PM
F14003488: D8215.id19549.diff
Sat, Oct 26, 6:45 AM
F13975944: D8215.id.diff
Oct 18 2024, 12:18 PM
F13975114: D8215.diff
Oct 18 2024, 8:50 AM
F13960187: D8215.id19544.diff
Oct 14 2024, 10:20 PM
Unknown Object (File)
Sep 6 2024, 10:10 AM
Unknown Object (File)
Sep 4 2024, 7:42 PM
Unknown Object (File)
Sep 4 2024, 4:59 PM
Subscribers

Details

Summary

Ref T2222. This gets rid of Differential's custom view and uses a standard view instead.

This also mostly fixes the rendering logic for inlines.

This is headed to the tmp.differential branch.

Test Plan

{F112696}

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

src/applications/differential/view/DifferentialTransactionView.php
19–21

I think I can put the grouping stuff in the core after we merge with a method like isThisKindOfTransactionAnInlineComment(), but the rendering I probably can't merge unless we change one of the applications.

epriestley updated this revision to Unknown Object (????).Feb 13 2014, 8:28 PM
  • Fix local anchor.
epriestley updated this revision to Unknown Object (????).Feb 13 2014, 8:50 PM

Fixes T1790.