Page MenuHomePhabricator
Differential D8451

Use CustomField for `differential.updaterevision`
ClosedPublic
Actions

Authored by epriestley on Mar 8 2014, 6:56 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Jan 27, 9:22 AM
Unknown Object (File)
Sat, Jan 25, 5:11 PM
Unknown Object (File)
Sat, Jan 25, 5:11 PM
Unknown Object (File)
Sat, Jan 25, 5:11 PM
Unknown Object (File)
Fri, Jan 24, 2:23 AM
Unknown Object (File)
Thu, Jan 23, 9:52 PM
Unknown Object (File)
Tue, Jan 21, 11:54 PM
Unknown Object (File)
Tue, Jan 21, 11:41 AM
View All Files
Subscribers
aran

Details

Reviewers
btrahan
Maniphest Tasks
T3794: Rebuild Diffusion/Audit on top of CustomField infrastructure
T2222: Implement ApplicationTransactions in Differential
Commits
Restricted Diffusion Commit
rPd8968755e9d1: Use CustomField for `differential.updaterevision`
Summary

Ref T2222. Ref T3794. Medium term goal is to remove DifferentialRevisionEditor. This removes one of two callsites.

Test Plan

Used arc diff --edit to repeatedly update a revision, making changes to various fields.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

btrahan accepted this revision.Mar 10 2014, 4:28 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Mar 10 2014, 4:28 PM
epriestley closed this revision.Mar 11 2014, 8:06 PM
epriestley updated this revision to Diff 20112.

Closed by commit rPd8968755e9d1 (authored by @epriestley).

Revision Contents
Changeset List

PathSize
src/
applications/
differential/
conduit/
123 lines
customfield/
35 lines
transactions/
editor/
1 line

Diff 20112

View Options

src/applications/differential/conduit/ConduitAPI_differential_updaterevision_Method.php

Loading...
View Options

src/applications/differential/customfield/DifferentialManiphestTasksField.php

Loading...
View Options

src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php

Loading...
Phabricator · Built by Phacility