Page MenuHomePhabricator
Differential D8451

Use CustomField for `differential.updaterevision`
ClosedPublic
Actions

Authored by epriestley on Mar 8 2014, 6:56 PM.
Tags
None
Referenced Files
F14054953: D8451.diff
Sat, Nov 16, 6:44 AM
F14042279: D8451.diff
Tue, Nov 12, 2:04 AM
F14037766: D8451.diff
Sun, Nov 10, 6:50 PM
F14028659: D8451.diff
Fri, Nov 8, 3:05 PM
F14006099: D8451.diff
Mon, Oct 28, 1:08 AM
F13981148: D8451.id20112.diff
Oct 19 2024, 2:33 PM
F13955089: D8451.id.diff
Oct 14 2024, 12:09 AM
Unknown Object (File)
Oct 9 2024, 3:36 PM
View All Files
Subscribers
aran

Details

Reviewers
btrahan
Maniphest Tasks
T3794: Rebuild Diffusion/Audit on top of CustomField infrastructure
T2222: Implement ApplicationTransactions in Differential
Commits
Restricted Diffusion Commit
rPd8968755e9d1: Use CustomField for `differential.updaterevision`
Summary

Ref T2222. Ref T3794. Medium term goal is to remove DifferentialRevisionEditor. This removes one of two callsites.

Test Plan

Used arc diff --edit to repeatedly update a revision, making changes to various fields.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

btrahan accepted this revision.Mar 10 2014, 4:28 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Mar 10 2014, 4:28 PM
epriestley closed this revision.Mar 11 2014, 8:06 PM
epriestley updated this revision to Diff 20112.

Closed by commit rPd8968755e9d1 (authored by @epriestley).

Revision Contents
Changeset List

PathSize
src/
applications/
differential/
conduit/
123 lines
customfield/
35 lines
transactions/
editor/
1 line

Diff 20112

View Options

src/applications/differential/conduit/ConduitAPI_differential_updaterevision_Method.php

Loading...
View Options

src/applications/differential/customfield/DifferentialManiphestTasksField.php

Loading...
View Options

src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php

Loading...
Phabricator · Built by Phacility