Page MenuHomePhabricator

Clean up various pieces of dead/obsolete Differential code
ClosedPublic

Authored by epriestley on Mar 9 2014, 8:49 PM.
Tags
None
Referenced Files
F14054915: D8476.diff
Sat, Nov 16, 6:23 AM
F14043271: D8476.diff
Tue, Nov 12, 8:50 AM
F14027768: D8476.diff
Fri, Nov 8, 9:08 AM
F13969387: D8476.id.diff
Oct 17 2024, 2:16 AM
F13958231: D8476.id20088.diff
Oct 14 2024, 1:35 PM
Unknown Object (File)
Sep 20 2024, 7:52 PM
Unknown Object (File)
Sep 14 2024, 5:08 PM
Unknown Object (File)
Sep 14 2024, 5:07 PM
Subscribers

Details

Summary

Ref T2222.

  • Removes DifferentialTasksAttacher, which has had no callsites for a very long time.
  • Moves differential.getrevisioncomments off DifferentialCommentQuery.
  • Moves Releeph churn field off DifferentialCommentQuery.
  • Removes dead code in DifferentialRevisionViewController.
  • Removes DifferentialException (no references).
  • Removes DifferentialRevision->loadComments() (no callsites).
  • Removes DifferentialRevision->loadReviewedBy() (all callsites updated).
  • Removes DifferentialCommentQuery (all callsites updated).
Test Plan

Mostly a lot of grep.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

btrahan edited edge metadata.
This revision is now accepted and ready to land.Mar 10 2014, 6:48 PM
epriestley updated this revision to Diff 20129.

Closed by commit rP592591e71538 (authored by @epriestley).