Page MenuHomePhabricator

Clean up various pieces of dead/obsolete Differential code
ClosedPublic

Authored by epriestley on Mar 9 2014, 8:49 PM.
Tags
None
Referenced Files
F18112845: D8476.id.diff
Tue, Aug 12, 9:24 PM
F18110546: D8476.id20129.diff
Mon, Aug 11, 8:54 PM
F18107074: D8476.id.diff
Sun, Aug 10, 11:38 PM
F18105003: D8476.diff
Sun, Aug 10, 3:40 PM
F18090517: D8476.diff
Wed, Aug 6, 4:07 PM
F17868713: D8476.id20129.diff
Jul 28 2025, 8:53 AM
F17845300: D8476.diff
Jul 27 2025, 3:17 AM
Unknown Object (File)
Jul 4 2025, 3:52 PM
Subscribers

Details

Summary

Ref T2222.

  • Removes DifferentialTasksAttacher, which has had no callsites for a very long time.
  • Moves differential.getrevisioncomments off DifferentialCommentQuery.
  • Moves Releeph churn field off DifferentialCommentQuery.
  • Removes dead code in DifferentialRevisionViewController.
  • Removes DifferentialException (no references).
  • Removes DifferentialRevision->loadComments() (no callsites).
  • Removes DifferentialRevision->loadReviewedBy() (all callsites updated).
  • Removes DifferentialCommentQuery (all callsites updated).
Test Plan

Mostly a lot of grep.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

btrahan edited edge metadata.
This revision is now accepted and ready to land.Mar 10 2014, 6:48 PM
epriestley updated this revision to Diff 20129.

Closed by commit rP592591e71538 (authored by @epriestley).