Page MenuHomePhabricator

Clean up various pieces of dead/obsolete Differential code
ClosedPublic

Authored by epriestley on Mar 9 2014, 8:49 PM.
Tags
None
Referenced Files
F15586017: D8476.diff
Thu, May 8, 12:01 PM
F15582119: D8476.id.diff
Wed, May 7, 3:05 PM
F15567945: D8476.diff
Fri, May 2, 6:40 PM
F15517835: D8476.id20088.diff
Sat, Apr 19, 8:53 AM
F15463124: D8476.id.diff
Apr 1 2025, 8:31 PM
F15462982: D8476.id20088.diff
Apr 1 2025, 7:29 PM
F15455215: D8476.id.diff
Mar 29 2025, 10:54 PM
F15450765: D8476.id20129.diff
Mar 28 2025, 6:08 PM
Subscribers

Details

Summary

Ref T2222.

  • Removes DifferentialTasksAttacher, which has had no callsites for a very long time.
  • Moves differential.getrevisioncomments off DifferentialCommentQuery.
  • Moves Releeph churn field off DifferentialCommentQuery.
  • Removes dead code in DifferentialRevisionViewController.
  • Removes DifferentialException (no references).
  • Removes DifferentialRevision->loadComments() (no callsites).
  • Removes DifferentialRevision->loadReviewedBy() (all callsites updated).
  • Removes DifferentialCommentQuery (all callsites updated).
Test Plan

Mostly a lot of grep.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

btrahan edited edge metadata.
This revision is now accepted and ready to land.Mar 10 2014, 6:48 PM
epriestley updated this revision to Diff 20129.

Closed by commit rP592591e71538 (authored by @epriestley).