Page MenuHomePhabricator
Create Task
Maniphest T9123

Build Phabricator in Harbormaster (v2)
Closed, ResolvedPublic
Actions

Assigned To
epriestley
Authored By
epriestley
Aug 10 2015, 1:36 PM
Tags
Referenced Files
F852114: Screen Shot 2015-09-29 at 2.15.22 PM.png
Sep 29 2015, 9:16 PM
Subscribers
amckinley
• baylisscg
benjamin.cohen-solal
Bezalel
cburroughs
chad
clippit
View All 33 Subscribers
Tokens
"Yellow Medal" token, awarded by thoughtpolice."Mountain of Wealth" token, awarded by eklitzke."The World Burns" token, awarded by joshuaspence.

Description

Harbormaster is unprototyped, but currently not powerful enough to build Phabricator itself. In the next iteration, I want to add build platform features so the upstream builds can execute on Harbormaster.

In particular, this means:

  • Running arc lint and arc unit on a Drydock host.
  • Executing builds for both revisions and commits.
  • Easily uploading lint/unit results to Harbormaster, likely via new --target flags.
  • (T2543) We should also get --draft / --try built here.
  • Likely shoring up a lot of log/state infrastructure.

Revisions and Commits

rP Phabricator
D14242rP2bfa0e087e00 Improve consistency and Harbormaster integration of Diffusion
D14185rPa5c417716056 Fix an issue with BuildLogs and web UI during builds
D14184rPefaa8170c353 Simplify value decoding for PHID custom fields
D14183rPbfaa93aa9b2c Allow Harbormaster build plans to request additional working copies

Related Objects
Search...

StatusAssignedTask
 DuplicateNoneT7869 Support CircleCI webhooks for Test results (so that one can run unit tests asynchronously)
 ResolvedepriestleyT9456 Evaluate upstream support for third-party build systems
 ResolvedepriestleyT9123 Build Phabricator in Harbormaster (v2)
 OpenNoneT9124 Support uploading build log data via the Harbormaster API
 ResolvedepriestleyT5955 Refactor Conduit auth to be stateless, token-based, and support wire encodings
 ResolvedbtrahanT5603 Implement a separate "Can Leave Project" policy
 OpenNoneT5821 Implement "Run Arc Unit" build step and support showing unit test results inside Harbormaster
 Resolvedhach-queT5831 Run all build commands through PowerShell on Windows
 ResolvedepriestleyT9252 Unprototype Drydock (v1)
 ResolvedepriestleyT9253 Implement a Drydock blueprint for leasing hosts from a static, pre-built Almanac pool
 ResolvedepriestleyT9431 Deploy an "sbuild" tier outside of the cluster
 ResolvedNoneT9519 Design the Drydock Blueprint selection mechanism
 ResolvedepriestleyT2543 Add a formal "Draft" / "Not Yet Ready for Review" state to Differential
 ResolvedepriestleyT2222 Implement ApplicationTransactions in Differential
Restricted Maniphest Task
Restricted Maniphest Task
Restricted Maniphest Task
Restricted Maniphest Task
Restricted Maniphest Task
Restricted Maniphest Task
 ResolvedepriestleyT4481 Differential Update Feedback / Rough Edges / Status
 ResolvedepriestleyT13027 When revisions autopromote out of "Draft", Herald rules blocked by "Draft" do not trigger until the next edit
 ResolvedepriestleyT13035 Differential drops draft mail when prototypes are enabled but no build plans are configured
 ResolvedepriestleyT9352 Write some custom Herald glue for driving builds through Owners
 ResolvedNoneT9351 Add CustomField support to Owners
 OpenNoneT9365 Harbormaster results are hard to aggregate

Event Timeline

epriestley created this task.Aug 10 2015, 1:36 PM
epriestley raised the priority of this task from to Normal.
epriestley updated the task description. (Show Details)
epriestley added a project: Harbormaster.
epriestley moved this task to v2 on the Harbormaster board.
epriestley added a subscriber: epriestley.
hach-que added a subscriber: hach-que.Aug 10 2015, 2:24 PM

Isn't Phabricator entirely PHP? What is there to build?

Or does this task just mean running "arc unit --everything" on a build server?

epriestley added a comment.Aug 10 2015, 2:25 PM

It means running arc unit on a build server.

epriestley added a subtask: T5821: Implement "Run Arc Unit" build step and support showing unit test results inside Harbormaster.Aug 10 2015, 2:43 PM
cburroughs added a subscriber: cburroughs.Aug 10 2015, 2:51 PM
matthewrbowker added a subscriber: matthewrbowker.Aug 10 2015, 4:25 PM
devurandom added a subscriber: devurandom.Aug 10 2015, 4:34 PM
chad added a subscriber: chad.Aug 10 2015, 4:43 PM
richardvanvelzen added a subscriber: richardvanvelzen.Aug 10 2015, 4:55 PM
elesh added a subscriber: elesh.Aug 10 2015, 6:10 PM
joshuaspence awarded a token.Aug 10 2015, 8:38 PM
joshuaspence added a subscriber: joshuaspence.
joshuaspence added a comment.Aug 10 2015, 9:45 PM

I don't imagine this is in v2, but we could build XHPAST in Harbormaster. This would be good for the unfortunate souls that use Windows.

epriestley mentioned this in T8089: Unprototype Harbormaster (v1).Aug 10 2015, 10:40 PM
epriestley mentioned this in T9223: Allow `arc diff` to run a build step like `gradle` first, then read lint and unit messages from the output.Aug 20 2015, 4:54 PM
joshuaspence added a comment.Aug 23 2015, 6:32 AM

Is this going to include the ability to build (i.e. lint and test) diffs as well, or is that part of v3?

epriestley mentioned this in T9252: Unprototype Drydock (v1).Aug 24 2015, 4:59 PM
epriestley added a subtask: T9252: Unprototype Drydock (v1).

Since we're pushing everything to staging, I expect that to be covered here.

epriestley mentioned this in Z1336: General Chat.Aug 24 2015, 6:58 PM
epriestley mentioned this in T182: Commit into repository directly from differential.Aug 25 2015, 6:15 PM
mbishopim3 added a subscriber: mbishopim3.Aug 26 2015, 6:32 PM
epriestley added a project: Prioritized.Sep 6 2015, 5:50 PM
epriestley moved this task from Backlog to Preflight on the Prioritized board.
epriestley added a subtask: T2543: Add a formal "Draft" / "Not Yet Ready for Review" state to Differential.Sep 6 2015, 6:25 PM
epriestley updated the task description. (Show Details)Sep 6 2015, 6:28 PM
epriestley added a subtask: T9352: Write some custom Herald glue for driving builds through Owners.Sep 6 2015, 7:27 PM
sectioneight added a subscriber: sectioneight.Sep 8 2015, 11:05 PM
epriestley added a subtask: T9365: Harbormaster results are hard to aggregate .Sep 8 2015, 11:21 PM
eklitzke awarded a token.Sep 9 2015, 10:31 PM
eklitzke added a subscriber: eklitzke.
thoughtpolice awarded a token.Sep 10 2015, 2:22 PM
thoughtpolice added a subscriber: thoughtpolice.
epriestley mentioned this in T9395: harbormaster.sendmessage does not update build status for the same build target..Sep 11 2015, 1:36 PM
Pawka added a subscriber: Pawka.Sep 11 2015, 1:40 PM
epriestley mentioned this in Roadmap.Sep 13 2015, 3:17 PM
fcoelho added a subscriber: fcoelho.Sep 13 2015, 9:19 PM
sascha-egerer added a subscriber: sascha-egerer.Sep 15 2015, 8:15 PM
epriestley mentioned this in T6111: Give Drydock leases an explicit ownership PHID.Sep 16 2015, 3:43 PM
epriestley mentioned this in T9265: UI/UX: Show Drydock lease logs in Harbormaster.Sep 16 2015, 3:47 PM
epriestley mentioned this in T9456: Evaluate upstream support for third-party build systems.Sep 21 2015, 8:57 PM
epriestley mentioned this in T7869: Support CircleCI webhooks for Test results (so that one can run unit tests asynchronously).Sep 21 2015, 9:02 PM
epriestley added a parent task: T9456: Evaluate upstream support for third-party build systems.Sep 21 2015, 9:23 PM
clippit added a subscriber: clippit.Sep 22 2015, 9:29 AM
johnny-bit added a subscriber: johnny-bit.Sep 22 2015, 10:26 AM
benjamin.cohen-solal added a subscriber: benjamin.cohen-solal.Sep 22 2015, 3:06 PM
epriestley mentioned this in T8671: Support complex resource constraints across multiple resources in Drydock.Sep 23 2015, 5:34 PM
epriestley mentioned this in D13505: [drydock/working-copies/v0] Implement the working copy blueprint.Sep 23 2015, 6:12 PM
epriestley mentioned this in 2015 Week 39 (Very Late September).Sep 26 2015, 1:35 PM
epriestley added a comment.Sep 26 2015, 4:00 PM

There's some relevant information on the progress on the Drydock side of this here: T9252#138215

epriestley added a revision: D14183: Allow Harbormaster build plans to request additional working copies.Sep 28 2015, 11:39 PM
epriestley added a commit: rPbfaa93aa9b2c: Allow Harbormaster build plans to request additional working copies.Sep 29 2015, 12:57 AM
epriestley added a revision: D14184: Simplify value decoding for PHID custom fields.Sep 29 2015, 1:03 AM
epriestley added a commit: rPefaa8170c353: Simplify value decoding for PHID custom fields.Sep 29 2015, 1:44 AM
epriestley added a revision: D14185: Fix an issue with BuildLogs and web UI during builds.Sep 29 2015, 2:10 AM
epriestley added a commit: rPa5c417716056: Fix an issue with BuildLogs and web UI during builds.Sep 29 2015, 2:11 AM
epriestley added a comment.Sep 29 2015, 2:12 AM

We technically have builds now:

vhbit added a subscriber: vhbit.Sep 29 2015, 2:02 PM
epriestley added a comment.Sep 29 2015, 9:16 PM

We're kinda-sort doing builds for commits now:

Screen Shot 2015-09-29 at 2.15.22 PM.png (201×798 px, 38 KB)

• baylisscg added a subscriber: • baylisscg.Sep 30 2015, 4:41 AM
sascha-egerer added a comment.Sep 30 2015, 11:19 AM
In T9123#138576, @epriestley wrote:

We're kinda-sort doing builds for commits now:

Screen Shot 2015-09-29 at 2.15.22 PM.png (201×798 px, 38 KB)

Macro yaaay:

epriestley mentioned this in 2015 Week 40 (Very Early October).Oct 3 2015, 12:07 PM
epriestley added a comment.Oct 6 2015, 12:35 AM

Per T9252, we're now building all the repositories and all Community revisions, so the meat of this is working. There are still a lot of pieces that need refinement or generalization, though, or aren't even theoretically useful to installs other than this one for various reasons.

chad added a comment.EditedOct 6 2015, 12:52 AM

mmm meat

epriestley added a revision: D14242: Improve consistency and Harbormaster integration of Diffusion.Oct 6 2015, 1:02 PM
epriestley added a commit: rP2bfa0e087e00: Improve consistency and Harbormaster integration of Diffusion.Oct 6 2015, 2:38 PM
wienczny added a subscriber: wienczny.Oct 7 2015, 12:35 AM
jasonfsmitty added a subscriber: jasonfsmitty.Oct 7 2015, 11:09 AM
epriestley mentioned this in T731: Allow revisions to have alternate acceptance conditions.Oct 8 2015, 7:23 PM
epriestley mentioned this in 2015 Week 41 (Early October).Oct 10 2015, 11:47 AM
epriestley moved this task from Preflight to Paused on the Prioritized board.Oct 10 2015, 1:30 PM
epriestley mentioned this in Blog Post: Development Notes (2015 Week 41).Oct 10 2015, 1:33 PM
jra3 added a subscriber: jra3.Oct 14 2015, 8:50 PM
epriestley mentioned this in 2015 Week 42 (Mid October).Oct 17 2015, 11:06 AM
epriestley closed subtask T9252: Unprototype Drydock (v1) as Resolved.Oct 27 2015, 9:54 PM
ox added a subscriber: ox.Oct 30 2015, 3:50 PM
joshma added a subscriber: joshma.Nov 11 2015, 5:24 AM
wonglkd added a subscriber: wonglkd.Nov 18 2015, 1:28 PM
epriestley closed subtask T9352: Write some custom Herald glue for driving builds through Owners as Resolved.Dec 18 2015, 12:40 PM
epriestley mentioned this in Starmap.Jan 2 2016, 1:42 PM
• cwang added a subscriber: • cwang.Jan 3 2016, 11:04 AM
dpaola2 added a subscriber: dpaola2.Jan 4 2016, 5:41 PM
Bezalel added a subscriber: Bezalel.Feb 25 2016, 10:42 AM
epriestley closed this task as Resolved.Mar 3 2016, 11:26 PM
epriestley claimed this task.

Upstream builds have been in production for some time. There's always more work to be done, but I don't think there's anything actionable left here that isn't covered elswhere.

urzds added a subscriber: urzds.Jul 12 2017, 11:12 AM
Herald added a subscriber: eadler. · View Herald TranscriptJul 12 2017, 11:12 AM
epriestley closed subtask T2543: Add a formal "Draft" / "Not Yet Ready for Review" state to Differential as Resolved.Feb 13 2020, 12:20 AM
Herald added a subscriber: amckinley. · View Herald TranscriptFeb 13 2020, 12:20 AM
Phabricator · Built by Phacility