Page MenuHomePhabricator

Extract textual object list parsing from Differential
ClosedPublic

Authored by epriestley on Mar 8 2014, 12:01 AM.
Tags
None
Referenced Files
F18806669: D8445.id20040.diff
Sat, Oct 18, 8:56 PM
F18760177: D8445.id.diff
Mon, Oct 6, 8:24 AM
F18758456: D8445.diff
Sun, Oct 5, 10:25 PM
F18622617: D8445.diff
Sep 15 2025, 12:28 PM
F18592288: D8445.diff
Sep 12 2025, 11:53 AM
F18455061: D8445.id.diff
Sep 1 2025, 8:01 AM
F18446522: D8445.diff
Aug 31 2025, 9:42 PM
F18241942: D8445.id20047.diff
Aug 21 2025, 3:40 AM
Subscribers

Details

Summary

Ref T2222. Currently, Differential has a fairly hairy piece of logic to parse object lists, like Reviewers: alincoln, htaft. Extract, generalize, and cover this.

  • Some of the logic can be simplified with modern ObjectQuery stuff.
  • Make @username the formal monogram for users.
  • Make list@domain.com the formal monogram for mailing lists.
  • Add test coverage.
Test Plan
  • Ran unit tests.
  • Called differential.parsecommitmessage with a bunch of real-world inputs and got sensible results.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

btrahan edited edge metadata.
This revision is now accepted and ready to land.Mar 8 2014, 12:41 AM