Page MenuHomePhabricator

Extract textual object list parsing from Differential
ClosedPublic

Authored by epriestley on Mar 8 2014, 12:01 AM.
Tags
None
Referenced Files
F15363965: D8445.id.diff
Tue, Mar 11, 12:55 PM
Unknown Object (File)
Feb 24 2025, 9:10 AM
Unknown Object (File)
Feb 22 2025, 9:08 AM
Unknown Object (File)
Feb 16 2025, 1:03 AM
Unknown Object (File)
Feb 14 2025, 10:52 PM
Unknown Object (File)
Feb 10 2025, 2:55 AM
Unknown Object (File)
Feb 9 2025, 11:48 AM
Unknown Object (File)
Feb 9 2025, 11:48 AM
Subscribers

Details

Summary

Ref T2222. Currently, Differential has a fairly hairy piece of logic to parse object lists, like Reviewers: alincoln, htaft. Extract, generalize, and cover this.

  • Some of the logic can be simplified with modern ObjectQuery stuff.
  • Make @username the formal monogram for users.
  • Make list@domain.com the formal monogram for mailing lists.
  • Add test coverage.
Test Plan
  • Ran unit tests.
  • Called differential.parsecommitmessage with a bunch of real-world inputs and got sensible results.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

btrahan edited edge metadata.
This revision is now accepted and ready to land.Mar 8 2014, 12:41 AM