Page MenuHomePhabricator

Extract textual object list parsing from Differential
ClosedPublic

Authored by epriestley on Mar 8 2014, 12:01 AM.
Tags
None
Referenced Files
F19320329: D8445.diff
Thu, Dec 25, 8:49 AM
F18877383: D8445.id.diff
Nov 6 2025, 7:59 AM
F18876163: D8445.diff
Nov 5 2025, 10:10 PM
F18854237: D8445.diff
Oct 31 2025, 10:40 PM
F18852955: D8445.id20047.diff
Oct 31 2025, 1:13 PM
F18851879: D8445.id.diff
Oct 31 2025, 4:50 AM
F18806669: D8445.id20040.diff
Oct 18 2025, 8:56 PM
F18760177: D8445.id.diff
Oct 6 2025, 8:24 AM
Subscribers

Details

Summary

Ref T2222. Currently, Differential has a fairly hairy piece of logic to parse object lists, like Reviewers: alincoln, htaft. Extract, generalize, and cover this.

  • Some of the logic can be simplified with modern ObjectQuery stuff.
  • Make @username the formal monogram for users.
  • Make list@domain.com the formal monogram for mailing lists.
  • Add test coverage.
Test Plan
  • Ran unit tests.
  • Called differential.parsecommitmessage with a bunch of real-world inputs and got sensible results.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

btrahan edited edge metadata.
This revision is now accepted and ready to land.Mar 8 2014, 12:41 AM