Page MenuHomePhabricator

Extract textual object list parsing from Differential
ClosedPublic

Authored by epriestley on Mar 8 2014, 12:01 AM.
Tags
None
Referenced Files
F18107063: D8445.id.diff
Sun, Aug 10, 11:38 PM
F18098079: D8445.id20047.diff
Fri, Aug 8, 6:24 PM
F17963911: D8445.id.diff
Fri, Aug 1, 10:52 AM
F17959875: D8445.id20040.diff
Fri, Aug 1, 8:39 AM
F17950494: D8445.diff
Fri, Aug 1, 12:27 AM
F17867680: D8445.id20040.diff
Mon, Jul 28, 6:32 AM
F17830977: D8445.diff
Sat, Jul 26, 11:35 AM
Unknown Object (File)
Jun 29 2025, 6:13 AM
Subscribers

Details

Summary

Ref T2222. Currently, Differential has a fairly hairy piece of logic to parse object lists, like Reviewers: alincoln, htaft. Extract, generalize, and cover this.

  • Some of the logic can be simplified with modern ObjectQuery stuff.
  • Make @username the formal monogram for users.
  • Make list@domain.com the formal monogram for mailing lists.
  • Add test coverage.
Test Plan
  • Ran unit tests.
  • Called differential.parsecommitmessage with a bunch of real-world inputs and got sensible results.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

btrahan edited edge metadata.
This revision is now accepted and ready to land.Mar 8 2014, 12:41 AM