Page MenuHomePhabricator

Extract textual object list parsing from Differential
ClosedPublic

Authored by epriestley on Mar 8 2014, 12:01 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Jun 2, 10:50 PM
Unknown Object (File)
Apr 15 2026, 11:34 PM
Unknown Object (File)
Mar 28 2026, 3:11 PM
Unknown Object (File)
Mar 11 2026, 7:48 AM
Unknown Object (File)
Feb 28 2026, 4:57 PM
Unknown Object (File)
Feb 10 2026, 2:55 AM
Unknown Object (File)
Dec 25 2025, 8:49 AM
Unknown Object (File)
Nov 6 2025, 7:59 AM
Subscribers

Details

Summary

Ref T2222. Currently, Differential has a fairly hairy piece of logic to parse object lists, like Reviewers: alincoln, htaft. Extract, generalize, and cover this.

  • Some of the logic can be simplified with modern ObjectQuery stuff.
  • Make @username the formal monogram for users.
  • Make list@domain.com the formal monogram for mailing lists.
  • Add test coverage.
Test Plan
  • Ran unit tests.
  • Called differential.parsecommitmessage with a bunch of real-world inputs and got sensible results.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

btrahan edited edge metadata.
This revision is now accepted and ready to land.Mar 8 2014, 12:41 AM