Page MenuHomePhabricator
Create Task
Maniphest T5179

Unearth Differential rendering technical debt
Closed, ResolvedPublic
Actions

Description

We have a bunch of technical debt in Differential rendering that blocks a variety of infrastructure and UI improvements.

Revisions and Commits

rP Phabricator
D9294rPb20884a842a6 Substantially support character encodings and "Highlight As" in changesets
D9292rP4b39fbe1155e Allow modern hunks to be stored deflated
D9293rP40e2a1c800ff Write new hunks to the modern hunk store
D9291rP5b1262c98b8f Add a `bin/hunks` script to manage migrations of hunk data
D9290rP0aa913805d14 Add an alternate "modern" hunk datastore
D9289rPbb306b58d553 Introduce DifferentialChangesetQuery and remove loadHunks()
D9286rP7d0d6fbcf2e4 Consolidate changeset rendering logic
D9288rPcb58acbe5bcd Use DiffQuery instead of direct hunk loads in MessageParser daemon
D9287rP71e9fb96b56e Move more hunk loads into DifferentialHunkQuery

Related Objects
Search...

StatusAssignedTask
 ResolvedepriestleyT5644 Add controls to prevent `pygmentize` from saturating system resources
 ResolvedepriestleyT5179 Unearth Differential rendering technical debt
 ResolvedepriestleyT2183 unify "table of contents" views between Differential and Diffusion
Restricted Maniphest Task
 OpenjoshuaspenceT3626 Detection of language for some file types isn't good
Restricted Maniphest Task
 DuplicateNoneT4988 pygments is run even on very large changesets that won't be shown
 ResolvedepriestleyT2009 Refactor DifferentialChangesetParser to support 1-up views and sanity
Restricted Maniphest Task
 ResolvedepriestleyT4045 Store diffs as binary, not UTF-8
 ResolvedepriestleyT3788 Improve encoding management in Diffusion
 WontfixepriestleyT5030 Improve behavior when jumping to inline comments
 ResolvedepriestleyT1460 Add "Done" link to an inline comment
 ResolvedepriestleyT2222 Implement ApplicationTransactions in Differential
Restricted Maniphest Task
Restricted Maniphest Task
Restricted Maniphest Task
Restricted Maniphest Task
Restricted Maniphest Task
Restricted Maniphest Task
 ResolvedepriestleyT4481 Differential Update Feedback / Rough Edges / Status
 ResolvedbtrahanT4896 Move Audit to ApplicationTransactions
 ResolvedbtrahanT5745 Unable to post only inline comments to an audit
 ResolvedchadT7737 "Done" button has misleading UI states
 ResolvedNoneT7720 Incorrect "Unsubmitted" state detection for Audit inline comments
 ResolvedangieT7719 Impossible to submit "Done" inline comment state without adding a comment
 OpenNoneT8250 Would like to see all comments and their status in a list
 ResolvedNoneT8130 Keyboard shortcut for "Done"
 ResolvedNoneT8573 All reviewers should be allowed to mark a comment as done
 OpenNoneT2999 When we detect a file as binary, explain why
 OpenNoneT2495 Improve whitespace expansion of tab literals

Event Timeline

epriestley created this task.May 25 2014, 2:14 PM
epriestley claimed this task.
epriestley raised the priority of this task from to Normal.
epriestley updated the task description. (Show Details)
epriestley added a project: Differential.
epriestley added a subscriber: epriestley.
epriestley edited this Maniphest Task.May 25 2014, 2:16 PM
epriestley edited this Maniphest Task.May 25 2014, 2:20 PM
epriestley edited this Maniphest Task.May 25 2014, 3:11 PM
epriestley edited this Maniphest Task.May 25 2014, 3:24 PM
epriestley edited this Maniphest Task.May 25 2014, 4:01 PM
epriestley edited this Maniphest Task.May 25 2014, 4:36 PM
epriestley edited this Maniphest Task.May 25 2014, 5:02 PM
epriestley edited this Maniphest Task.May 25 2014, 6:50 PM
epriestley edited this Maniphest Task.May 25 2014, 7:05 PM
epriestley edited this Maniphest Task.May 25 2014, 8:41 PM
epriestley edited this Maniphest Task.May 25 2014, 9:10 PM
epriestley edited this Maniphest Task.May 27 2014, 2:02 PM
emaste added a subscriber: emaste.May 27 2014, 2:07 PM
joshuaspence added a subscriber: joshuaspence.May 29 2014, 8:34 AM
epriestley edited this Maniphest Task.Jun 4 2014, 1:03 AM
epriestley edited this Maniphest Task.
epriestley edited this Maniphest Task.
epriestley edited this Maniphest Task.
epriestley edited this Maniphest Task.
epriestley edited this Maniphest Task.
epriestley edited this Maniphest Task.
epriestley edited this Maniphest Task.
epriestley edited this Maniphest Task.Jun 20 2014, 6:49 PM
epriestley closed subtask Restricted Maniphest Task as Resolved.Aug 13 2014, 4:39 AM
octera added a subscriber: octera.Aug 15 2014, 10:04 PM
epriestley closed subtask T4988: pygments is run even on very large changesets that won't be shown as Duplicate.Aug 22 2014, 8:08 PM
epriestley moved this task from Backlog to v2 (UI/Mobile) on the Differential board.Mar 4 2015, 5:13 PM
epriestley closed this task as Resolved.Mar 6 2015, 12:31 AM

I'm just going to close this since there's nothing specifically actionable here and T2009 covers the same ground in a more measurable way.

We're in a much better position today than we were when this was filed, although the Differential rendering pipeline is still far from debt-free.

epriestley closed subtask T2009: Refactor DifferentialChangesetParser to support 1-up views and sanity as Resolved.Mar 10 2015, 12:36 AM
epriestley closed subtask Restricted Maniphest Task as Wontfix.Mar 24 2015, 8:13 PM
gabe mentioned this in T2495: Improve whitespace expansion of tab literals.Jul 22 2015, 4:15 PM
epriestley closed subtask T2183: unify "table of contents" views between Differential and Diffusion as Resolved.Aug 15 2015, 7:57 PM
epriestley closed subtask T1460: Add "Done" link to an inline comment as Resolved.Jul 7 2016, 10:48 PM
Herald added a subscriber: eadler. · View Herald TranscriptJul 7 2016, 10:48 PM
epriestley closed subtask T4045: Store diffs as binary, not UTF-8 as Resolved.Dec 13 2016, 5:44 PM
epriestley closed subtask T5030: Improve behavior when jumping to inline comments as Wontfix.May 16 2017, 5:34 PM
Phabricator · Built by Phacility