Page MenuHomePhabricator
Differential D8402

Make updates of rejected revisions behave correctly again
ClosedPublic
Actions

Authored by epriestley on Mar 5 2014, 1:55 AM.
Tags
None
Referenced Files
F14828297: D8402.diff
Wed, Jan 29, 10:43 AM
Unknown Object (File)
Tue, Jan 28, 7:55 AM
Unknown Object (File)
Tue, Jan 28, 7:55 AM
Unknown Object (File)
Mon, Jan 20, 12:46 AM
Unknown Object (File)
Tue, Jan 14, 1:36 PM
Unknown Object (File)
Sat, Jan 11, 12:01 PM
Unknown Object (File)
Sat, Jan 4, 2:45 PM
Unknown Object (File)
Dec 4 2024, 12:47 PM
View All Files
Subscribers
aran

Details

Reviewers
btrahan
Maniphest Tasks
T4481: Differential Update Feedback / Rough Edges / Status
T2222: Implement ApplicationTransactions in Differential
Commits
Restricted Diffusion Commit
rP9da6ec208111: Make updates of rejected revisions behave correctly again
Summary

Ref T2222. Ref T4481. Specifically:

  • When a revision is updated, change all "Reject" reviewers to "Reject Prior".
  • Change status to "Needs Review".
  • Update the state logic to account for this properly.
Test Plan
  • Created a revision as user A, with B as a reviewer.
  • Rejected as B.
  • Updated the revision as A.
  • Saw revision in "needs review" state, with B as a "Rejected Prior" reviewer.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

btrahan accepted this revision.Mar 5 2014, 6:35 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Mar 5 2014, 6:35 PM
epriestley closed this revision.Mar 5 2014, 6:47 PM

Closed by commit rP9da6ec208111 (authored by @epriestley).

Revision Contents
Changeset List

PathSize
src/
applications/
differential/
constants/
9 lines
editor/
45 lines
view/
12 lines

Diff 19969

View Options

src/applications/differential/constants/DifferentialReviewerStatus.php

Loading...
View Options

src/applications/differential/editor/DifferentialTransactionEditor.php

Loading...
View Options

src/applications/differential/view/DifferentialReviewersView.php

Loading...
Phabricator · Built by Phacility