Page MenuHomePhabricator

Make updates of rejected revisions behave correctly again
ClosedPublic

Authored by epriestley on Mar 5 2014, 1:55 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Mar 17, 9:37 AM
Unknown Object (File)
Feb 17 2024, 8:45 PM
Unknown Object (File)
Jan 29 2024, 9:49 PM
Unknown Object (File)
Jan 28 2024, 12:01 PM
Unknown Object (File)
Jan 27 2024, 8:15 PM
Unknown Object (File)
Jan 25 2024, 1:23 AM
Unknown Object (File)
Jan 25 2024, 1:23 AM
Unknown Object (File)
Jan 24 2024, 7:51 PM
Subscribers

Details

Summary

Ref T2222. Ref T4481. Specifically:

  • When a revision is updated, change all "Reject" reviewers to "Reject Prior".
  • Change status to "Needs Review".
  • Update the state logic to account for this properly.
Test Plan
  • Created a revision as user A, with B as a reviewer.
  • Rejected as B.
  • Updated the revision as A.
  • Saw revision in "needs review" state, with B as a "Rejected Prior" reviewer.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

btrahan edited edge metadata.
This revision is now accepted and ready to land.Mar 5 2014, 6:35 PM