Page MenuHomePhabricator
Differential D8402

Make updates of rejected revisions behave correctly again
ClosedPublic
Actions

Authored by epriestley on Mar 5 2014, 1:55 AM.
Tags
None
Referenced Files
F15585967: D8402.diff
Thu, May 8, 11:52 AM
F15575537: D8402.id19969.diff
Tue, May 6, 5:24 AM
F15575536: D8402.id19956.diff
Tue, May 6, 5:24 AM
F15575535: D8402.id.diff
Tue, May 6, 5:24 AM
F15562119: D8402.id19969.diff
Wed, Apr 30, 12:34 AM
F15555978: D8402.id.diff
Mon, Apr 28, 2:04 PM
F15550604: D8402.diff
Sun, Apr 27, 12:38 PM
F15529992: D8402.id.diff
Wed, Apr 23, 12:22 AM
View All Files
Subscribers
aran

Details

Reviewers
btrahan
Maniphest Tasks
T4481: Differential Update Feedback / Rough Edges / Status
T2222: Implement ApplicationTransactions in Differential
Commits
Restricted Diffusion Commit
rP9da6ec208111: Make updates of rejected revisions behave correctly again
Summary

Ref T2222. Ref T4481. Specifically:

  • When a revision is updated, change all "Reject" reviewers to "Reject Prior".
  • Change status to "Needs Review".
  • Update the state logic to account for this properly.
Test Plan
  • Created a revision as user A, with B as a reviewer.
  • Rejected as B.
  • Updated the revision as A.
  • Saw revision in "needs review" state, with B as a "Rejected Prior" reviewer.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

btrahan accepted this revision.Mar 5 2014, 6:35 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Mar 5 2014, 6:35 PM
epriestley closed this revision.Mar 5 2014, 6:47 PM

Closed by commit rP9da6ec208111 (authored by @epriestley).

Revision Contents
Changeset List

PathSize
src/
applications/
differential/
constants/
9 lines
editor/
45 lines
view/
12 lines

Diff 19969

View Options

src/applications/differential/constants/DifferentialReviewerStatus.php

Loading...
View Options

src/applications/differential/editor/DifferentialTransactionEditor.php

Loading...
View Options

src/applications/differential/view/DifferentialReviewersView.php

Loading...
Phabricator · Built by Phacility