Page MenuHomePhabricator

Reduce reliance on `getRevisionID()` on DifferentialComment
ClosedPublic

Authored by epriestley on Feb 12 2014, 6:47 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, May 26, 3:18 PM
Unknown Object (File)
Tue, May 20, 2:02 PM
Unknown Object (File)
Mon, May 19, 11:31 AM
Unknown Object (File)
Thu, May 8, 11:38 AM
Unknown Object (File)
Tue, May 6, 2:56 PM
Unknown Object (File)
Tue, May 6, 5:17 AM
Unknown Object (File)
Tue, May 6, 5:17 AM
Unknown Object (File)
Tue, May 6, 5:17 AM
Subscribers

Details

Summary

Ref T2222. A few rendering interfaces rely on fishing the revision ID out of a DifferentialComment, but it will only have the PHID soon. Pass in the revision and use it to determine the ID instead.

Test Plan

Browsed, previewed, examined comments. Clicked anchors.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

lamest inline feedback in awhile

src/applications/differential/controller/DifferentialCommentPreviewController.php
51

these could all be $viewer I s'pose