Differential D8454
Remove willWriteRevision/didWriteRevision hooks Authored by epriestley on Mar 8 2014, 8:04 PM. Tags None Referenced Files
Subscribers
Details
Ref T2222. DifferentialRevisionEditor has no remaining callsites, but it has a bit of functionality which still needs to be ported forward. I'm going to rip it apart piece by piece. This removes the willWriteRevision/didWriteRevision hooks. They are completely encapsulated by transactions now, except for a unique piece of branch/task logic, which I migrated forward.
Diff Detail
Event Timeline
Comment Actions I'm sort of waiting on user complaints for the event stuff. I think a lot of of what they were doing can be done through Herald and/or Harbormaster now. If there are meaningful remaining use cases we can put events into ApplicationTransactions itself. | ||||||||||||||||||||||||||||||||||||