Page MenuHomePhabricator

Separate revision updates into two separate comments
ClosedPublic

Authored by epriestley on Feb 11 2014, 10:42 PM.
Tags
None
Referenced Files
F15585874: D8200.diff
Thu, May 8, 11:37 AM
F15581506: D8200.diff
Wed, May 7, 11:21 AM
F15576283: D8200.id18554.diff
Tue, May 6, 9:04 AM
F15576282: D8200.id.diff
Tue, May 6, 9:03 AM
F15570003: D8200.id18551.diff
Sun, May 4, 6:44 AM
F15535727: D8200.id18554.diff
Thu, Apr 24, 6:27 AM
F15519111: D8200.id18551.diff
Sat, Apr 19, 8:02 PM
F15512292: D8200.id.diff
Thu, Apr 17, 9:36 AM
Subscribers

Details

Summary

Ref T2222. Instead of writing one comment which performs both a diff update and adds a comment, write two comments, one for each action. These will translate directly into ApplicationTransactions writes.

This has a small impact on the UX: these updates now render in two rows, instead of one. After T2222, they'll automerge back together.

{F111909}

Test Plan

Updated a revision.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped