Reduce surface area of DifferentialComment API
ClosedPublic
Actions

Authored by epriestley on Oct 21 2013, 3:11 PM.

Details

Reviewers

btrahan

Maniphest Tasks

Restricted Maniphest Task
T2222: Implement ApplicationTransactions in Differential

Commits

Restricted Diffusion Commit
rP32dd8af9e5d5: Reduce surface area of DifferentialComment API

Summary

Ref T2222. Shrink the API to make it easier to move this object's storage to ApplicationTransactions.

Fixes T3415. This moves the "Summary" and "Test Plan" into the property list, and thereby fixes all the attribution problems associated with commandeering, creating a revision from another user's diff, etc.

Test Plan

Browsed several revisions.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

Also reduce setRevisionID() to setRevision() and clean up some obsolete remarkup cache code.

This looks tons cleaner. :D

src/applications/differential/storage/DifferentialComment.php
23–25	even though it isn't used, i'd assume we'd have a getRevision method as well.

epriestley added inline comments.Oct 21 2013, 11:23 PM

src/applications/differential/storage/DifferentialComment.php
23–25	Oh, it's just so I can do the: - $this->revisionID = $revision->getID(); + $this->revisionPHID = $revision->getPHID(); ...thing when I swap the storage to ApplicationTransactions. Once that works I'll get rid of it.