Page MenuHomePhabricator

Use CustomFields in `differential.createrevision`
ClosedPublic

Authored by epriestley on Mar 8 2014, 7:29 PM.
Tags
None
Referenced Files
F14066823: D8452.diff
Tue, Nov 19, 12:02 PM
F14011237: D8452.id20115.diff
Thu, Oct 31, 9:54 PM
F13998161: D8452.diff
Thu, Oct 24, 7:55 AM
F13997695: D8452.diff
Thu, Oct 24, 5:44 AM
F13995709: D8452.id20115.diff
Wed, Oct 23, 2:54 PM
F13993954: D8452.id20057.diff
Wed, Oct 23, 2:38 AM
Unknown Object (File)
Oct 2 2024, 9:50 PM
Unknown Object (File)
Sep 12 2024, 9:16 AM
Subscribers

Details

Reviewers
btrahan
Maniphest Tasks
Restricted Maniphest Task
T2222: Implement ApplicationTransactions in Differential
Commits
Restricted Diffusion Commit
rPa5fbe921b7d2: Use CustomFields in `differential.createrevision`
Summary

Ref T2222. Ref T3886. Medium term goal is to remove DifferentialRevisionEditor.

This temporarily reduces a couple of pieces of functionality unique to the RevisionEditor, but I'm going to go clean those up in the next couple diffs.

Test Plan

Used arc diff --create to create several revisions with different data.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

btrahan edited edge metadata.
btrahan added inline comments.
src/applications/differential/conduit/ConduitAPI_differential_Method.php
46

nice refactor :)

This revision is now accepted and ready to land.Mar 10 2014, 4:33 PM
epriestley updated this revision to Diff 20115.

Closed by commit rPa5fbe921b7d2 (authored by @epriestley).