Page MenuHomePhabricator

Use CustomFields in `differential.createrevision`
ClosedPublic

Authored by epriestley on Mar 8 2014, 7:29 PM.
Tags
None
Referenced Files
F18457078: D8452.id.diff
Mon, Sep 1, 12:07 PM
F18087295: D8452.id20115.diff
Aug 6 2025, 3:21 AM
F17926730: D8452.id.diff
Jul 30 2025, 1:35 PM
F17912997: D8452.diff
Jul 29 2025, 5:07 PM
F17868742: D8452.id20115.diff
Jul 28 2025, 9:20 AM
F17841378: D8452.diff
Jul 26 2025, 10:21 PM
Unknown Object (File)
Jun 29 2025, 12:59 AM
Unknown Object (File)
Jun 29 2025, 12:26 AM
Subscribers

Details

Reviewers
btrahan
Maniphest Tasks
Restricted Maniphest Task
T2222: Implement ApplicationTransactions in Differential
Commits
Restricted Diffusion Commit
rPa5fbe921b7d2: Use CustomFields in `differential.createrevision`
Summary

Ref T2222. Ref T3886. Medium term goal is to remove DifferentialRevisionEditor.

This temporarily reduces a couple of pieces of functionality unique to the RevisionEditor, but I'm going to go clean those up in the next couple diffs.

Test Plan

Used arc diff --create to create several revisions with different data.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

btrahan edited edge metadata.
btrahan added inline comments.
src/applications/differential/conduit/ConduitAPI_differential_Method.php
46

nice refactor :)

This revision is now accepted and ready to land.Mar 10 2014, 4:33 PM
epriestley updated this revision to Diff 20115.

Closed by commit rPa5fbe921b7d2 (authored by @epriestley).