Page MenuHomePhabricator
Differential D8452

Use CustomFields in `differential.createrevision`
ClosedPublic
Actions

Authored by epriestley on Mar 8 2014, 7:29 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Mar 2, 2:31 AM
Unknown Object (File)
Mon, Feb 24, 11:34 AM
Unknown Object (File)
Thu, Feb 13, 8:13 AM
Unknown Object (File)
Sun, Feb 9, 11:49 AM
Unknown Object (File)
Sun, Feb 9, 11:49 AM
Unknown Object (File)
Sun, Feb 9, 11:49 AM
Unknown Object (File)
Sun, Feb 9, 11:49 AM
Unknown Object (File)
Sun, Feb 9, 2:19 AM
View All Files
Subscribers
aran

Details

Reviewers
btrahan
Maniphest Tasks
Restricted Maniphest Task
T2222: Implement ApplicationTransactions in Differential
Commits
Restricted Diffusion Commit
rPa5fbe921b7d2: Use CustomFields in `differential.createrevision`
Summary

Ref T2222. Ref T3886. Medium term goal is to remove DifferentialRevisionEditor.

This temporarily reduces a couple of pieces of functionality unique to the RevisionEditor, but I'm going to go clean those up in the next couple diffs.

Test Plan

Used arc diff --create to create several revisions with different data.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

btrahan accepted this revision.Mar 10 2014, 4:33 PM
btrahan edited edge metadata.
btrahan added inline comments.
src/applications/differential/conduit/ConduitAPI_differential_Method.php
46

nice refactor :)

This revision is now accepted and ready to land.Mar 10 2014, 4:33 PM
epriestley closed this revision.Mar 11 2014, 8:06 PM
epriestley updated this revision to Diff 20115.

Closed by commit rPa5fbe921b7d2 (authored by @epriestley).

Revision Contents
Changeset List

Diff 20115

View Options

src/applications/differential/conduit/ConduitAPI_differential_Method.php

Loading...
View Options

src/applications/differential/conduit/ConduitAPI_differential_createrevision_Method.php

Loading...
View Options

src/applications/differential/conduit/ConduitAPI_differential_updaterevision_Method.php

Loading...
View Options

src/applications/differential/customfield/DifferentialSummaryField.php

Loading...
View Options

src/applications/differential/customfield/DifferentialTestPlanField.php

Loading...
View Options

src/applications/differential/storage/DifferentialTransaction.php

Loading...
View Options

src/applications/transactions/storage/PhabricatorApplicationTransaction.php

Loading...
View Options

src/infrastructure/customfield/field/PhabricatorCustomField.php

Loading...
Phabricator · Built by Phacility