Page MenuHomePhabricator

Let Herald activation depend on which transactions are being applied, and generate transactions

Authored by epriestley on Mar 5 2014, 3:03 AM.
Referenced Files
Unknown Object (File)
Mon, Sep 19, 3:33 AM
Unknown Object (File)
Mon, Sep 19, 3:32 AM
Unknown Object (File)
Mon, Sep 19, 3:32 AM
Unknown Object (File)
Sat, Sep 10, 7:23 PM
Unknown Object (File)
Aug 6 2022, 4:01 AM
Unknown Object (File)
Jul 18 2022, 9:07 PM
Unknown Object (File)
Jul 9 2022, 11:31 AM
Unknown Object (File)
Jul 7 2022, 4:03 AM



Ref T2222. Ref T4484. This is a stepping stone to getting Herald supported in the new Differental code. Generally:

  • Instead of an Editor either supporting or not supporting Herald, let it choose based on transactions. Specifically, Differential only runs rules on revision creation and diff updates.
  • Optionally, allow an Editor to return some transactions to apply instead of having to apply everything itself. This lets us make it clear why changes happend in the transaction log, and share more code.
  • I updated only one transaction type (owners in Maniphest) since it was the easiest and cleanest to update and test. Everything else still works like it used to, it just won't generate a transaction record yet.
  • The transaction records are a touch rough, but we can clean them up later.
Test Plan


Diff Detail

Lint Skipped
Tests Skipped

Event Timeline

btrahan edited edge metadata.
btrahan added inline comments.


This revision is now accepted and ready to land.Mar 5 2014, 6:50 PM