Page MenuHomePhabricator

Implement "words of power" against ApplicationTransactions
ClosedPublic

Authored by epriestley on Feb 28 2014, 12:50 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Mar 23, 9:07 PM
Unknown Object (File)
Feb 21 2024, 2:17 AM
Unknown Object (File)
Feb 11 2024, 11:30 AM
Unknown Object (File)
Jan 29 2024, 3:34 PM
Unknown Object (File)
Jan 25 2024, 5:35 PM
Unknown Object (File)
Jan 25 2024, 5:35 PM
Unknown Object (File)
Jan 25 2024, 5:35 PM
Unknown Object (File)
Jan 24 2024, 9:18 PM
Subscribers

Details

Summary

Ref T2222. Differential has certain "words of power" (like Ref T123 or Depends on D345) which should expand into a separate transaction when they appear anywhere in text.

Currently, they're respected in only some fields. I'm expanding them to work in any remarkup field, including comments and inline comments.

This partially generalizes transaction expansion/extraction in comments. Eventually, I'll probably implement some very soft sort of reference edge for T4036, maybe.

Test Plan

{F119368}

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

btrahan edited edge metadata.

LGTM, but in your test plan shouldn't D895 also have been attached? (maybe it already was attached or something)

Slightly disappointed "words of power" didn't appear in the diff itself. :/

This revision is now accepted and ready to land.Feb 28 2014, 5:23 PM

I was making those comments on D985 to test that it didn't attach. <_<