Differential D8362

Use "CommentPro" controller instead of "Comment" controller
ClosedPublic
Actions

Authored by epriestley on Feb 27 2014, 6:47 PM.

Tags

None

Referenced Files

	F15443602: D8362.diff
	Thu, Mar 27, 5:13 AM

	F15427765: D8362.id19876.diff
	Sun, Mar 23, 3:58 PM

	F15426248: D8362.diff
	Sun, Mar 23, 7:51 AM

	F15405098: D8362.diff
	Tue, Mar 18, 10:16 AM

	F15401422: D8362.id19880.diff
	Mon, Mar 17, 5:36 PM

	F15400866: D8362.id.diff
	Mon, Mar 17, 2:25 PM

	F15399402: D8362.id19876.diff
	Mon, Mar 17, 4:24 AM

	F15398184: D8362.diff
	Sun, Mar 16, 11:42 PM

Subscribers

Details

Reviewers

Maniphest Tasks

T2222: Implement ApplicationTransactions in Differential

Commits

Restricted Diffusion Commit
rPba7d67f9175f: Use "CommentPro" controller instead of "Comment" controller

Summary

Ref T2222. This will probabaly have a few rough edges too, but seems to work well.

Test Plan

Made a bunch of comments while building this.
Made some new comments.
Verified that the Asana/JIRA integration is only a little bit janky, not completely broken.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

btrahan accepted this revision.Feb 27 2014, 7:06 PM

Closed by commit rPba7d67f9175f (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

resources/

celerity/

582 lines

src/

__phutil_library_map__.php

2 lines

applications/

differential/

application/

PhabricatorApplicationDifferential.php

3 lines

controller/

DifferentialCommentSaveController.php

195 lines

DifferentialCommentSaveControllerPro.php

DifferentialRevisionViewController.php

9 lines

editor/

DifferentialTransactionEditor.php

4 lines

Diff 19880

resources/celerity/map.php

Loading...

src/__phutil_library_map__.php

Loading...

src/applications/differential/application/PhabricatorApplicationDifferential.php

Loading...

src/applications/differential/controller/DifferentialCommentSaveController.php

Loading...

src/applications/differential/controller/DifferentialCommentSaveControllerPro.php

Loading...

src/applications/differential/controller/DifferentialRevisionViewController.php

Loading...

src/applications/differential/editor/DifferentialTransactionEditor.php

Loading...