Page MenuHomePhabricator

Move Differential to proper subscriptions
ClosedPublic

Authored by epriestley on Feb 12 2014, 12:18 AM.
Tags
None
Referenced Files
F14055508: D8202.diff
Sat, Nov 16, 12:36 PM
F14042316: D8202.diff
Tue, Nov 12, 2:28 AM
F14027263: D8202.diff
Fri, Nov 8, 6:05 AM
F13960943: D8202.id18557.diff
Oct 15 2024, 2:16 AM
F13958704: D8202.id18561.diff
Oct 14 2024, 4:10 PM
F13958480: D8202.id.diff
Oct 14 2024, 2:59 PM
Unknown Object (File)
Sep 6 2024, 10:08 AM
Unknown Object (File)
Sep 4 2024, 2:49 PM
Subscribers
Tokens
"Doubloon" token, awarded by btrahan.

Details

Summary

Ref T2222. Ref T4415. We're still writing Differential subscription stuff into this weird legacy differential_relationship table, which is like an edge table but extremely ancient.

Move it into a proper table.

I've removed withSubscriptions() from DifferentialRevisionQuery. It was weird, doesn't work consistently with other similar filters, and was only used by the API. Now it means "ccs", which is consistent with the ApplicationSearch UI and with Maniphest.

Test Plan

Without migrating, added and removed subscribers via various workflows. Queried for subscribers. Everything worked as expected.

Ran the migration, verified data survived.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

src/applications/differential/editor/DifferentialRevisionEditor.php
697

goodbye terrible code

no one will miss you

src/applications/differential/storage/DifferentialRevision.php
236โ€“237

I'll fix this, no longer accurate.

epriestley updated this revision to Unknown Object (????).Feb 12 2014, 12:20 AM
  • Remove comment about reading out of old table; we no longer do this.
resources/sql/autopatches/20140211.dx.3.migsubscriptions.sql
6โ€“11

pretty cool