Page MenuHomePhabricator

Move Differential to proper subscriptions
ClosedPublic

Authored by epriestley on Feb 12 2014, 12:18 AM.
Tags
None
Referenced Files
F15466777: D8202.diff
Thu, Apr 3, 9:41 AM
F15428078: D8202.diff
Sun, Mar 23, 6:34 PM
F15425387: D8202.id18556.diff
Sun, Mar 23, 4:30 AM
F15400167: D8202.id18557.diff
Mon, Mar 17, 10:05 AM
F15397232: D8202.id.diff
Sun, Mar 16, 7:04 PM
F15395334: D8202.id18556.diff
Sun, Mar 16, 5:52 AM
F15392169: D8202.diff
Sat, Mar 15, 1:36 PM
F15378788: D8202.id18561.diff
Thu, Mar 13, 5:02 PM
Subscribers
Tokens
"Doubloon" token, awarded by btrahan.

Details

Summary

Ref T2222. Ref T4415. We're still writing Differential subscription stuff into this weird legacy differential_relationship table, which is like an edge table but extremely ancient.

Move it into a proper table.

I've removed withSubscriptions() from DifferentialRevisionQuery. It was weird, doesn't work consistently with other similar filters, and was only used by the API. Now it means "ccs", which is consistent with the ApplicationSearch UI and with Maniphest.

Test Plan

Without migrating, added and removed subscribers via various workflows. Queried for subscribers. Everything worked as expected.

Ran the migration, verified data survived.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

src/applications/differential/editor/DifferentialRevisionEditor.php
697

goodbye terrible code

no one will miss you

src/applications/differential/storage/DifferentialRevision.php
236โ€“237

I'll fix this, no longer accurate.

epriestley updated this revision to Unknown Object (????).Feb 12 2014, 12:20 AM
  • Remove comment about reading out of old table; we no longer do this.
resources/sql/autopatches/20140211.dx.3.migsubscriptions.sql
6โ€“11

pretty cool