Page MenuHomePhabricator
Differential D8236

Render Differential previews through ApplicationTransactions
ClosedPublic
Actions

Authored by epriestley on Feb 14 2014, 9:08 PM.
Tags
None
Referenced Files
F15436794: D8236.diff
Tue, Mar 25, 4:34 PM
F15422346: D8236.diff
Sat, Mar 22, 7:27 AM
F15411469: D8236.id19600.diff
Wed, Mar 19, 9:18 AM
F15398683: D8236.id19597.diff
Mon, Mar 17, 1:14 AM
F15378830: D8236.diff
Thu, Mar 13, 5:16 PM
F15335109: D8236.diff
Mar 8 2025, 2:22 PM
Unknown Object (File)
Feb 24 2025, 9:11 AM
Unknown Object (File)
Feb 15 2025, 11:25 AM
View All Files
Subscribers
aran
Tokens
"Piece of Eight" token, awarded by btrahan.

Details

Reviewers
btrahan
Maniphest Tasks
T2222: Implement ApplicationTransactions in Differential
Commits
Restricted Diffusion Commit
rP23146f2bb9e7: Render Differential previews through ApplicationTransactions
Summary

Ref T2222. Use new code for rendering. Delete DifferentialRevisionCommentView, which has no remaining callsites.

Test Plan

Went through all the different actions and verified the previews rendered correctly. Reloaded page to test draft behavior.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Revision Contents
Changeset List

PathSize
src/
2 lines
applications/
differential/
controller/
104 lines
view/

Diff 19600

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/differential/controller/DifferentialCommentPreviewController.php

Loading...
View Options

src/applications/differential/view/DifferentialRevisionCommentView.php

Loading...
Phabricator · Built by Phacility