Paths

Table of Contentst

Differential D8444

Move Differential commit message parsing to a separate, tested class
ClosedPublic
Actions

Authored by epriestley on Mar 7 2014, 10:22 PM.

Details

Reviewers

btrahan

Maniphest Tasks

T2222: Implement ApplicationTransactions in Differential

Commits

Restricted Diffusion Commit
rPaff34077c52c: Move Differential commit message parsing to a separate, tested class

Summary

Ref T2222. We have a hunk of logic that purely does text parsing here; separate it and get coverage on it.

Test Plan

Ran new unit tests.
Used differential.parsecommitmessage.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

btrahan accepted this revision.Mar 8 2014, 12:41 AM

btrahan edited edge metadata.

This revision is now accepted and ready to land.Mar 8 2014, 12:41 AM

Closed by commit rPaff34077c52c (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

__phutil_library_map__.php

3 lines

applications/

differential/

conduit/

ConduitAPI_differential_parsecommitmessage_Method.php

105 lines

parser/

DifferentialCommitMessageParser.php

210 lines

__tests__/

DifferentialCommitMessageParserTestCase.php

65 lines

messages/

17 lines

11 lines

15 lines

24 lines

12 lines

9 lines

Diff 20046

View Options

src/__phutil_library_map__.php

View Options

src/applications/differential/conduit/ConduitAPI_differential_parsecommitmessage_Method.php

View Options

src/applications/differential/parser/DifferentialCommitMessageParser.php

View Options

src/applications/differential/parser/tests/DifferentialCommitMessageParserTestCase.php

View Options

src/applications/differential/parser/tests/messages/double-field.txt

View Options

src/applications/differential/parser/tests/messages/long-title.txt

View Options

src/applications/differential/parser/tests/messages/multi-label.txt

View Options

src/applications/differential/parser/tests/messages/normal.txt

View Options

src/applications/differential/parser/tests/messages/simple.txt

View Options

src/applications/differential/parser/tests/messages/trivial.txt

Move Differential commit message parsing to a separate, tested classClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 20046

src/__phutil_library_map__.php

src/applications/differential/conduit/ConduitAPI_differential_parsecommitmessage_Method.php

src/applications/differential/parser/DifferentialCommitMessageParser.php

src/applications/differential/parser/__tests__/DifferentialCommitMessageParserTestCase.php

src/applications/differential/parser/__tests__/messages/double-field.txt

src/applications/differential/parser/__tests__/messages/long-title.txt

src/applications/differential/parser/__tests__/messages/multi-label.txt

src/applications/differential/parser/__tests__/messages/normal.txt

src/applications/differential/parser/__tests__/messages/simple.txt

src/applications/differential/parser/__tests__/messages/trivial.txt

Move Differential commit message parsing to a separate, tested class
ClosedPublic
Actions

Revision Contents
Changeset List

src/applications/differential/parser/tests/DifferentialCommitMessageParserTestCase.php

src/applications/differential/parser/tests/messages/double-field.txt

src/applications/differential/parser/tests/messages/long-title.txt

src/applications/differential/parser/tests/messages/multi-label.txt

src/applications/differential/parser/tests/messages/normal.txt

src/applications/differential/parser/tests/messages/simple.txt

src/applications/differential/parser/tests/messages/trivial.txt