Page MenuHomePhabricator

Implement most Differential actions against ApplicationTransactions
ClosedPublic

Authored by epriestley on Feb 22 2014, 11:40 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Feb 24, 11:31 AM
Unknown Object (File)
Mon, Feb 17, 1:30 PM
Unknown Object (File)
Sun, Feb 16, 12:26 AM
Unknown Object (File)
Sat, Feb 15, 11:28 AM
Unknown Object (File)
Tue, Feb 11, 1:46 PM
Unknown Object (File)
Sun, Feb 9, 11:36 AM
Unknown Object (File)
Sun, Feb 9, 11:36 AM
Unknown Object (File)
Sun, Feb 9, 11:36 AM
Subscribers

Details

Summary

Ref T2222. Implements the simpler actions (abandon, reclaim, close, reopen, plan changes, request review) in a transactional way with validation and effect checks.

Test Plan
  • Rigged submissions to point at the Pro controller.
  • Rigged dropdown to have all these options all the time.
  • Tried to apply about 20-30 of these operations to various revisions and always got the expected result (success, error, or no-op).

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped