Add modern Unit/Lint field support
ClosedPublic
Actions

Authored by epriestley on Feb 27 2014, 6:19 PM.

Tags

None

Referenced Files

	F15441816: D8360.id19873.diff
	Wed, Mar 26, 8:12 PM

	F15440959: D8360.id19873.diff
	Wed, Mar 26, 3:43 PM

	F15424566: D8360.id.diff
	Sat, Mar 22, 11:03 PM

	F15418796: D8360.id19879.diff
	Fri, Mar 21, 1:31 AM

	F15413420: D8360.diff
	Wed, Mar 19, 6:34 PM

	F15402585: D8360.id.diff
	Mon, Mar 17, 11:05 PM

	F15402448: D8360.id19879.diff
	Mon, Mar 17, 10:35 PM

	F15396351: D8360.diff
	Sun, Mar 16, 1:43 PM

Subscribers

Details

Reviewers

btrahan

Maniphest Tasks

T2222: Implement ApplicationTransactions in Differential

Commits

Summary

Ref T2222. This is mostly copy/paste. No effect yet.

Test Plan

Looked at fields.

Lint

Lint Skipped

Unit

Tests Skipped

btrahan added inline comments.

src/applications/differential/customfield/DifferentialUnitField.php
187–192	pht?

src/applications/differential/customfield/DifferentialLintField.php
38	These implementations need a cleanup pass in general (beyond missing `pht()`, this is bad too, e.g.), but I want to push through to running them as authoritative before mucking with them more than necessary.