Page MenuHomePhabricator

Add modern Unit/Lint field support
ClosedPublic

Authored by epriestley on Feb 27 2014, 6:19 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Dec 17, 11:13 AM
Unknown Object (File)
Mon, Dec 16, 7:04 PM
Unknown Object (File)
Fri, Dec 13, 3:10 AM
Unknown Object (File)
Wed, Dec 11, 2:06 AM
Unknown Object (File)
Wed, Dec 4, 4:35 PM
Unknown Object (File)
Wed, Dec 4, 12:41 PM
Unknown Object (File)
Tue, Dec 3, 8:38 PM
Unknown Object (File)
Tue, Dec 3, 7:58 PM
Subscribers

Details

Summary

Ref T2222. This is mostly copy/paste. No effect yet.

Test Plan

Looked at fields.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

btrahan added inline comments.
src/applications/differential/customfield/DifferentialUnitField.php
187–192

pht?

src/applications/differential/customfield/DifferentialLintField.php
38

These implementations need a cleanup pass in general (beyond missing pht(), this is bad too, e.g.), but I want to push through to running them as authoritative before mucking with them more than necessary.