Page MenuHomePhabricator

Add modern Unit/Lint field support
ClosedPublic

Authored by epriestley on Feb 27 2014, 6:19 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Apr 20, 6:32 PM
Unknown Object (File)
Mon, Apr 8, 10:44 AM
Unknown Object (File)
Fri, Mar 29, 5:03 AM
Unknown Object (File)
Fri, Mar 29, 3:53 AM
Unknown Object (File)
Thu, Mar 28, 3:00 PM
Unknown Object (File)
Mar 20 2024, 7:57 PM
Unknown Object (File)
Feb 17 2024, 4:17 PM
Unknown Object (File)
Jan 26 2024, 1:53 AM
Subscribers

Details

Summary

Ref T2222. This is mostly copy/paste. No effect yet.

Test Plan

Looked at fields.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

btrahan added inline comments.
src/applications/differential/customfield/DifferentialUnitField.php
187–192

pht?

src/applications/differential/customfield/DifferentialLintField.php
38

These implementations need a cleanup pass in general (beyond missing pht(), this is bad too, e.g.), but I want to push through to running them as authoritative before mucking with them more than necessary.