Page MenuHomePhabricator

Add modern Unit/Lint field support
ClosedPublic

Authored by epriestley on Feb 27 2014, 6:19 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Jan 28, 6:17 PM
Unknown Object (File)
Fri, Jan 24, 2:14 AM
Unknown Object (File)
Tue, Jan 21, 11:34 AM
Unknown Object (File)
Fri, Jan 17, 2:20 AM
Unknown Object (File)
Mon, Jan 13, 1:07 AM
Unknown Object (File)
Dec 29 2024, 11:49 PM
Unknown Object (File)
Dec 29 2024, 5:19 AM
Unknown Object (File)
Dec 20 2024, 12:26 PM
Subscribers

Details

Summary

Ref T2222. This is mostly copy/paste. No effect yet.

Test Plan

Looked at fields.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

btrahan added inline comments.
src/applications/differential/customfield/DifferentialUnitField.php
187–192

pht?

src/applications/differential/customfield/DifferentialLintField.php
38

These implementations need a cleanup pass in general (beyond missing pht(), this is bad too, e.g.), but I want to push through to running them as authoritative before mucking with them more than necessary.