Page MenuHomePhabricator

Use ApplicationTransactions/CustomField to power Differential global search
ClosedPublic

Authored by epriestley on Feb 26 2014, 12:15 AM.
Tags
None
Referenced Files
F19067988: D8346.id.diff
Nov 30 2025, 11:16 AM
F19063704: D8346.diff
Nov 29 2025, 7:34 PM
F18874866: D8346.diff
Nov 5 2025, 4:07 PM
F18841803: D8346.id.diff
Oct 28 2025, 11:26 AM
F18839951: D8346.diff
Oct 27 2025, 8:08 PM
F18749592: D8346.id19850.diff
Oct 4 2025, 4:23 AM
F18704217: D8346.id.diff
Sep 28 2025, 6:37 AM
F18697737: D8346.id19850.diff
Sep 27 2025, 10:03 AM
Subscribers

Details

Summary

Ref T2222. Ref T3886. Ref T418. A few changes:

  • CustomField can now index into global search.
  • Use CustomField fields instead of older custom fields for Differential global search. (This slightly breaks any custom fields which exist, but they are presumably very rare, and probably do not exist; this break is also very mild.)
  • Automatically perform CustomField and Subscribable indexing on applicable object types.
Test Plan

Used bin/search index to reindex a bunch of stuff, then searched for it. Debug-dumped abstract documents to inspect them.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

btrahan added inline comments.
src/applications/maniphest/search/ManiphestSearchIndexer.php
84

<3 these deletions