Page MenuHomePhabricator

Use ApplicationTransactions/CustomField to power Differential global search
ClosedPublic

Authored by epriestley on Feb 26 2014, 12:15 AM.
Tags
None
Referenced Files
F14061096: D8346.diff
Mon, Nov 18, 5:08 AM
F14046824: D8346.diff
Thu, Nov 14, 12:04 AM
F14038516: D8346.id19850.diff
Mon, Nov 11, 12:08 AM
F14033478: D8346.diff
Sat, Nov 9, 5:45 PM
F14020368: D8346.diff
Wed, Nov 6, 12:26 AM
F14018482: D8346.id19850.diff
Tue, Nov 5, 1:52 PM
F14010116: D8346.id19850.diff
Thu, Oct 31, 5:09 AM
F14004519: D8346.id19843.diff
Sat, Oct 26, 10:03 PM
Subscribers

Details

Summary

Ref T2222. Ref T3886. Ref T418. A few changes:

  • CustomField can now index into global search.
  • Use CustomField fields instead of older custom fields for Differential global search. (This slightly breaks any custom fields which exist, but they are presumably very rare, and probably do not exist; this break is also very mild.)
  • Automatically perform CustomField and Subscribable indexing on applicable object types.
Test Plan

Used bin/search index to reindex a bunch of stuff, then searched for it. Debug-dumped abstract documents to inspect them.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

btrahan added inline comments.
src/applications/maniphest/search/ManiphestSearchIndexer.php
84

<3 these deletions