Page MenuHomePhabricator

Request: ability to select line range for comment via touchscreen
Closed, ResolvedPublic

Description

They only way to comment on a range of lines of code (e.g. Lines 15-18) is to click and drag. This isn't possible on a touch device (in my case, the rare example of using Facebook Phabricator with VPN on iPhone/iPad), and even if it were, could be clumsy and inaccurate.

Perhaps provide a text input field in the comment dialog, where we can modify the line numbers after the fact on new comments (but not replies)? See the attached mockup screenshot.

Event Timeline

mbush attached 1 file(s): Restricted File.
mbush added a subscriber: mbush.
epriestley triaged this task as Low priority.Mar 21 2012, 10:15 PM

I played around with this a little bit. We can support the same interaction, the only problem is that "touchmove" doesn't have a target like "mouseover" does so we'd have to have a piece of code to figure out what's under the finger as it moves.

I accidentally created a possibly-better interaction by just listening to "touchstart", which is: tap to set first line, tap again to set final line. This needs UI hinting to be workable though since it's not intuitive.

My accuracy seemed reasonably okay on my iPad -- do I have particularly nimble fingers?

We're also thinking about providing a one-column diff layout for iPad / iPhone, although the two-column seems OK on my iPad. The one column layout could increase the size of the line targets to make the interaction easier.

Overall, iPad/iPhone stuff is pretty low priority since it's not clear how much use it would get, but we're onboard with making small improvements at least.

btrahan added a project: Differential.
epriestley edited this Maniphest Task.Mar 29 2013, 1:35 AM
epriestley added a subscriber: Unknown Object (MLST).Sep 3 2013, 11:35 PM

Via FB.

chad changed the visibility from "All Users" to "Public (No Login Required)".Jul 3 2015, 4:41 AM
epriestley moved this task from Backlog to Glitches on the Inline Comments board.Apr 21 2017, 12:25 PM
epriestley moved this task from Glitches to Reticle on the Inline Comments board.May 16 2017, 8:15 PM

I currently expect to revert this change and decline to implement the feature because it makes using Differential on a phone more difficult for left-handed users (scrolling and leaving comments on a line range become conflated). See T12733#224703 for detailed discussion. If you'd like to champion this feature, let us know in the next 7 seconds.

I currently expect to revert this change and decline to implement the feature because it makes using Differential on a phone more difficult for left-handed users

As a left-handed user, I thank you for reverting this change.