Page MenuHomePhabricator

Make Pholio work better on mobile
Closed, DuplicatePublic

Description

Pholio currently doesn't show images or thumbnails on mobile.

Revisions and Commits

rP Phabricator
D9562
Restricted Differential Revision
Restricted Differential Revision

Related Objects

StatusAssignedTask
Resolvedepriestley
Resolvedepriestley
DuplicateNone

Event Timeline

epriestley triaged this task as Normal priority.Mar 3 2013, 7:41 PM
epriestley added a project: Pholio.
epriestley added a subscriber: epriestley.
epriestley edited this Maniphest Task.Mar 3 2013, 7:41 PM
epriestley edited this Maniphest Task.Mar 5 2013, 4:22 PM
epriestley edited this Maniphest Task.Mar 5 2013, 8:27 PM
epriestley edited this Maniphest Task.Mar 8 2013, 5:54 PM
epriestley edited this Maniphest Task.Mar 20 2013, 3:14 PM
epriestley edited this Maniphest Task.Apr 1 2013, 12:50 AM
epriestley edited this Maniphest Task.Apr 1 2013, 1:06 AM
epriestley edited this Maniphest Task.Apr 1 2013, 7:54 PM

What still needs to be done here? This is the last task under 'unbeta pholio', which itself is #2 on our roadmap.

@chad might have the best answer here, but let me dig through the security queue and I'll see what I can come up with.

I can't immediately find too many issues. Here's the stuff I see and/or remember after playing around with it a bit:

  • There's no animation when swiping images.
  • When you tap to zoom, we don't focus on the part of the image you tapped.
  • Inline comment reticles are shown, but there is no way to interact with them (you can't see the associated comments for a given area).
  • There is no way to add or edit inline comments.
  • When editing a mock, the UI for image changes doesn't fit on screen. See screenshot below, the "X" is cut off.
  • When editing a mock, the UI for adding images can't be interacted with (no way to "Drag and drop images here...").

Some reasonable remedies might be:

  • Call swiping/zooming post-beta features.
  • Don't render the inline rectangles on mobile.
  • No adding/editing inlines via mobile for now.
  • Make the edit UI a little smaller so it fits?
  • Hide the add UI (no updating via mobile).
  • Error on the "Create" UI?
chad added a comment.Mar 18 2014, 7:53 PM

Seems like there should be some way to add photos from your phone.

chad moved this task to On Deck on the Pholio board.Mar 21 2014, 5:21 AM

I'm going to do these for now:

  • Make the edit UI a little smaller so it fits?
  • Hide the add UI (no updating via mobile).

And push everything else to v2.

With iOS 6+ it looks like we can add files from the phone, but we need to do all the post-to-hidden <iframe /> junk to make the uploads work.

(Or, apparently on recent-ish browsers, we can maybe use FormData to ajax <input type="file" ... /> controls. Let me see how far I can get with that.)

FormData does work (see T5187) but I think creating mocks from your phone is a v2+ feature since I can't really imagine any use cases which aren't off-label unless maybe you're drawing stuff out with a pencil and paper, which is something I actually do, but I am firmly not a designer so presumably real designers would find my methods and practices abhorrent.

chad added a comment.Jun 15 2014, 9:51 PM

My assumption is the add image from phone is an all around Phabricator feature, nothing specific with Pholio.

Yeah -- you can already do it in Files (since we have a normal upload there). T5187 will let you do it in comment boxes, and then we can extend that into Pholio eventually.

epriestley edited this Maniphest Task.Jun 15 2014, 9:59 PM
epriestley renamed this task from Make Pholio work on mobile to Make Pholio work better on mobile.Jun 15 2014, 10:00 PM
epriestley moved this task from On Deck to v2 on the Pholio board.
epriestley edited this Maniphest Task.Jun 15 2014, 10:00 PM
epriestley edited this Maniphest Task.
chad moved this task from v2 to On Deck on the Pholio board.Jun 22 2014, 7:49 PM
chad moved this task from On Deck to Backlog on the Pholio board.Jun 30 2015, 2:40 AM
chad changed the visibility from "All Users" to "Public (No Login Required)".Jul 23 2015, 4:39 AM