Page MenuHomePhabricator

Implement Accept/Reject in ApplicationTransactions, approximately
ClosedPublic

Authored by epriestley on Feb 25 2014, 4:16 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Jun 29, 12:08 AM
Unknown Object (File)
Sat, Jun 28, 6:43 PM
Unknown Object (File)
Sat, Jun 28, 1:26 PM
Unknown Object (File)
Fri, Jun 27, 10:38 PM
Unknown Object (File)
Jun 9 2025, 1:59 AM
Unknown Object (File)
Jun 8 2025, 8:04 PM
Unknown Object (File)
Jun 7 2025, 8:04 AM
Unknown Object (File)
Jun 7 2025, 8:04 AM
Subscribers

Details

Summary

Ref T2222. This mostly makes Accept/Reject work. The big missing piece is that overall revision status does not yet update properly. I need to think about how I want that to work a little bit more.

Test Plan

Accepted and rejected some stuff.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

snihalani added a subscriber: snihalani.
snihalani added inline comments.
src/applications/differential/editor/DifferentialTransactionEditor.php
97

Should this be $will_add_reviewer instead?

snihalani edited edge metadata.

gonna remove the reviewer who accepted the revision who this review gets out of closed state.