Page MenuHomePhabricator

Implement Accept/Reject in ApplicationTransactions, approximately
ClosedPublic

Authored by epriestley on Feb 25 2014, 4:16 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mar 7 2026, 7:01 AM
Unknown Object (File)
Jan 29 2026, 4:33 PM
Unknown Object (File)
Jan 29 2026, 4:33 PM
Unknown Object (File)
Jan 12 2026, 8:18 AM
Unknown Object (File)
Jan 9 2026, 11:20 AM
Unknown Object (File)
Jan 8 2026, 8:57 PM
Unknown Object (File)
Nov 21 2025, 11:53 PM
Unknown Object (File)
Nov 20 2025, 10:00 PM
Subscribers

Details

Summary

Ref T2222. This mostly makes Accept/Reject work. The big missing piece is that overall revision status does not yet update properly. I need to think about how I want that to work a little bit more.

Test Plan

Accepted and rejected some stuff.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

snihalani added a subscriber: snihalani.
snihalani added inline comments.
src/applications/differential/editor/DifferentialTransactionEditor.php
97

Should this be $will_add_reviewer instead?

snihalani edited edge metadata.

gonna remove the reviewer who accepted the revision who this review gets out of closed state.