Page MenuHomePhabricator

Implement Accept/Reject in ApplicationTransactions, approximately
ClosedPublic

Authored by epriestley on Feb 25 2014, 4:16 AM.
Tags
None
Referenced Files
F18109456: D8333.id19830.diff
Mon, Aug 11, 1:47 PM
F18107001: D8333.id.diff
Sun, Aug 10, 11:35 PM
F18102786: D8333.id19830.diff
Sat, Aug 9, 11:17 PM
F18081634: D8333.id.diff
Tue, Aug 5, 1:18 AM
F18051684: D8333.diff
Mon, Aug 4, 12:03 AM
F17932563: D8333.diff
Wed, Jul 30, 8:23 PM
F17849244: D8333.id19813.diff
Sun, Jul 27, 8:26 AM
F17849243: D8333.diff
Sun, Jul 27, 8:26 AM
Subscribers

Details

Summary

Ref T2222. This mostly makes Accept/Reject work. The big missing piece is that overall revision status does not yet update properly. I need to think about how I want that to work a little bit more.

Test Plan

Accepted and rejected some stuff.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

snihalani added a subscriber: snihalani.
snihalani added inline comments.
src/applications/differential/editor/DifferentialTransactionEditor.php
97

Should this be $will_add_reviewer instead?

snihalani edited edge metadata.

gonna remove the reviewer who accepted the revision who this review gets out of closed state.