Page MenuHomePhabricator

Implement Accept/Reject in ApplicationTransactions, approximately
ClosedPublic

Authored by epriestley on Feb 25 2014, 4:16 AM.
Tags
None
Referenced Files
F18576708: D8333.id19830.diff
Wed, Sep 10, 4:18 PM
F18576644: D8333.id19813.diff
Wed, Sep 10, 4:12 PM
F18575640: D8333.diff
Wed, Sep 10, 1:35 PM
F18574851: D8333.id19813.diff
Wed, Sep 10, 11:53 AM
F18574745: D8333.id19830.diff
Wed, Sep 10, 11:46 AM
F18574597: D8333.id.diff
Wed, Sep 10, 11:12 AM
F18574206: D8333.diff
Wed, Sep 10, 10:24 AM
F18541759: D8333.diff
Sun, Sep 7, 9:34 PM
Subscribers

Details

Summary

Ref T2222. This mostly makes Accept/Reject work. The big missing piece is that overall revision status does not yet update properly. I need to think about how I want that to work a little bit more.

Test Plan

Accepted and rejected some stuff.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

snihalani added a subscriber: snihalani.
snihalani added inline comments.
src/applications/differential/editor/DifferentialTransactionEditor.php
97

Should this be $will_add_reviewer instead?

snihalani edited edge metadata.

gonna remove the reviewer who accepted the revision who this review gets out of closed state.