Page MenuHomePhabricator

Implement Accept/Reject in ApplicationTransactions, approximately
ClosedPublic

Authored by epriestley on Feb 25 2014, 4:16 AM.
Tags
None
Referenced Files
F15436791: D8333.id19830.diff
Tue, Mar 25, 4:34 PM
F15403054: D8333.id.diff
Tue, Mar 18, 1:45 AM
F15401827: D8333.id19813.diff
Mon, Mar 17, 7:24 PM
F15400896: D8333.id19830.diff
Mon, Mar 17, 2:33 PM
F15398928: D8333.diff
Mon, Mar 17, 1:55 AM
Unknown Object (File)
Feb 17 2025, 1:31 PM
Unknown Object (File)
Feb 17 2025, 1:31 PM
Unknown Object (File)
Feb 17 2025, 1:31 PM
Subscribers

Details

Summary

Ref T2222. This mostly makes Accept/Reject work. The big missing piece is that overall revision status does not yet update properly. I need to think about how I want that to work a little bit more.

Test Plan

Accepted and rejected some stuff.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

snihalani added a subscriber: snihalani.
snihalani added inline comments.
src/applications/differential/editor/DifferentialTransactionEditor.php
97

Should this be $will_add_reviewer instead?

snihalani edited edge metadata.

gonna remove the reviewer who accepted the revision who this review gets out of closed state.