Page MenuHomePhabricator

Implement Accept/Reject in ApplicationTransactions, approximately
ClosedPublic

Authored by epriestley on Feb 25 2014, 4:16 AM.
Tags
None
Referenced Files
F14059085: D8333.diff
Sun, Nov 17, 5:27 PM
F14047915: D8333.diff
Thu, Nov 14, 5:47 AM
F14041155: D8333.id.diff
Mon, Nov 11, 4:21 PM
F14034335: D8333.diff
Sat, Nov 9, 11:41 PM
F14018726: D8333.diff
Tue, Nov 5, 6:50 PM
F13995416: D8333.id19813.diff
Wed, Oct 23, 12:43 PM
F13978654: D8333.diff
Oct 19 2024, 12:19 AM
F13976323: D8333.diff
Oct 18 2024, 1:46 PM
Subscribers

Details

Summary

Ref T2222. This mostly makes Accept/Reject work. The big missing piece is that overall revision status does not yet update properly. I need to think about how I want that to work a little bit more.

Test Plan

Accepted and rejected some stuff.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

snihalani added a subscriber: snihalani.
snihalani added inline comments.
src/applications/differential/editor/DifferentialTransactionEditor.php
97

Should this be $will_add_reviewer instead?

snihalani edited edge metadata.

gonna remove the reviewer who accepted the revision who this review gets out of closed state.