Page MenuHomePhabricator

Mark reviewers as "commented" when they leave a comment
ClosedPublic

Authored by epriestley on Feb 25 2014, 8:19 PM.
Tags
None
Referenced Files
Unknown Object (File)
Apr 16 2026, 1:49 AM
Unknown Object (File)
Apr 15 2026, 1:26 PM
Unknown Object (File)
Apr 3 2026, 9:01 AM
Unknown Object (File)
Feb 4 2026, 3:06 PM
Unknown Object (File)
Jan 28 2026, 11:20 PM
Unknown Object (File)
Jan 9 2026, 4:48 PM
Unknown Object (File)
Jan 9 2026, 4:41 PM
Unknown Object (File)
Jan 3 2026, 12:52 PM
Subscribers

Details

Summary

Ref T2222. This requires one new trick:

  • When merging edge transactions which both add/update an edge, the Editor gets to control how the edge data is merged.

Specifically, we pick the "strongest" state to keep, so "accept + comment" leaves you with an accept instead of a comment.

Test Plan

Accepted, commented on, and comment + accepted revisions. Added some debugging dumps to verify that the merging was getting hit and working correctly.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped