Page MenuHomePhabricator

Mark reviewers as "commented" when they leave a comment
ClosedPublic

Authored by epriestley on Feb 25 2014, 8:19 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Jan 17, 8:54 AM
Unknown Object (File)
Fri, Jan 17, 2:20 AM
Unknown Object (File)
Sat, Jan 11, 2:28 AM
Unknown Object (File)
Dec 17 2024, 11:13 AM
Unknown Object (File)
Dec 4 2024, 3:50 PM
Unknown Object (File)
Dec 4 2024, 12:43 PM
Unknown Object (File)
Dec 3 2024, 8:40 PM
Unknown Object (File)
Nov 29 2024, 10:54 AM
Subscribers

Details

Summary

Ref T2222. This requires one new trick:

  • When merging edge transactions which both add/update an edge, the Editor gets to control how the edge data is merged.

Specifically, we pick the "strongest" state to keep, so "accept + comment" leaves you with an accept instead of a comment.

Test Plan

Accepted, commented on, and comment + accepted revisions. Added some debugging dumps to verify that the merging was getting hit and working correctly.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped