Page MenuHomePhabricator

Mark reviewers as "commented" when they leave a comment
ClosedPublic

Authored by epriestley on Feb 25 2014, 8:19 PM.
Tags
None
Referenced Files
F17935162: D8340.id19825.diff
Wed, Jul 30, 11:09 PM
F17926927: D8340.id.diff
Wed, Jul 30, 1:50 PM
F17910789: D8340.diff
Tue, Jul 29, 3:06 PM
F17853200: D8340.id19832.diff
Sun, Jul 27, 1:34 PM
F17843447: D8340.diff
Sun, Jul 27, 12:54 AM
Unknown Object (File)
Jun 29 2025, 4:17 AM
Unknown Object (File)
Jun 28 2025, 9:18 PM
Unknown Object (File)
Jun 28 2025, 2:11 PM
Subscribers

Details

Summary

Ref T2222. This requires one new trick:

  • When merging edge transactions which both add/update an edge, the Editor gets to control how the edge data is merged.

Specifically, we pick the "strongest" state to keep, so "accept + comment" leaves you with an accept instead of a comment.

Test Plan

Accepted, commented on, and comment + accepted revisions. Added some debugging dumps to verify that the merging was getting hit and working correctly.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped