Page MenuHomePhabricator

Mark reviewers as "commented" when they leave a comment
ClosedPublic

Authored by epriestley on Feb 25 2014, 8:19 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, May 25, 4:01 AM
Unknown Object (File)
Tue, May 20, 1:14 PM
Unknown Object (File)
Mon, May 19, 2:21 PM
Unknown Object (File)
Sat, May 10, 3:38 PM
Unknown Object (File)
Thu, May 8, 11:47 AM
Unknown Object (File)
Thu, May 8, 6:10 AM
Unknown Object (File)
Apr 22 2025, 1:06 PM
Unknown Object (File)
Apr 17 2025, 11:38 AM
Subscribers

Details

Summary

Ref T2222. This requires one new trick:

  • When merging edge transactions which both add/update an edge, the Editor gets to control how the edge data is merged.

Specifically, we pick the "strongest" state to keep, so "accept + comment" leaves you with an accept instead of a comment.

Test Plan

Accepted, commented on, and comment + accepted revisions. Added some debugging dumps to verify that the merging was getting hit and working correctly.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped