Page MenuHomePhabricator

Mark reviewers as "commented" when they leave a comment
ClosedPublic

Authored by epriestley on Feb 25 2014, 8:19 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Mar 2, 11:19 PM
Unknown Object (File)
Tue, Feb 18, 7:31 PM
Unknown Object (File)
Mon, Feb 17, 1:32 PM
Unknown Object (File)
Sun, Feb 16, 12:26 AM
Unknown Object (File)
Fri, Feb 14, 9:52 PM
Unknown Object (File)
Wed, Feb 12, 10:15 AM
Unknown Object (File)
Tue, Feb 11, 1:47 PM
Unknown Object (File)
Sun, Feb 9, 11:39 AM
Subscribers

Details

Summary

Ref T2222. This requires one new trick:

  • When merging edge transactions which both add/update an edge, the Editor gets to control how the edge data is merged.

Specifically, we pick the "strongest" state to keep, so "accept + comment" leaves you with an accept instead of a comment.

Test Plan

Accepted, commented on, and comment + accepted revisions. Added some debugging dumps to verify that the merging was getting hit and working correctly.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped