Page MenuHomePhabricator

Mark reviewers as "commented" when they leave a comment
ClosedPublic

Authored by epriestley on Feb 25 2014, 8:19 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Apr 14, 10:13 AM
Unknown Object (File)
Fri, Apr 12, 5:42 AM
Unknown Object (File)
Thu, Apr 11, 7:07 AM
Unknown Object (File)
Tue, Apr 9, 4:53 PM
Unknown Object (File)
Mar 5 2024, 6:45 AM
Unknown Object (File)
Feb 13 2024, 4:51 AM
Unknown Object (File)
Jan 28 2024, 10:02 AM
Unknown Object (File)
Jan 25 2024, 5:31 PM
Subscribers

Details

Summary

Ref T2222. This requires one new trick:

  • When merging edge transactions which both add/update an edge, the Editor gets to control how the edge data is merged.

Specifically, we pick the "strongest" state to keep, so "accept + comment" leaves you with an accept instead of a comment.

Test Plan

Accepted, commented on, and comment + accepted revisions. Added some debugging dumps to verify that the merging was getting hit and working correctly.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped