Page MenuHomePhabricator

Mark reviewers as "commented" when they leave a comment
ClosedPublic

Authored by epriestley on Feb 25 2014, 8:19 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Dec 17, 11:13 AM
Unknown Object (File)
Wed, Dec 4, 3:50 PM
Unknown Object (File)
Wed, Dec 4, 12:43 PM
Unknown Object (File)
Tue, Dec 3, 8:40 PM
Unknown Object (File)
Fri, Nov 29, 10:54 AM
Unknown Object (File)
Fri, Nov 29, 1:57 AM
Unknown Object (File)
Thu, Nov 28, 7:08 PM
Unknown Object (File)
Tue, Nov 26, 12:55 PM
Subscribers

Details

Summary

Ref T2222. This requires one new trick:

  • When merging edge transactions which both add/update an edge, the Editor gets to control how the edge data is merged.

Specifically, we pick the "strongest" state to keep, so "accept + comment" leaves you with an accept instead of a comment.

Test Plan

Accepted, commented on, and comment + accepted revisions. Added some debugging dumps to verify that the merging was getting hit and working correctly.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped