Page MenuHomePhabricator

Mark reviewers as "commented" when they leave a comment
ClosedPublic

Authored by epriestley on Feb 25 2014, 8:19 PM.
Tags
None
Referenced Files
F19914235: D8340.id19825.diff
Fri, Apr 3, 9:01 AM
F19622993: D8340.diff
Feb 4 2026, 3:06 PM
F19552259: D8340.id19832.diff
Jan 28 2026, 11:20 PM
F19506559: D8340.id19825.diff
Jan 9 2026, 4:48 PM
F19506145: D8340.id19832.diff
Jan 9 2026, 4:41 PM
F19467068: D8340.diff
Jan 3 2026, 12:52 PM
F18951966: D8340.id19825.diff
Nov 12 2025, 5:23 AM
F18905021: D8340.id19832.diff
Nov 8 2025, 12:29 PM
Subscribers

Details

Summary

Ref T2222. This requires one new trick:

  • When merging edge transactions which both add/update an edge, the Editor gets to control how the edge data is merged.

Specifically, we pick the "strongest" state to keep, so "accept + comment" leaves you with an accept instead of a comment.

Test Plan

Accepted, commented on, and comment + accepted revisions. Added some debugging dumps to verify that the merging was getting hit and working correctly.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped