Fix issue where new transaction comments can be spread across multiple transactions
ClosedPublic
Actions

Authored by epriestley on Feb 12 2014, 5:02 PM.

Tags

None

Referenced Files

	F18877825: D8206.id.diff
	Thu, Nov 6, 12:16 PM

	F18875729: D8206.diff
	Wed, Nov 5, 7:01 PM

	F18836883: D8206.id18563.diff
	Mon, Oct 27, 3:46 AM

	F18765505: D8206.id.diff
	Oct 7 2025, 11:37 AM

	F18759675: D8206.diff
	Oct 6 2025, 5:16 AM

	F18753400: D8206.id18563.diff
	Oct 4 2025, 6:36 PM

	F18751653: D8206.id.diff
	Oct 4 2025, 12:05 PM

	F18748356: D8206.diff
	Oct 3 2025, 8:52 PM

View All Files

Subscribers

aran

Details

Reviewers

btrahan
chad

Maniphest Tasks

T2222: Implement ApplicationTransactions in Differential

Commits

Restricted Diffusion Commit
rP54ce4a719eb7: Fix issue where new transaction comments can be spread across multiple…

Summary

Ref T2222. We need this clone when constructing the new multi-comments in Differential, or we get double-comments internally. This shows up as emails with double comment text.

Test Plan

Sent some "Accept + comment" emails, only one comment in the body.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

chad accepted this revision.Feb 12 2014, 5:05 PM

Closed by commit rP54ce4a719eb7 (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

storage/

DifferentialComment.php

6 lines

Diff 18565

View Options

src/applications/differential/storage/DifferentialComment.php

Fix issue where new transaction comments can be spread across multiple transactionsClosedPublicActions