Fix issue where new transaction comments can be spread across multiple transactions
ClosedPublic
Actions

Authored by epriestley on Feb 12 2014, 5:02 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, Dec 9, 2:03 PM

	Unknown Object (File)
	Sat, Dec 7, 4:48 PM

	Unknown Object (File)
	Thu, Dec 5, 12:36 AM

	Unknown Object (File)
	Wed, Dec 4, 12:47 PM

	Unknown Object (File)
	Tue, Dec 3, 8:38 PM

	Unknown Object (File)
	Tue, Dec 3, 10:16 AM

	Unknown Object (File)
	Sun, Dec 1, 3:22 AM

	Unknown Object (File)
	Nov 29 2024, 2:00 PM

View All Files

Subscribers

aran

Details

Reviewers

btrahan
chad

Maniphest Tasks

T2222: Implement ApplicationTransactions in Differential

Commits

Restricted Diffusion Commit
rP54ce4a719eb7: Fix issue where new transaction comments can be spread across multiple…

Summary

Ref T2222. We need this clone when constructing the new multi-comments in Differential, or we get double-comments internally. This shows up as emails with double comment text.

Test Plan

Sent some "Accept + comment" emails, only one comment in the body.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

chad accepted this revision.Feb 12 2014, 5:05 PM

Closed by commit rP54ce4a719eb7 (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

storage/

DifferentialComment.php

6 lines

Diff 18565

View Options

src/applications/differential/storage/DifferentialComment.php

Fix issue where new transaction comments can be spread across multiple transactionsClosedPublicActions