Fix issue where new transaction comments can be spread across multiple transactions
ClosedPublic
Actions

Authored by epriestley on Feb 12 2014, 5:02 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Sep 6, 10:09 AM

	Unknown Object (File)
	Thu, Aug 29, 12:49 PM

	Unknown Object (File)
	Sun, Aug 25, 5:01 PM

	Unknown Object (File)
	Sun, Aug 25, 5:24 AM

	Unknown Object (File)
	Tue, Aug 20, 6:52 AM

	Unknown Object (File)
	Thu, Aug 15, 12:34 AM

	Unknown Object (File)
	Tue, Aug 13, 8:01 PM

	Unknown Object (File)
	Fri, Aug 9, 7:21 PM

View All Files

Subscribers

aran

Details

Reviewers

btrahan
chad

Maniphest Tasks

T2222: Implement ApplicationTransactions in Differential

Commits

Restricted Diffusion Commit
rP54ce4a719eb7: Fix issue where new transaction comments can be spread across multiple…

Summary

Ref T2222. We need this clone when constructing the new multi-comments in Differential, or we get double-comments internally. This shows up as emails with double comment text.

Test Plan

Sent some "Accept + comment" emails, only one comment in the body.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

chad accepted this revision.Feb 12 2014, 5:05 PM

Closed by commit rP54ce4a719eb7 (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

storage/

DifferentialComment.php

6 lines

Diff 18565

View Options

src/applications/differential/storage/DifferentialComment.php

Fix issue where new transaction comments can be spread across multiple transactionsClosedPublicActions