Fix issue where new transaction comments can be spread across multiple transactions
ClosedPublic
Actions

Authored by epriestley on Feb 12 2014, 5:02 PM.

Tags

None

Referenced Files

	F15529144: D8206.id18565.diff
	Tue, Apr 22, 5:13 PM

	F15518092: D8206.id18565.diff
	Sat, Apr 19, 10:51 AM

	F15512617: D8206.id.diff
	Thu, Apr 17, 12:01 PM

	F15510059: D8206.diff
	Wed, Apr 16, 6:31 PM

	F15504233: D8206.diff
	Mon, Apr 14, 4:54 PM

	F15401793: D8206.id.diff
	Mar 17 2025, 7:16 PM

	F15391436: D8206.id18565.diff
	Mar 15 2025, 9:51 AM

	F15391179: D8206.id18565.diff
	Mar 15 2025, 8:33 AM

View All Files

Subscribers

aran

Details

Reviewers

btrahan
chad

Maniphest Tasks

T2222: Implement ApplicationTransactions in Differential

Commits

Restricted Diffusion Commit
rP54ce4a719eb7: Fix issue where new transaction comments can be spread across multiple…

Summary

Ref T2222. We need this clone when constructing the new multi-comments in Differential, or we get double-comments internally. This shows up as emails with double comment text.

Test Plan

Sent some "Accept + comment" emails, only one comment in the body.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

chad accepted this revision.Feb 12 2014, 5:05 PM

Closed by commit rP54ce4a719eb7 (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

storage/

DifferentialComment.php

6 lines

Diff 18565

View Options

src/applications/differential/storage/DifferentialComment.php

Fix issue where new transaction comments can be spread across multiple transactionsClosedPublicActions