Page MenuHomePhabricator

Write one DifferentialComment per CommentEditor action
ClosedPublic

Authored by epriestley on Feb 11 2014, 10:55 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Mar 22, 2:39 AM
Unknown Object (File)
Fri, Mar 22, 2:39 AM
Unknown Object (File)
Fri, Mar 22, 1:55 AM
Unknown Object (File)
Fri, Mar 22, 1:16 AM
Unknown Object (File)
Feb 19 2024, 5:48 PM
Unknown Object (File)
Feb 10 2024, 3:28 PM
Unknown Object (File)
Jan 27 2024, 3:25 PM
Unknown Object (File)
Jan 24 2024, 3:54 PM
Subscribers

Details

Summary

See D8200. Ref T2222. Instead of writing one comment which can have a ton of different effects, write a series of one-effect comments. These will be easier to convert into ApplicationTransactions.

This has a minor user-facing effect of making these multiple-action comments render separately:

{F111919}

Once the migration completes, they should automatically merge together nicely again.

Test Plan

Made a bunch of comments and took a bunch of actions, all of which worked normally except that they rendered as several things instead of just one.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley added a subscriber: Unknown Object (MLST).Feb 11 2014, 10:59 PM

Facebook: See inline. This return value is not used anywhere in Phabricator, but might be used by the hacked-up XMail setup. There is no longer a meaningful single value to return, because one action can generate several transactions.

src/applications/differential/mail/DifferentialReplyHandler.php
147

This here.