Paths

Table of Contentst

Fix double-rendering of inline comments in mail
ClosedPublic
Actions

Authored by epriestley on Feb 13 2014, 8:17 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Dec 11, 5:25 PM

	Unknown Object (File)
	Sun, Dec 8, 7:39 AM

	Unknown Object (File)
	Sun, Dec 8, 5:19 AM

	Unknown Object (File)
	Wed, Dec 4, 3:51 PM

	Unknown Object (File)
	Wed, Dec 4, 2:33 PM

	Unknown Object (File)
	Tue, Dec 3, 8:41 PM

	Unknown Object (File)
	Tue, Dec 3, 10:23 AM

	Unknown Object (File)
	Fri, Nov 29, 5:38 PM

View All Files

Subscribers

aran

Details

Reviewers

btrahan

Maniphest Tasks

T2222: Implement ApplicationTransactions in Differential

Commits

Restricted Diffusion Commit
rP29918e1bd47f: Fix double-rendering of inline comments in mail

Summary

Ref T2222. This is a tmp.differential-only issue. Inline comment transactions now have content, so we treat them like body text. We also render them separately as inline text. This produces mail where inlines are rendered twice.

Test Plan

Sent myself mail, saw only one copy of inlines.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

(Also fix missing string for "inline" action.)

btrahan accepted this revision.Feb 13 2014, 10:55 PM

Closed by commit rP29918e1bd47f (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

constants/

DifferentialAction.php

1 line

mail/

DifferentialCommentMail.php

4 lines

Diff 19554

View Options

src/applications/differential/constants/DifferentialAction.php