Page MenuHomePhabricator

Fix double-rendering of inline comments in mail
ClosedPublic

Authored by epriestley on Feb 13 2014, 8:17 PM.
Tags
None
Referenced Files
F14068754: D8216.diff
Wed, Nov 20, 12:36 AM
F14054329: D8216.diff
Sat, Nov 16, 12:37 AM
F14043112: D8216.diff
Tue, Nov 12, 7:40 AM
F14025471: D8216.diff
Thu, Nov 7, 6:18 PM
F13990073: D8216.id19554.diff
Tue, Oct 22, 12:55 AM
F13981446: D8216.id.diff
Oct 19 2024, 4:35 PM
F13980177: D8216.id19545.diff
Oct 19 2024, 8:55 AM
Unknown Object (File)
Sep 18 2024, 8:37 PM
Subscribers

Details

Summary

Ref T2222. This is a tmp.differential-only issue. Inline comment transactions now have content, so we treat them like body text. We also render them separately as inline text. This produces mail where inlines are rendered twice.

Test Plan

Sent myself mail, saw only one copy of inlines.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley updated this revision to Unknown Object (????).Feb 13 2014, 8:19 PM

(Also fix missing string for "inline" action.)