Page MenuHomePhabricator

Fix double-rendering of inline comments in mail
ClosedPublic

Authored by epriestley on Feb 13 2014, 8:17 PM.
Tags
None
Referenced Files
F22835483: D8216.id19545.diff
Sun, Oct 11, 5:39 AM
F22667097: D8216.id19554.diff
Thu, Oct 1, 2:48 PM
Unknown Object (File)
Sun, Sep 13, 5:56 PM
Unknown Object (File)
Sat, Sep 12, 3:20 PM
Unknown Object (File)
Aug 17 2026, 5:13 AM
Unknown Object (File)
Jul 2 2026, 8:14 PM
Unknown Object (File)
Apr 14 2026, 9:21 AM
Unknown Object (File)
Mar 27 2026, 8:12 PM
Subscribers

Details

Summary

Ref T2222. This is a tmp.differential-only issue. Inline comment transactions now have content, so we treat them like body text. We also render them separately as inline text. This produces mail where inlines are rendered twice.

Test Plan

Sent myself mail, saw only one copy of inlines.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley updated this revision to Unknown Object (????).Feb 13 2014, 8:19 PM

(Also fix missing string for "inline" action.)