Page MenuHomePhabricator
Create Task
Maniphest T5112

Alternative for Deprecated API: differential.getrevisioncomments
Closed, DuplicatePublic
Actions

Description

I saw differential.getrevisioncomments was deprecated. Is there an alternative for it?

Revisions and Commits

rARC Arcanist
D9464rARCf8be9d7737d1 Remove the `inlines` workflow

Related Objects

Event Timeline

donghang.guo created this task.May 19 2014, 9:22 PM
donghang.guo assigned this task to epriestley.
donghang.guo raised the priority of this task from to Normal.
donghang.guo updated the task description. (Show Details)
donghang.guo added projects: Differential, Transactions.
donghang.guo changed the visibility from "Public (No Login Required)" to "All Users".
donghang.guo added subscribers: epriestley, donghang.guo, peng.li.315213.
chad changed the visibility from "All Users" to "Public (No Login Required)".May 19 2014, 9:44 PM
epriestley added a subscriber: joshuaspence.May 20 2014, 1:30 PM

◀ Merged tasks: T5123.

joshuaspence added a comment.Jun 10 2014, 6:45 AM

If differential.getrevisioncomments has been deprecated... then shouldn't the arc inlines workflow be deprecated too?

joshuaspence edited this Maniphest Task.Jun 11 2014, 1:31 AM
• ashot added a subscriber: • ashot.Jun 19 2014, 11:30 PM
• ashot added a comment.Jun 19 2014, 11:50 PM

one more vote. would be happy to help make it happen with a bit of guidance.

• ashot added a comment.Jun 24 2014, 5:54 PM

bump!

luizgcribeiro added a subscriber: luizgcribeiro.Jun 27 2014, 12:31 AM
ctl added a subscriber: ctl.Jul 30 2014, 10:28 PM
epriestley closed this task as a duplicate.Aug 22 2014, 8:00 PM

✘ Merged into T5873.

joshuaspence added a commit: rARCf8be9d7737d1: Remove the `inlines` workflow.Dec 30 2014, 11:46 PM
• jaredly added a subscriber: • jaredly.Apr 7 2016, 8:16 PM

As T5873 has been open for a year and a half, and isn't on the immediate roadmap, is there perhaps a way to update getrevisioncomments to expose some more info, so that bots etc can access it?
Would people be open to me making a diff to that end?

chad added a subscriber: chad.Apr 7 2016, 8:23 PM

You're welcome to make a diff and say, share it as a paste, but we're not in the habit of pulling in workarounds, and generally focus on the longterm solution. T5873 literally touches every application in Phabricator, it's more a container task than anything else. We've been rolling these updates out as we're working in adjacent areas.

We don't have a "Convert Differential to EditEngine" task anywhere, but maybe we should since someone may want to prioritize it or attempt to build it.

Phabricator · Built by Phacility