Page MenuHomePhabricator

Use standard rendering and controller for Differential subscriptions
ClosedPublic

Authored by epriestley on Feb 21 2014, 6:07 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Apr 23, 5:37 PM
Unknown Object (File)
Sat, Apr 20, 6:29 PM
Unknown Object (File)
Fri, Apr 19, 5:08 PM
Unknown Object (File)
Mon, Apr 15, 4:43 PM
Unknown Object (File)
Thu, Apr 11, 5:55 PM
Unknown Object (File)
Sun, Apr 7, 8:39 PM
Unknown Object (File)
Sun, Apr 7, 5:34 PM
Unknown Object (File)
Sun, Apr 7, 12:33 AM
Subscribers

Details

Summary

Ref T2222. Differential has custom code for managing subscriptions, but no longer requires it.

The one trick is that we don't have a hook for loading related data on the subscriptions workflow right now. Just glue that in for the moment; it's relatively harmless, and once Diffusion converts we'll have more context on how to best surface it properly.

Test Plan

Subscribed and unsubscribed from a revision. Viewed different revisions and saw correct subscription state.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

does this change where the action ends up in the list? no big deal to me, i would expect a complaint or two though if so.

Yeah, it generally moves somewhere lower in the menu. I'd be surprised if we got too many complaints, but we'll see...