Page MenuHomePhabricator
Differential D8443

Remove DifferentialCommentEditor and DifferentialCommentMail
ClosedPublic
Actions

Authored by epriestley on Mar 7 2014, 8:18 PM.
Tags
None
Referenced Files
F18789091: D8443.id.diff
Wed, Oct 15, 7:55 AM
F18682189: D8443.diff
Fri, Sep 26, 5:21 AM
F18669747: D8443.id.diff
Wed, Sep 24, 9:46 PM
F18664113: D8443.diff
Sep 23 2025, 11:27 PM
F18651571: D8443.id20038.diff
Sep 21 2025, 4:40 AM
F18284081: D8443.diff
Aug 23 2025, 2:35 AM
F18211253: D8443.id20038.diff
Aug 19 2025, 1:54 AM
F18208472: D8443.id.diff
Aug 18 2025, 9:08 PM
View All Files
Subscribers
aran

Details

Reviewers
btrahan
Maniphest Tasks
T2222: Implement ApplicationTransactions in Differential
Commits
Restricted Diffusion Commit
rPf25cce1e695b: Remove DifferentialCommentEditor and DifferentialCommentMail
Summary

Ref T2222. These no longer have any callsites. Also got rid of a little bit of other code which also no longer has callsites.

Test Plan

grep

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

btrahan accepted this revision.Mar 8 2014, 12:26 AM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Mar 8 2014, 12:26 AM
epriestley closed this revision.Mar 8 2014, 1:44 AM

Closed by commit rPf25cce1e695b (authored by @epriestley).

Revision Contents
Changeset List

Diff 20045

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/differential/editor/DifferentialCommentEditor.php

Loading...
View Options

src/applications/differential/editor/DifferentialRevisionEditor.php

Loading...
View Options

src/applications/differential/exception/DifferentialActionHasNoEffectException.php

Loading...
View Options

src/applications/differential/mail/DifferentialCommentMail.php

Loading...
Phabricator · Built by Phacility