Page MenuHomePhabricator

Implement more Differential fields on ApplicationTransaction/CustomField
ClosedPublic

Authored by epriestley on Feb 26 2014, 11:31 PM.
Tags
None
Referenced Files
F18926194: D8357.id19865.diff
Sun, Nov 9, 7:28 PM
F18879231: D8357.id.diff
Thu, Nov 6, 6:20 PM
F18868322: D8357.id.diff
Tue, Nov 4, 5:56 AM
F18808523: D8357.id19869.diff
Oct 19 2025, 6:57 AM
F18789985: D8357.id19865.diff
Oct 15 2025, 12:01 PM
F18763204: D8357.id19868.diff
Oct 6 2025, 11:13 PM
F18762687: D8357.id.diff
Oct 6 2025, 8:11 PM
F18762298: D8357.id.diff
Oct 6 2025, 6:22 PM
Subscribers

Details

Summary

Ref T2222. Ref T3886. Gets the storage-based fields working.

This requires future changes to actually do anything, all this code is inactive.

Test Plan

{F118863}

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

How come the stored fields have a "phabricator" prefix while the non-stored fields have a "differential" prefix?

src/applications/differential/storage/DifferentialRevision.php
76–79

woot woot

src/infrastructure/customfield/field/PhabricatorCustomFieldList.php
202

spacing derp

The prefixes are so that we still access the same migrated data. We could fairly easily re-migrate the data at some point to normalize the prefixes, but it doesn't seem like a big deal to keep it this way.

src/infrastructure/customfield/field/PhabricatorCustomFieldList.php
202

whoops

epriestley updated this revision to Unknown Object (????).Feb 27 2014, 12:53 AM
  • Fix $icon spacing.