Page MenuHomePhabricator

Implement more Differential fields on ApplicationTransaction/CustomField
ClosedPublic

Authored by epriestley on Feb 26 2014, 11:31 PM.
Tags
None
Referenced Files
F15417145: D8357.id.diff
Thu, Mar 20, 3:38 PM
F15412478: D8357.id19868.diff
Wed, Mar 19, 1:11 PM
F15402115: D8357.id.diff
Mon, Mar 17, 8:43 PM
F15401263: D8357.id19869.diff
Mon, Mar 17, 4:37 PM
F15400498: D8357.id19865.diff
Mon, Mar 17, 12:04 PM
F15398962: D8357.diff
Mon, Mar 17, 2:04 AM
F15367746: D8357.id19868.diff
Tue, Mar 11, 8:51 PM
F15336369: D8357.id19868.diff
Sat, Mar 8, 6:45 PM
Subscribers

Details

Summary

Ref T2222. Ref T3886. Gets the storage-based fields working.

This requires future changes to actually do anything, all this code is inactive.

Test Plan

{F118863}

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

How come the stored fields have a "phabricator" prefix while the non-stored fields have a "differential" prefix?

src/applications/differential/storage/DifferentialRevision.php
76–79

woot woot

src/infrastructure/customfield/field/PhabricatorCustomFieldList.php
202

spacing derp

The prefixes are so that we still access the same migrated data. We could fairly easily re-migrate the data at some point to normalize the prefixes, but it doesn't seem like a big deal to keep it this way.

src/infrastructure/customfield/field/PhabricatorCustomFieldList.php
202

whoops

epriestley updated this revision to Unknown Object (????).Feb 27 2014, 12:53 AM
  • Fix $icon spacing.