Page MenuHomePhabricator

Implement more Differential fields on ApplicationTransaction/CustomField
ClosedPublic

Authored by epriestley on Feb 26 2014, 11:31 PM.
Tags
None
Referenced Files
F18459953: D8357.id.diff
Mon, Sep 1, 6:24 PM
F18449271: D8357.diff
Mon, Sep 1, 12:25 AM
F18338906: D8357.id19868.diff
Mon, Aug 25, 9:00 PM
F18230342: D8357.diff
Wed, Aug 20, 12:22 PM
F18107011: D8357.id.diff
Aug 10 2025, 11:36 PM
F18084178: D8357.id19869.diff
Aug 5 2025, 2:06 PM
F17931189: D8357.id.diff
Jul 30 2025, 6:42 PM
F17918921: D8357.diff
Jul 30 2025, 1:48 AM
Subscribers

Details

Summary

Ref T2222. Ref T3886. Gets the storage-based fields working.

This requires future changes to actually do anything, all this code is inactive.

Test Plan

{F118863}

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

How come the stored fields have a "phabricator" prefix while the non-stored fields have a "differential" prefix?

src/applications/differential/storage/DifferentialRevision.php
76–79

woot woot

src/infrastructure/customfield/field/PhabricatorCustomFieldList.php
202

spacing derp

The prefixes are so that we still access the same migrated data. We could fairly easily re-migrate the data at some point to normalize the prefixes, but it doesn't seem like a big deal to keep it this way.

src/infrastructure/customfield/field/PhabricatorCustomFieldList.php
202

whoops

epriestley updated this revision to Unknown Object (????).Feb 27 2014, 12:53 AM
  • Fix $icon spacing.