Page MenuHomePhabricator

Implement more Differential fields on ApplicationTransaction/CustomField
ClosedPublic

Authored by epriestley on Feb 26 2014, 11:31 PM.
Tags
None
Referenced Files
F15577358: D8357.diff
Tue, May 6, 1:36 PM
F15576441: D8357.id19869.diff
Tue, May 6, 9:11 AM
F15576440: D8357.id19868.diff
Tue, May 6, 9:11 AM
F15576438: D8357.id19865.diff
Tue, May 6, 9:11 AM
F15576436: D8357.id.diff
Tue, May 6, 9:11 AM
F15576435: D8357.diff
Tue, May 6, 9:11 AM
F15550542: D8357.id19868.diff
Sun, Apr 27, 12:13 PM
F15550297: D8357.id19868.diff
Sun, Apr 27, 10:56 AM
Subscribers

Details

Summary

Ref T2222. Ref T3886. Gets the storage-based fields working.

This requires future changes to actually do anything, all this code is inactive.

Test Plan

{F118863}

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

How come the stored fields have a "phabricator" prefix while the non-stored fields have a "differential" prefix?

src/applications/differential/storage/DifferentialRevision.php
76–79

woot woot

src/infrastructure/customfield/field/PhabricatorCustomFieldList.php
202

spacing derp

The prefixes are so that we still access the same migrated data. We could fairly easily re-migrate the data at some point to normalize the prefixes, but it doesn't seem like a big deal to keep it this way.

src/infrastructure/customfield/field/PhabricatorCustomFieldList.php
202

whoops

epriestley updated this revision to Unknown Object (????).Feb 27 2014, 12:53 AM
  • Fix $icon spacing.