Page MenuHomePhabricator

avivey (Aviv Eyal)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
Jun 14 2012, 10:46 PM (613 w, 6 h)
Availability
Available

Recent Activity

Apr 1 2023

avivey added a comment to T13688: How do you reasonably plumb a 1/4" drain line into a 1-1/4" drain pipe?.

If the small pipe needs to drain into the big one, how about taking a large pvc end-cap, drilling a 1/4" hold and forcing the smaller pipe in it? Maybe seal the whole thing with some silicone.

Apr 1 2023, 10:14 AM · Hardware

Mar 24 2022

avivey added a comment to T13658: How to rebrand Phabricator.

We came up with a flow in Phorge we think would work well, to progress this task (https://we.phorge.it/E1):

  • We'll have a bunch of diffs, on a per-application basis, along the style established here and in D21712.
  • We'll review each diff on the Phorge
  • When it matures, we'll copy it here for for your review and landing in Phabricator.
Mar 24 2022, 5:56 PM

Sep 28 2021

avivey added a comment to T13588: PHP 8 Compatibility.

From https://discourse.phabricator-community.org/t/sending-emails-causes-an-exception/4966, looks like the PHPMailer uses each which is removed in php 8.

Sep 28 2021, 7:57 AM · Infrastructure
avivey added a comment to T12404: Implement a first-party SMTP client.

From https://discourse.phabricator-community.org/t/sending-emails-causes-an-exception/4966, it appears that both class.smtp.php and class.phpmailer-lite.php have calls to each which is removed in PHP 8.

Sep 28 2021, 7:55 AM · Infrastructure, Mail

Jun 2 2021

avivey updated subscribers of 2021 Week 22 (End of Active Maintenance).

Thank you @epriestley (and @btrahan, @chad, and others) for the great work done here!

Jun 2 2021, 3:48 AM

Jun 1 2021

bbrdaric awarded Changelog a Heartbreak token.
Jun 1 2021, 8:41 AM

May 30 2021

avivey awarded T13654: Wind Down Phacility Operations a Heartbreak token.
May 30 2021, 1:00 PM · Phacility

Apr 1 2021

avivey updated the diff for D21660: arc-unit: only list failing tests.

tweak wording

Apr 1 2021, 7:50 PM
avivey requested review of D21660: arc-unit: only list failing tests.
Apr 1 2021, 7:48 PM
avivey added a revision to T8856: Show a summary of failed unit tests at the end of `arc unit` or `arc diff` if there are failures: D21660: arc-unit: only list failing tests.
Apr 1 2021, 7:48 PM · Restricted Project, Arcanist
avivey edited the content of Community Resources.
Apr 1 2021, 6:19 PM

Oct 30 2020

avivey published D21485: Packages: Load'em from .cache for review.
Oct 30 2020, 4:54 PM
avivey added a revision to T5055: Distribution mechanism for arc extensions: D21485: Packages: Load'em from .cache.
Oct 30 2020, 4:50 PM · Arcanist

Aug 22 2020

avivey added a comment to T5055: Distribution mechanism for arc extensions.

The public key won't necessarily be available to Phabricator (because it's kinda funny to have the public key and signature in the same place). We'll just register the fingerprints I guess?

I think the public key has to be available -- you can't verify signatures otherwise.

Aug 22 2020, 6:28 AM · Arcanist

Aug 21 2020

avivey added a comment to T5055: Distribution mechanism for arc extensions.

I think I'm going to start working on the Arcanist side of this soon...

Aug 21 2020, 12:15 PM · Arcanist

Aug 20 2020

avivey added a comment to T13575: PHP built-in webserver fails on POST.

Yeah, it might make sense to drop it; I use it because it's easier to setup then Apache and the error log is right in my console, but setting up a real server isn't that much of a bother, except for Apple changing the rugs on you every other day (Soon with both x86 and ARM versions!)

Aug 20 2020, 7:39 PM · Infrastructure
avivey created T13575: PHP built-in webserver fails on POST.
Aug 20 2020, 5:43 PM · Infrastructure

Jul 25 2020

avivey added a comment to T13550: Strip markup from project descriptions displayed in the "Browse Projects" dialog.

related to T3278, probably?

Jul 25 2020, 10:57 AM · Typeahead, Feature Request

Jun 15 2020

avivey committed rPd203a1004c75: Update tab completion doc (authored by avivey).
Update tab completion doc
Jun 15 2020, 1:27 PM
avivey closed D21359: Update tab completion doc.
Jun 15 2020, 1:27 PM
avivey requested review of D21359: Update tab completion doc.
Jun 15 2020, 7:52 AM

Jun 7 2020

avivey edited P1998 git-files-commits-table.py.
Jun 7 2020, 7:40 AM

May 23 2020

avivey awarded Blog Post: Quick Look: Suggesting Edits with Inline Comments a Manufacturing Defect? token.
May 23 2020, 6:19 AM · Differential, Quick Look

May 15 2020

avivey committed rARC2d8156a72767: update SSL error messge re:libphutil (authored by avivey).
update SSL error messge re:libphutil
May 15 2020, 12:15 PM
avivey closed D21258: update SSL error messge re:libphutil.
May 15 2020, 12:15 PM
avivey added a comment to D21258: update SSL error messge re:libphutil.

I left other references because it looks like we still talk about "libphutil libraries" a lot.

May 15 2020, 8:51 AM
avivey requested review of D21258: update SSL error messge re:libphutil.
May 15 2020, 8:50 AM

Apr 30 2020

avivey updated the task description for T10038: Plan the mid-term pathway for unit-test/linter bindings.
Apr 30 2020, 8:16 AM · Lint, Arcanist

Apr 24 2020

avivey added a comment to D21141: Make the "Keyboard Shortcuts" dialog in Differential less hideous.

Looking at it now, it looks very nice, but there should probably be a way to navigate the groups by keyboard?

Apr 24 2020, 8:19 AM

Apr 1 2020

avivey updated the task description for T10038: Plan the mid-term pathway for unit-test/linter bindings.
Apr 1 2020, 1:50 PM · Lint, Arcanist

Mar 20 2020

avivey edited the content of Community Resources.
Mar 20 2020, 3:12 PM

Feb 13 2020

avivey awarded T13488: Upgrading: Early 2020 Changes to Arcanist a Party Time token.
Feb 13 2020, 2:11 PM · Arcanist, Installing & Upgrading

Nov 7 2019

avivey edited the content of Community Resources.
Nov 7 2019, 7:24 PM

Sep 8 2019

avivey committed rP318e8ebdac95: Allow bin/config to create config file (authored by avivey).
Allow bin/config to create config file
Sep 8 2019, 12:16 AM
avivey closed D20788: Allow bin/config to create config file.
Sep 8 2019, 12:16 AM

Sep 7 2019

avivey added a comment to D20788: Allow bin/config to create config file.

assertWritable checks that the file exists and writable. There's assertWritableFile, but it's private, and it's being called anyway from setKeys.
This might be hiding some other strange conditions, but I couldn't think of any that don't end up just making the file un-writeable.

Sep 7 2019, 7:20 PM
avivey requested review of D20788: Allow bin/config to create config file.
Sep 7 2019, 7:19 PM

Aug 27 2019

avivey added a comment to T13388: Non-ideal view in mobile when using browser's "desktop" mode.

I'm guessing it's a media-query being calculated on some metric that isn't being scaled by the browser - "inches" maybe?

Aug 27 2019, 1:34 AM
avivey created T13388: Non-ideal view in mobile when using browser's "desktop" mode.
Aug 27 2019, 1:31 AM

Aug 15 2019

avivey awarded T13376: Write about "add more logging / monitoring / tests" a Manufacturing Defect? token.
Aug 15 2019, 5:26 PM · Guides

Aug 13 2019

jcox awarded Changelog a Love token.
Aug 13 2019, 4:30 PM

Aug 9 2019

avivey awarded T13369: When a large number of commits are pushed to a repository, import them at lower priority a Piece of Eight token.
Aug 9 2019, 6:46 PM · Daemons, Diffusion

Aug 4 2019

avivey added a comment to T13358: Generate PDFs for Phortune invoices.

I've worked with wkhtmltopdf several times, and I don't remember it actually requiring any special setup - in all cases, I basically dropped the binary in the machine (Although it's possible all my machines had X11 built in for some reason? I've never intentionally installed X11).

Aug 4 2019, 7:02 PM · Phortune, Phacility

May 24 2019

avivey awarded D20556: If "vi" or "vim" exit with an error code, test for error-on-interactive-mistake behavior a Baby Tequila token.
May 24 2019, 9:04 PM
avivey added a comment to T13297: "vi" and "vim" may exit with errors even though edits succeed.

Running the thing on my ubuntu exists with 0...

$ vi --version
VIM - Vi IMproved 8.0 (2016 Sep 12, compiled Apr 10 2018 21:31:58)
Included patches: 1-1453
.....
.....
Compilation: gcc -c -I. -Iproto -DHAVE_CONFIG_H   -Wdate-time  -g -O2 -fdebug-prefix-map=/build/vim-NQEcoP/vim-8.0.1453=. -fstack-protector-strong -Wformat -Werror=format-security -DTINY_VIMRC -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=1
Linking: gcc   -Wl,-Bsymbolic-functions -Wl,-z,relro -Wl,-z,now -Wl,--as-needed -o vim    -lSM -lICE -lXpm -lXt -lX11 -lXdmcp -lSM -lICE  -lm -ltinfo  -lselinux -lacl -lattr -ldl
May 24 2019, 9:04 PM · Arcanist

May 7 2019

avivey accepted D20499: Fix a HunkParser typo, "identcal" -> "identical".

This is a change I can stand behind. Looks good!

May 7 2019, 5:02 PM

Apr 25 2019

avivey added a comment to T9530: Release Server / Workflow app / Future of Releeph .

To those still interested, Spinnaker (OSS from Netflix + Google) is targeting the Deployment part of this flow (everything after a Release Candidate is created).
It only handled "cloud" deployments, and offers as much complexity as you can ever want, including "Wait for human approval", Canary deployments, blue-green, etc.

Apr 25 2019, 4:41 PM · Restricted Project, Harbormaster

Apr 19 2019

avivey added a comment to T6722: Support "Create similar repository..." in Diffusion.

I think a more powerful approach is to support some kind of "templates", so that we can create a new "Android App" repo or "COM Module" repo directly, similar to how IDEs have project templates.

Apr 19 2019, 7:44 PM · Diffusion (v3), Restricted Project
remusvrm awarded Changelog a Like token.
Apr 19 2019, 7:09 PM

Apr 16 2019

avivey added inline comments to D20430: Update documentation for "uri.allowed-protocols".
Apr 16 2019, 5:49 PM

Apr 15 2019

avivey accepted D20431: Show a warning when "git" is too old to support filesize limits.
Apr 15 2019, 7:43 PM
avivey accepted D20430: Update documentation for "uri.allowed-protocols".
Apr 15 2019, 7:43 PM

Mar 25 2019

avivey created T13270: Diffusion [Code] button always goes to root of repo.
Mar 25 2019, 8:49 PM · Diffusion

Mar 24 2019

avivey accepted D20317: Fix transaction queries failing on "withIDs()" after clicking "Show Older".
Mar 24 2019, 6:45 PM

Mar 19 2019

avivey added a comment to T13264: Maybe stack multiple breadcrumb sequences?.

We should log all the paths used to get to each page, and then show all of them in a big combo box, and when you select one, update your browser's history to match that path!

Mar 19 2019, 10:02 PM · Design

Feb 18 2019

avivey retitled D20194: Display some invisible/nonprintable characters in diffs by default from Display some invisible/nonprintable characters by in diffs by default to Display some invisible/nonprintable characters in diffs by default.
Feb 18 2019, 12:08 AM

Feb 2 2019

avivey awarded T13245: Improve MFA security by using replacing SMS code digits with emoji a Party Time token.
Feb 2 2019, 9:11 PM · Security

Jan 29 2019

avivey added a comment to T9044: arc diff eagerly detects git-svn repo, which makes arc-patch hang.

In https://discourse.phabricator-community.org/t/2334, thopre suggests checking for git config --get-regexp svn-remote to see if the repository is configured as git-svn repo, as an alternative to check if .git/svn/.metadata exists.

Jan 29 2019, 6:05 PM · Restricted Project, Arcanist

Jan 28 2019

avivey added a comment to T13224: Pygments Bash lexer has explosive complexity on unterminated strings with many backslashes.

D212: Fix daemon issues caused by Ubuntu's surprising intermediary shell?

Jan 28 2019, 11:24 PM · Infrastructure

Jan 19 2019

avivey created T13239: null pointer exception in PhabricatorPeopleWelcomeController.
Jan 19 2019, 11:31 PM
avivey added inline comments to D19995: Use the customizable "Welcome Mail" message in welcome mail.
Jan 19 2019, 11:29 PM
avivey added a comment to D19988: Add "Contact Numbers" so we can send users SMS mesages.

I have some war stories about normalizing phone numbers... IIRC, the worst offender is Brazil (numbers may vary in length).

Jan 19 2019, 12:49 AM

Jan 17 2019

avivey changed the visibility for T1394: Support creating audits with inline comments through the API.
Jan 17 2019, 7:17 PM · Conduit, Harbormaster, Audit

Jan 9 2019

avivey awarded T13229: On Third-Party Integrations a Yellow Medal token.
Jan 9 2019, 10:29 AM · Phacility

Dec 31 2018

avivey added a comment to T13231: Duo MFA Support.

I expect Google to expose a similar solution to Duo soonish (if you use Android and try to login to Google, MFA is just like Duo now).

Dec 31 2018, 6:29 AM · Auth
avivey added a comment to T13230: Native Applications.

Some of these things are supposed to be implemented in a reasonable way via browsers "eventually" (offline push notifications have a bunch of attempts, Screenshots use case has some solutions that sometimes work, and there's rumor about MFA and NFC floating around.)

Dec 31 2018, 6:24 AM · Phacility
avivey renamed T13230: Native Applications from Native Mobile Applications to Native Applications.
Dec 31 2018, 6:10 AM · Phacility
avivey renamed T13230: Native Applications from Native Applications to Native Mobile Applications.
Dec 31 2018, 6:07 AM · Phacility

Dec 21 2018

avivey added a comment to T13227: Figure out if Google Auth needs to be updated before Google+ shutdown on March 7, 2019.

Since the google-api is also disabled by default in Google Cloud env, I had to make changes to some other oauth provider at https://gitlab.com/SirEdvin/sanic-oauth/commit/fae23f6b35517dd9e8bec328dbb4dc883e033d78.
There, the g+ api was only used to get the user's email, iirc, and an alternative exists in https://www.googleapis.com/userinfo/v2/me.

Dec 21 2018, 1:51 AM · Auth

Dec 13 2018

avivey awarded D19877: Move user approval to modular transactions a Like token.
Dec 13 2018, 12:39 AM

Nov 15 2018

avivey accepted D19808: Fix flickering tooltips in Chrome when the tip container overlaps the triggering element.
Nov 15 2018, 5:40 PM

Nov 10 2018

avivey added a comment to E1209: Pull that into png.

The alert poped up just now (5pm, end-of-day), but this was a whole-day event! We missed the whole thing!

Nov 10 2018, 12:59 AM

Nov 9 2018

avivey committed rARC3534d2baca4b: Small ReMarkup fix (authored by avivey).
Small ReMarkup fix
Nov 9 2018, 4:25 AM
avivey closed D19794: Small ReMarkup fix.
Nov 9 2018, 4:25 AM

Nov 8 2018

avivey awarded T13217: Upgrading: Hardening of qsprintf() a Like token.
Nov 8 2018, 10:11 PM · Installing & Upgrading, Infrastructure, Security, Guides
avivey added a comment to D19794: Small ReMarkup fix.

sadpanda
https://secure.phabricator.com/drydock/lease/12656/

Nov 8 2018, 5:12 AM
avivey added reviewers for D19794: Small ReMarkup fix: epriestley, amckinley.
Nov 8 2018, 3:38 AM
avivey updated the diff for D19794: Small ReMarkup fix.

this one

Nov 8 2018, 3:35 AM
avivey requested review of D19794: Small ReMarkup fix.
Nov 8 2018, 3:34 AM

Nov 2 2018

avivey accepted D19770: Correct an ambiguous regexp in DiffusionRequest.
Nov 2 2018, 3:00 AM

Oct 15 2018

avivey added a comment to D19639: Make the Arcanist comment remover less aggressive about stripping instructional comments.

https://discourse.phabricator-community.org/t/latest-arcanist-incorrecly-parses-comments/2013 reports an issue with this new behavior - probably if the Subscribers is left empty, the parser takes the first line of the comment.

Oct 15 2018, 10:58 PM

Oct 7 2018

avivey added a comment to T8440: Tooltip flicker at certain cursor positions.

https://discourse.phabricator-community.org/t/differential-ui-tooltip-flicks-on-hover/1970 has some css witchcraft to make this not happen.

Oct 7 2018, 9:42 PM · PHUI

Sep 6 2018

avivey changed the visibility for T3130: Improve recognition of symbols in Java.
Sep 6 2018, 5:34 PM · Symbols, libphutil

Sep 3 2018

avivey added a comment to D19629: Link to PHP external symbols using HTTPS.

Almost all of us:

image.png (553×686 px, 25 KB)

Sep 3 2018, 6:40 PM

Aug 9 2018

avivey added a comment to T13178: Plans: Support Pact Competitive Update.

A related score-board might be to show mana-rich tasks.

Aug 9 2018, 3:17 AM · Plans, Support, Phacility

Aug 3 2018

avivey merged T13181: Phacility: email address already in use - blocks user into T13156: Plans: Improve Phacility UI for managing instance managers and cards.
Aug 3 2018, 10:39 PM · Plans, Phacility
avivey merged task T13181: Phacility: email address already in use - blocks user into T13156: Plans: Improve Phacility UI for managing instance managers and cards.
Aug 3 2018, 10:39 PM
avivey created T13181: Phacility: email address already in use - blocks user.
Aug 3 2018, 9:21 PM

Jul 31 2018

avivey awarded T13178: Plans: Support Pact Competitive Update a Party Time token.
Jul 31 2018, 4:27 PM · Plans, Support, Phacility

Jul 27 2018

avivey added a comment to T9456: Evaluate upstream support for third-party build systems.

Looks like CircleCI will stop supporting the V1 API, which we use, in about 5 weeks: https://circleci.com/sunset1-0/

Jul 27 2018, 6:53 PM · Restricted Project, Harbormaster

Jul 19 2018

avivey created T13170: Conduit "maniphest.search" method call allows ordering by "project" column on arbitrary queries, but this internal column is only meaningful when "Group By" is "Project".
Jul 19 2018, 7:49 PM · Conduit

Jul 9 2018

avivey committed rARC875d01836037: Fix `arc diff` when adding large new file with new git (authored by avivey).
Fix `arc diff` when adding large new file with new git
Jul 9 2018, 5:59 PM
avivey closed D19513: Fix `arc diff` when adding large new file with new git.
Jul 9 2018, 5:59 PM

Jul 8 2018

avivey requested review of D19513: Fix `arc diff` when adding large new file with new git.
Jul 8 2018, 11:39 PM

Jun 27 2018

avivey added a comment to Q268: There is a way to "personlize" arcanist default template? (Answer 304).

I think the label Maniphest Tasks is no longer rendered, because the tasks are being parsed from the message body ("fixes Txxx").

Jun 27 2018, 4:12 AM

Jun 23 2018

avivey added a comment to T13158: View query results as annotatable "spreadsheets".

This sounds similar to "Customize Fields Shown In List View", except that it allows per-view customization (And a DSL for "view" instead of property on the Field, as in T418).

Jun 23 2018, 4:26 PM · Design

Jun 21 2018

avivey accepted D19500: Fix changeset construction special case for empty commits in pre-commit hooks.
Jun 21 2018, 11:24 PM
avivey added a comment to T13157: Provide more advanced tools for developing against Phabricator and discovering PHIDs.

I have P2080 and P2081 for this :)

Jun 21 2018, 7:47 PM · Infrastructure
avivey changed the visibility for P1993 GetDependenciesWorkflow.php.
Jun 21 2018, 7:46 PM
avivey awarded T13157: Provide more advanced tools for developing against Phabricator and discovering PHIDs a Love token.
Jun 21 2018, 7:45 PM · Infrastructure