Page MenuHomePhabricator

avivey (Aviv Eyal)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Monday

  • Clear sailing ahead.

User Details

User Since
Jun 14 2012, 10:46 PM (751 w, 1 d)
Availability
Available

Recent Activity

Thu, Oct 22

avivey added a comment to T13704: PHP2Shell.

also maybe copy https://we.phorge.it/D25387, which makes it so deprecation
messages don't kill the server.

Thu, Oct 22, 7:04 PM · Security, Phacility
avivey added a comment to T13704: PHP2Shell.

Hi Evan,

Thu, Oct 22, 6:52 PM · Security, Phacility

Apr 1 2023

avivey added a comment to T13688: How do you reasonably plumb a 1/4" drain line into a 1-1/4" drain pipe?.

If the small pipe needs to drain into the big one, how about taking a large pvc end-cap, drilling a 1/4" hold and forcing the smaller pipe in it? Maybe seal the whole thing with some silicone.

Apr 1 2023, 10:14 AM · Hardware

Mar 24 2022

avivey added a comment to T13658: How to rebrand Phabricator.

We came up with a flow in Phorge we think would work well, to progress this task (https://we.phorge.it/E1):

  • We'll have a bunch of diffs, on a per-application basis, along the style established here and in D21712.
  • We'll review each diff on the Phorge
  • When it matures, we'll copy it here for for your review and landing in Phabricator.
Mar 24 2022, 5:56 PM

Sep 28 2021

avivey added a comment to T13588: PHP 8 Compatibility.

From https://discourse.phabricator-community.org/t/sending-emails-causes-an-exception/4966, looks like the PHPMailer uses each which is removed in php 8.

Sep 28 2021, 7:57 AM · Infrastructure
avivey added a comment to T12404: Implement a first-party SMTP client.

From https://discourse.phabricator-community.org/t/sending-emails-causes-an-exception/4966, it appears that both class.smtp.php and class.phpmailer-lite.php have calls to each which is removed in PHP 8.

Sep 28 2021, 7:55 AM · Infrastructure, Mail

Jun 2 2021

avivey updated subscribers of 2021 Week 22 (End of Active Maintenance).

Thank you @epriestley (and @btrahan, @chad, and others) for the great work done here!

Jun 2 2021, 3:48 AM

Jun 1 2021

bbrdaric awarded Changelog a Heartbreak token.
Jun 1 2021, 8:41 AM

May 30 2021

avivey awarded T13654: Wind Down Phacility Operations a Heartbreak token.
May 30 2021, 1:00 PM · Phacility

Apr 1 2021

avivey added a revision to T8856: Show a summary of failed unit tests at the end of `arc unit` or `arc diff` if there are failures: Unknown Object (Differential Revision).
Apr 1 2021, 7:48 PM · Restricted Project, Arcanist
avivey edited the content of Community Resources.
Apr 1 2021, 6:19 PM

Oct 30 2020

avivey added a revision to T5055: Distribution mechanism for arc extensions: Unknown Object (Differential Revision).
Oct 30 2020, 4:50 PM · Arcanist

Aug 22 2020

avivey added a comment to T5055: Distribution mechanism for arc extensions.

The public key won't necessarily be available to Phabricator (because it's kinda funny to have the public key and signature in the same place). We'll just register the fingerprints I guess?

I think the public key has to be available -- you can't verify signatures otherwise.

Aug 22 2020, 6:28 AM · Arcanist

Aug 21 2020

avivey added a comment to T5055: Distribution mechanism for arc extensions.

I think I'm going to start working on the Arcanist side of this soon...

Aug 21 2020, 12:15 PM · Arcanist

Aug 20 2020

avivey added a comment to T13575: PHP built-in webserver fails on POST.

Yeah, it might make sense to drop it; I use it because it's easier to setup then Apache and the error log is right in my console, but setting up a real server isn't that much of a bother, except for Apple changing the rugs on you every other day (Soon with both x86 and ARM versions!)

Aug 20 2020, 7:39 PM · Infrastructure
avivey created T13575: PHP built-in webserver fails on POST.
Aug 20 2020, 5:43 PM · Infrastructure

Jul 25 2020

avivey added a comment to T13550: Strip markup from project descriptions displayed in the "Browse Projects" dialog.

related to T3278, probably?

Jul 25 2020, 10:57 AM · Typeahead, Feature Request

Jun 7 2020

avivey edited P1998 git-files-commits-table.py.
Jun 7 2020, 7:40 AM

May 23 2020

avivey awarded Blog Post: Quick Look: Suggesting Edits with Inline Comments a Manufacturing Defect? token.
May 23 2020, 6:19 AM · Differential, Quick Look

Apr 30 2020

avivey updated the task description for T10038: Plan the mid-term pathway for unit-test/linter bindings.
Apr 30 2020, 8:16 AM · Lint, Arcanist

Apr 1 2020

avivey updated the task description for T10038: Plan the mid-term pathway for unit-test/linter bindings.
Apr 1 2020, 1:50 PM · Lint, Arcanist

Mar 20 2020

avivey edited the content of Community Resources.
Mar 20 2020, 3:12 PM

Feb 13 2020

avivey awarded T13488: Upgrading: Early 2020 Changes to Arcanist a Party Time token.
Feb 13 2020, 2:11 PM · Arcanist, Installing & Upgrading

Nov 7 2019

avivey edited the content of Community Resources.
Nov 7 2019, 7:24 PM

Aug 27 2019

avivey added a comment to T13388: Non-ideal view in mobile when using browser's "desktop" mode.

I'm guessing it's a media-query being calculated on some metric that isn't being scaled by the browser - "inches" maybe?

Aug 27 2019, 1:34 AM
avivey created T13388: Non-ideal view in mobile when using browser's "desktop" mode.
Aug 27 2019, 1:31 AM

Aug 15 2019

avivey awarded T13376: Write about "add more logging / monitoring / tests" a Manufacturing Defect? token.
Aug 15 2019, 5:26 PM · Guides

Aug 13 2019

jcox awarded Changelog a Love token.
Aug 13 2019, 4:30 PM

Aug 9 2019

avivey awarded T13369: When a large number of commits are pushed to a repository, import them at lower priority a Piece of Eight token.
Aug 9 2019, 6:46 PM · Daemons, Diffusion

Aug 4 2019

avivey added a comment to T13358: Generate PDFs for Phortune invoices.

I've worked with wkhtmltopdf several times, and I don't remember it actually requiring any special setup - in all cases, I basically dropped the binary in the machine (Although it's possible all my machines had X11 built in for some reason? I've never intentionally installed X11).

Aug 4 2019, 7:02 PM · Phortune, Phacility

May 24 2019

avivey added a comment to T13297: "vi" and "vim" may exit with errors even though edits succeed.

Running the thing on my ubuntu exists with 0...

$ vi --version
VIM - Vi IMproved 8.0 (2016 Sep 12, compiled Apr 10 2018 21:31:58)
Included patches: 1-1453
.....
.....
Compilation: gcc -c -I. -Iproto -DHAVE_CONFIG_H   -Wdate-time  -g -O2 -fdebug-prefix-map=/build/vim-NQEcoP/vim-8.0.1453=. -fstack-protector-strong -Wformat -Werror=format-security -DTINY_VIMRC -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=1
Linking: gcc   -Wl,-Bsymbolic-functions -Wl,-z,relro -Wl,-z,now -Wl,--as-needed -o vim    -lSM -lICE -lXpm -lXt -lX11 -lXdmcp -lSM -lICE  -lm -ltinfo  -lselinux -lacl -lattr -ldl
May 24 2019, 9:04 PM · Arcanist

Apr 25 2019

avivey added a comment to T9530: Release Server / Workflow app / Future of Releeph .

To those still interested, Spinnaker (OSS from Netflix + Google) is targeting the Deployment part of this flow (everything after a Release Candidate is created).
It only handled "cloud" deployments, and offers as much complexity as you can ever want, including "Wait for human approval", Canary deployments, blue-green, etc.

Apr 25 2019, 4:41 PM · Restricted Project, Harbormaster

Apr 19 2019

avivey added a comment to T6722: Support "Create similar repository..." in Diffusion.

I think a more powerful approach is to support some kind of "templates", so that we can create a new "Android App" repo or "COM Module" repo directly, similar to how IDEs have project templates.

Apr 19 2019, 7:44 PM · Diffusion (v3), Restricted Project
remusvrm awarded Changelog a Like token.
Apr 19 2019, 7:09 PM

Mar 25 2019

avivey created T13270: Diffusion [Code] button always goes to root of repo.
Mar 25 2019, 8:49 PM · Diffusion

Mar 19 2019

avivey added a comment to T13264: Maybe stack multiple breadcrumb sequences?.

We should log all the paths used to get to each page, and then show all of them in a big combo box, and when you select one, update your browser's history to match that path!

Mar 19 2019, 10:02 PM · Design

Feb 2 2019

avivey awarded T13245: Improve MFA security by using replacing SMS code digits with emoji a Party Time token.
Feb 2 2019, 9:11 PM · Security

Jan 29 2019

avivey added a comment to T9044: arc diff eagerly detects git-svn repo, which makes arc-patch hang.

In https://discourse.phabricator-community.org/t/2334, thopre suggests checking for git config --get-regexp svn-remote to see if the repository is configured as git-svn repo, as an alternative to check if .git/svn/.metadata exists.

Jan 29 2019, 6:05 PM · Restricted Project, Arcanist

Jan 28 2019

avivey added a comment to T13224: Pygments Bash lexer has explosive complexity on unterminated strings with many backslashes.

D212: Fix daemon issues caused by Ubuntu's surprising intermediary shell?

Jan 28 2019, 11:24 PM · Infrastructure

Jan 19 2019

avivey created T13239: null pointer exception in PhabricatorPeopleWelcomeController.
Jan 19 2019, 11:31 PM

Jan 17 2019

avivey changed the visibility for T1394: Support creating audits with inline comments through the API.
Jan 17 2019, 7:17 PM · Conduit, Harbormaster, Audit

Jan 9 2019

avivey awarded T13229: On Third-Party Integrations a Yellow Medal token.
Jan 9 2019, 10:29 AM · Phacility

Dec 31 2018

avivey added a comment to T13231: Duo MFA Support.

I expect Google to expose a similar solution to Duo soonish (if you use Android and try to login to Google, MFA is just like Duo now).

Dec 31 2018, 6:29 AM · Auth
avivey added a comment to T13230: Native Applications.

Some of these things are supposed to be implemented in a reasonable way via browsers "eventually" (offline push notifications have a bunch of attempts, Screenshots use case has some solutions that sometimes work, and there's rumor about MFA and NFC floating around.)

Dec 31 2018, 6:24 AM · Phacility
avivey renamed T13230: Native Applications from Native Mobile Applications to Native Applications.
Dec 31 2018, 6:10 AM · Phacility
avivey renamed T13230: Native Applications from Native Applications to Native Mobile Applications.
Dec 31 2018, 6:07 AM · Phacility

Dec 21 2018

avivey added a comment to T13227: Figure out if Google Auth needs to be updated before Google+ shutdown on March 7, 2019.

Since the google-api is also disabled by default in Google Cloud env, I had to make changes to some other oauth provider at https://gitlab.com/SirEdvin/sanic-oauth/commit/fae23f6b35517dd9e8bec328dbb4dc883e033d78.
There, the g+ api was only used to get the user's email, iirc, and an alternative exists in https://www.googleapis.com/userinfo/v2/me.

Dec 21 2018, 1:51 AM · Auth

Nov 10 2018

avivey added a comment to E1209: Pull that into png.

The alert poped up just now (5pm, end-of-day), but this was a whole-day event! We missed the whole thing!

Nov 10 2018, 12:59 AM

Nov 8 2018

avivey awarded T13217: Upgrading: Hardening of qsprintf() a Like token.
Nov 8 2018, 10:11 PM · Installing & Upgrading, Infrastructure, Security, Guides

Oct 7 2018

avivey added a comment to T8440: Tooltip flicker at certain cursor positions.

https://discourse.phabricator-community.org/t/differential-ui-tooltip-flicks-on-hover/1970 has some css witchcraft to make this not happen.

Oct 7 2018, 9:42 PM · PHUI

Sep 6 2018

avivey changed the visibility for T3130: Improve recognition of symbols in Java.
Sep 6 2018, 5:34 PM · Symbols, libphutil

Aug 9 2018

avivey added a comment to T13178: Plans: Support Pact Competitive Update.

A related score-board might be to show mana-rich tasks.

Aug 9 2018, 3:17 AM · Plans, Support, Phacility

Aug 3 2018

avivey merged T13181: Phacility: email address already in use - blocks user into T13156: Plans: Improve Phacility UI for managing instance managers and cards.
Aug 3 2018, 10:39 PM · Plans, Phacility
avivey merged task T13181: Phacility: email address already in use - blocks user into T13156: Plans: Improve Phacility UI for managing instance managers and cards.
Aug 3 2018, 10:39 PM
avivey created T13181: Phacility: email address already in use - blocks user.
Aug 3 2018, 9:21 PM

Jul 31 2018

avivey awarded T13178: Plans: Support Pact Competitive Update a Party Time token.
Jul 31 2018, 4:27 PM · Plans, Support, Phacility

Jul 27 2018

avivey added a comment to T9456: Evaluate upstream support for third-party build systems.

Looks like CircleCI will stop supporting the V1 API, which we use, in about 5 weeks: https://circleci.com/sunset1-0/

Jul 27 2018, 6:53 PM · Restricted Project, Harbormaster

Jul 19 2018

avivey created T13170: Conduit "maniphest.search" method call allows ordering by "project" column on arbitrary queries, but this internal column is only meaningful when "Group By" is "Project".
Jul 19 2018, 7:49 PM · Conduit

Jun 27 2018

avivey added a comment to Q268: There is a way to "personlize" arcanist default template? (Answer 304).

I think the label Maniphest Tasks is no longer rendered, because the tasks are being parsed from the message body ("fixes Txxx").

Jun 27 2018, 4:12 AM

Jun 23 2018

avivey added a comment to T13158: View query results as annotatable "spreadsheets".

This sounds similar to "Customize Fields Shown In List View", except that it allows per-view customization (And a DSL for "view" instead of property on the Field, as in T418).

Jun 23 2018, 4:26 PM · Design

Jun 21 2018

avivey added a comment to T13157: Provide more advanced tools for developing against Phabricator and discovering PHIDs.

I have P2080 and P2081 for this :)

Jun 21 2018, 7:47 PM · Infrastructure
avivey changed the visibility for P1993 GetDependenciesWorkflow.php.
Jun 21 2018, 7:46 PM
avivey awarded T13157: Provide more advanced tools for developing against Phabricator and discovering PHIDs a Love token.
Jun 21 2018, 7:45 PM · Infrastructure
avivey created T13155: Empty commit causes diffusion error output (but doesn't fail).
Jun 21 2018, 4:27 AM · Diffusion

Jun 4 2018

avivey added a comment to Q645: Aphlict start causes exception, seemingly when its log file location is changed (Answer 567).

Also, Support has basically moved to Discourse now.

Jun 4 2018, 6:25 AM
avivey added Q645: Aphlict start causes exception, seemingly when its log file location is changed (Answer 567).
Jun 4 2018, 6:24 AM

Jun 2 2018

avivey added a comment to T418: Integrate CustomField into more interfaces.

From https://discourse.phabricator-community.org/t/how-to-get-custom-field-of-transactiontype/1532 (and my followup research), there doesn't appear to be a way to extract custom field information using conduit (or Herald Web Hooks).
transaction.search actually lists type as null and no fields.

Jun 2 2018, 6:12 PM · Restricted Project, Restricted Project, Restricted Project, Maniphest, Custom Fields

May 31 2018

avivey changed the visibility for T3071: add support for OpenSearch to phabricator.
May 31 2018, 11:49 PM
avivey added a comment to T12963: Aggregate similar stories in Feed, Notifications and Timelines.

See also long chatter in https://discourse.phabricator-community.org/t/request-less-obtrusive-status-updates/1530.

May 31 2018, 5:19 PM · Transactions

May 24 2018

avivey triaged T13148: css: ginormous images go over preview panel in Files as Low priority.
May 24 2018, 10:00 PM · Files
avivey renamed T13147: tab freeze when hitting backspace in empty tokenizer from tab freeze when hitting backspace in empty picker to tab freeze when hitting backspace in empty tokenizer.
May 24 2018, 9:51 PM · Typeahead
avivey created T13147: tab freeze when hitting backspace in empty tokenizer.
May 24 2018, 6:55 PM · Typeahead

May 22 2018

avivey added a comment to T8093: Evaluate virtualizing Git refs by proxying the protocol.

Very soon now, git is getting an exciting new wire protocol. Highlights are improving performance on repos with unholy amount of refs, and being "easier to expand".

May 22 2018, 11:37 PM · Restricted Project, Harbormaster

May 15 2018

avivey created T13139: Custom linters have no easy way to get line+char from char-offset in file.
May 15 2018, 6:08 PM · Lint

May 2 2018

avivey edited the content of 2018 Week 17 (Very Late April).
May 2 2018, 2:53 AM

Apr 30 2018

avivey updated the task description for T13132: `arc download` broken for non-CDN Phabricator .
Apr 30 2018, 6:10 AM · Conduit, Files
avivey created T13132: `arc download` broken for non-CDN Phabricator .
Apr 30 2018, 6:10 AM · Conduit, Files

Apr 22 2018

avivey added a comment to T13130: Plans: 2018 Week 17/18 Bonus Content.

See PHI251. This requests an "Ignore generated changes." option for Owners.

Historically, an issue with this was my hesitance to add more "Add Owner As Reviewer If Moon is Full" builtin rules to Owners: Herald already allows you to implement arbitrary rules with Owners, and an implementation of Herald where every possible rule is a dropdown option obviously isn't very good.

Apr 22 2018, 6:40 PM · Plans

Apr 21 2018

avivey added a revision to T4200: Building OS packages and install scripts: Unknown Object (Differential Revision).
Apr 21 2018, 4:49 AM · Guides, Setup

Apr 20 2018

avivey added a comment to T4200: Building OS packages and install scripts.

install_ubuntu.sh seems to be completely broken for modern Ubuntu. I don't mind updating it, but I think we discussed dumping it completely?

Apr 20 2018, 1:37 AM · Guides, Setup

Apr 18 2018

avivey added a revision to T5936: Support terminating builds, terminating remote processes and build steps: Unknown Object (Differential Revision).
Apr 18 2018, 2:21 AM · Restricted Project, Harbormaster
avivey awarded T13127: Plans: Form Steering Committee For "+/-" Line Indicators a Dat Boi token.
Apr 18 2018, 2:17 AM · Design, Differential, Plans

Apr 12 2018

avivey added a comment to T3626: Detection of language for some file types isn't good.

Oh, good, it's about time this task be created!

image.png (141×844 px, 18 KB)

Apr 12 2018, 3:04 PM · Customer Impact, Restricted Project, Differential

Apr 7 2018

avivey added a comment to T13118: Code block headers wrap in the dumbest way in Safari.

image.png (237×209 px, 5 KB)

Chrome Windows

Apr 7 2018, 2:26 AM · Remarkup

Apr 6 2018

avivey changed the visibility for T1349: Warning about commenting on older diffs.
Apr 6 2018, 3:18 AM · Phabricator

Mar 19 2018

avivey added a comment to T13105: Plans: Rich presentation and diff rendering pipelines for various file types.

I'm wondering how this should interact with T8407: Control diffusion's syntax highlighting.

Mar 19 2018, 1:11 PM · Plans, Files, Differential, Diffusion
avivey awarded T13105: Plans: Rich presentation and diff rendering pipelines for various file types a Love token.
Mar 19 2018, 1:04 PM · Plans, Files, Differential, Diffusion

Mar 18 2018

avivey added a project to T10611: No option to specify a Space when editing a Project's visibility policy: Projects.
Mar 18 2018, 10:20 AM · Projects, Restricted Project, Feature Request, Spaces

Mar 16 2018

avivey awarded T13107: Git, Slowly and Painfully a Mountain of Wealth token.
Mar 16 2018, 11:19 AM · Guides

Mar 13 2018

avivey created T13104: Policy "Subscribers" does not consider members of subprojects.
Mar 13 2018, 6:34 AM · Projects, Policy
avivey awarded T13103: Document favicon customization and validate the "ui.favicons" configuration option a Yellow Medal token.
Mar 13 2018, 6:26 AM · Files, Aphront, Infrastructure

Mar 4 2018

avivey awarded T13098: Plans: Arcanist toolsets and extensions a Pterodactyl token.
Mar 4 2018, 7:33 PM · Arcanist, Plans

Feb 24 2018

avivey updated the task description for T13091: Ferret "Relevance" order does not always have all the columns it needs available.
Feb 24 2018, 4:10 AM · Search
avivey created T13091: Ferret "Relevance" order does not always have all the columns it needs available.
Feb 24 2018, 4:09 AM · Search

Feb 21 2018

avivey added a comment to T13088: Plans: Harbormaster UI usability and interconnectedness.
$ sudo apt install lolcat
 ...
 ...
 ...
After this operation, 27.6 MB of additional disk space will be used.
Do you want to continue? [Y/n]
Feb 21 2018, 8:00 PM · Plans, Harbormaster

Feb 15 2018

avivey awarded T13079: Allow third-party code to extend the list of functions that function datasources support a Like token.
Feb 15 2018, 2:22 AM · Typeahead

Feb 8 2018

avivey added a comment to T13068: Refinements for "Mute Notifications".

For what it's worth, I think the Mute feature adds a lot of complexities to the system, in excess to the norms of the last few years:

  • Code to handle it in the sending mechanism
  • Prioritizing this feature against any other notify feature (like T9031)
  • UI to show the to the muting user (on the object and in /mail/?)
  • UI to show to other users that this user will not be notified (What if all members of a project are muting a thread?)
  • Can a mailing list/project mute a topic?
  • "why did I not receive this notification?" - there's still some issues about this - novice users don't know/understand /mail/, and admins can't see this for them. I suspect this question will require a written checklist somewhere.
Feb 8 2018, 7:37 PM · Notifications, Mail

Feb 6 2018

avivey added a comment to T13062: Trying to manage anything in Gsuite is kind of not great?.

If all you're going for are emails, why not spin up your own Exchange server (or whatever the kids use these days)? With maybe forwarding to a epriestley-phacility@gmail.com so you remain compliant?

Feb 6 2018, 2:01 AM · Phacility, Ops
avivey awarded T13063: Maybe render all text with IMPRESSIVE illuminated drop caps a Manufacturing Defect? token.
Feb 6 2018, 1:49 AM · Remarkup

Jan 27 2018

avivey awarded T13052: Differentiate "Waiting" from "Restarting after an error" on the daemon console a Like token.
Jan 27 2018, 8:18 PM · Daemons