Page MenuHomePhabricator

avivey (Aviv Eyal)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
Jun 14 2012, 10:46 PM (375 w, 5 h)
Availability
Available

Recent Activity

Thu, Aug 15

avivey awarded T13376: Write about "add more logging / monitoring / tests" a Manufacturing Defect? token.
Thu, Aug 15, 5:26 PM · Guides

Tue, Aug 13

jcox awarded Changelog a Love token.
Tue, Aug 13, 4:30 PM

Fri, Aug 9

avivey awarded T13369: When a large number of commits are pushed to a repository, import them at lower priority a Piece of Eight token.
Fri, Aug 9, 6:46 PM · Daemons, Diffusion

Sun, Aug 4

avivey added a comment to T13358: Generate PDFs for Phortune invoices.

I've worked with wkhtmltopdf several times, and I don't remember it actually requiring any special setup - in all cases, I basically dropped the binary in the machine (Although it's possible all my machines had X11 built in for some reason? I've never intentionally installed X11).

Sun, Aug 4, 7:02 PM · Phortune, Phacility

May 24 2019

avivey awarded D20556: If "vi" or "vim" exit with an error code, test for error-on-interactive-mistake behavior a Baby Tequila token.
May 24 2019, 9:04 PM
avivey added a comment to T13297: "vi" and "vim" may exit with errors even though edits succeed.

Running the thing on my ubuntu exists with 0...

$ vi --version
VIM - Vi IMproved 8.0 (2016 Sep 12, compiled Apr 10 2018 21:31:58)
Included patches: 1-1453
.....
.....
Compilation: gcc -c -I. -Iproto -DHAVE_CONFIG_H   -Wdate-time  -g -O2 -fdebug-prefix-map=/build/vim-NQEcoP/vim-8.0.1453=. -fstack-protector-strong -Wformat -Werror=format-security -DTINY_VIMRC -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=1
Linking: gcc   -Wl,-Bsymbolic-functions -Wl,-z,relro -Wl,-z,now -Wl,--as-needed -o vim    -lSM -lICE -lXpm -lXt -lX11 -lXdmcp -lSM -lICE  -lm -ltinfo  -lselinux -lacl -lattr -ldl
May 24 2019, 9:04 PM · Arcanist

May 7 2019

avivey accepted D20499: Fix a HunkParser typo, "identcal" -> "identical".

This is a change I can stand behind. Looks good!

May 7 2019, 5:02 PM

Apr 25 2019

avivey added a comment to T9530: Release Server / Workflow app / Future of Releeph .

To those still interested, Spinnaker (OSS from Netflix + Google) is targeting the Deployment part of this flow (everything after a Release Candidate is created).
It only handled "cloud" deployments, and offers as much complexity as you can ever want, including "Wait for human approval", Canary deployments, blue-green, etc.

Apr 25 2019, 4:41 PM · Restricted Project, Harbormaster

Apr 19 2019

avivey added a comment to T6722: Support "Create similar repository..." in Diffusion.

I think a more powerful approach is to support some kind of "templates", so that we can create a new "Android App" repo or "COM Module" repo directly, similar to how IDEs have project templates.

Apr 19 2019, 7:44 PM · Diffusion (v3), Restricted Project
remusvrm awarded Changelog a Like token.
Apr 19 2019, 7:09 PM

Apr 16 2019

avivey added inline comments to D20430: Update documentation for "uri.allowed-protocols".
Apr 16 2019, 5:49 PM

Apr 15 2019

avivey accepted D20431: Show a warning when "git" is too old to support filesize limits.
Apr 15 2019, 7:43 PM
avivey accepted D20430: Update documentation for "uri.allowed-protocols".
Apr 15 2019, 7:43 PM

Mar 25 2019

avivey created T13270: Diffusion [Code] button always goes to root of repo.
Mar 25 2019, 8:49 PM · Diffusion

Mar 24 2019

avivey accepted D20317: Fix transaction queries failing on "withIDs()" after clicking "Show Older".
Mar 24 2019, 6:45 PM

Mar 19 2019

avivey added a comment to T13264: Maybe stack multiple breadcrumb sequences?.

We should log all the paths used to get to each page, and then show all of them in a big combo box, and when you select one, update your browser's history to match that path!

Mar 19 2019, 10:02 PM · Design

Feb 18 2019

avivey retitled D20194: Display some invisible/nonprintable characters in diffs by default from Display some invisible/nonprintable characters by in diffs by default to Display some invisible/nonprintable characters in diffs by default.
Feb 18 2019, 12:08 AM

Feb 2 2019

avivey awarded T13245: Improve MFA security by using replacing SMS code digits with emoji a Party Time token.
Feb 2 2019, 9:11 PM · Security

Jan 29 2019

avivey added a comment to T9044: arc diff eagerly detects git-svn repo, which makes arc-patch hang.

In https://discourse.phabricator-community.org/t/2334, thopre suggests checking for git config --get-regexp svn-remote to see if the repository is configured as git-svn repo, as an alternative to check if .git/svn/.metadata exists.

Jan 29 2019, 6:05 PM · Restricted Project, Arcanist

Jan 28 2019

avivey added a comment to T13224: Pygments Bash lexer has explosive complexity on unterminated strings with many backslashes.

D212: Fix daemon issues caused by Ubuntu's surprising intermediary shell?

Jan 28 2019, 11:24 PM · Infrastructure

Jan 19 2019

avivey created T13239: null pointer exception in PhabricatorPeopleWelcomeController.
Jan 19 2019, 11:31 PM
avivey added inline comments to D19995: Use the customizable "Welcome Mail" message in welcome mail.
Jan 19 2019, 11:29 PM
avivey added a comment to D19988: Add "Contact Numbers" so we can send users SMS mesages.

I have some war stories about normalizing phone numbers... IIRC, the worst offender is Brazil (numbers may vary in length).

Jan 19 2019, 12:49 AM

Jan 17 2019

avivey changed the visibility for T1394: Support creating audits with inline comments through the API.
Jan 17 2019, 7:17 PM · Conduit, Harbormaster, Audit

Jan 9 2019

avivey awarded T13229: On Third-Party Integrations a Yellow Medal token.
Jan 9 2019, 10:29 AM · Phacility

Dec 31 2018

avivey added a comment to T13231: Duo MFA Support.

I expect Google to expose a similar solution to Duo soonish (if you use Android and try to login to Google, MFA is just like Duo now).

Dec 31 2018, 6:29 AM · Auth
avivey added a comment to T13230: Native Applications.

Some of these things are supposed to be implemented in a reasonable way via browsers "eventually" (offline push notifications have a bunch of attempts, Screenshots use case has some solutions that sometimes work, and there's rumor about MFA and NFC floating around.)

Dec 31 2018, 6:24 AM · Phacility
avivey renamed T13230: Native Applications from Native Mobile Applications to Native Applications.
Dec 31 2018, 6:10 AM · Phacility
avivey renamed T13230: Native Applications from Native Applications to Native Mobile Applications.
Dec 31 2018, 6:07 AM · Phacility

Dec 21 2018

avivey added a comment to T13227: Figure out if Google Auth needs to be updated before Google+ shutdown on March 7, 2019.

Since the google-api is also disabled by default in Google Cloud env, I had to make changes to some other oauth provider at https://gitlab.com/SirEdvin/sanic-oauth/commit/fae23f6b35517dd9e8bec328dbb4dc883e033d78.
There, the g+ api was only used to get the user's email, iirc, and an alternative exists in https://www.googleapis.com/userinfo/v2/me.

Dec 21 2018, 1:51 AM · Auth

Dec 13 2018

avivey awarded D19877: Move user approval to modular transactions a Like token.
Dec 13 2018, 12:39 AM

Nov 15 2018

avivey accepted D19808: Fix flickering tooltips in Chrome when the tip container overlaps the triggering element.
Nov 15 2018, 5:40 PM

Nov 10 2018

avivey added a comment to E1209: Pull that into png.

The alert poped up just now (5pm, end-of-day), but this was a whole-day event! We missed the whole thing!

Nov 10 2018, 12:59 AM

Nov 9 2018

avivey committed rARC3534d2baca4b: Small ReMarkup fix (authored by avivey).
Small ReMarkup fix
Nov 9 2018, 4:25 AM
avivey closed D19794: Small ReMarkup fix.
Nov 9 2018, 4:25 AM

Nov 8 2018

avivey awarded T13217: Upgrading: Hardening of qsprintf() a Like token.
Nov 8 2018, 10:11 PM · Installing & Upgrading, Infrastructure, Security, Guides
avivey added a comment to D19794: Small ReMarkup fix.

sadpanda
https://secure.phabricator.com/drydock/lease/12656/

Nov 8 2018, 5:12 AM
avivey added reviewers for D19794: Small ReMarkup fix: epriestley, amckinley.
Nov 8 2018, 3:38 AM
avivey updated the diff for D19794: Small ReMarkup fix.

this one

Nov 8 2018, 3:35 AM
avivey requested review of D19794: Small ReMarkup fix.
Nov 8 2018, 3:34 AM

Nov 2 2018

avivey accepted D19770: Correct an ambiguous regexp in DiffusionRequest.
Nov 2 2018, 3:00 AM

Oct 15 2018

avivey added a comment to D19639: Make the Arcanist comment remover less aggressive about stripping instructional comments.

https://discourse.phabricator-community.org/t/latest-arcanist-incorrecly-parses-comments/2013 reports an issue with this new behavior - probably if the Subscribers is left empty, the parser takes the first line of the comment.

Oct 15 2018, 10:58 PM

Oct 7 2018

avivey added a comment to T8440: Tooltip flicker at certain cursor positions.

https://discourse.phabricator-community.org/t/differential-ui-tooltip-flicks-on-hover/1970 has some css witchcraft to make this not happen.

Oct 7 2018, 9:42 PM · PHUI

Sep 6 2018

avivey changed the visibility for T3130: Improve recognition of symbols in Java.
Sep 6 2018, 5:34 PM · Symbols, libphutil

Sep 3 2018

avivey added a comment to D19629: Link to PHP external symbols using HTTPS.

Almost all of us:

Sep 3 2018, 6:40 PM

Aug 9 2018

avivey added a comment to T13178: Plans: Support Pact Competitive Update.

A related score-board might be to show mana-rich tasks.

Aug 9 2018, 3:17 AM · Plans, Support, Phacility

Aug 3 2018

avivey merged T13181: Phacility: email address already in use - blocks user into T13156: Plans: Improve Phacility UI for managing instance managers and cards.
Aug 3 2018, 10:39 PM · Plans, Phacility
avivey merged task T13181: Phacility: email address already in use - blocks user into T13156: Plans: Improve Phacility UI for managing instance managers and cards.
Aug 3 2018, 10:39 PM
avivey created T13181: Phacility: email address already in use - blocks user.
Aug 3 2018, 9:21 PM

Jul 31 2018

avivey awarded T13178: Plans: Support Pact Competitive Update a Party Time token.
Jul 31 2018, 4:27 PM · Plans, Support, Phacility

Jul 27 2018

avivey added a comment to T9456: Evaluate upstream support for third-party build systems.

Looks like CircleCI will stop supporting the V1 API, which we use, in about 5 weeks: https://circleci.com/sunset1-0/

Jul 27 2018, 6:53 PM · Restricted Project, Harbormaster

Jul 19 2018

avivey created T13170: Conduit "maniphest.search" method call allows ordering by "project" column on arbitrary queries, but this internal column is only meaningful when "Group By" is "Project".
Jul 19 2018, 7:49 PM · Conduit

Jul 9 2018

avivey committed rARC875d01836037: Fix `arc diff` when adding large new file with new git (authored by avivey).
Fix `arc diff` when adding large new file with new git
Jul 9 2018, 5:59 PM
avivey closed D19513: Fix `arc diff` when adding large new file with new git.
Jul 9 2018, 5:59 PM

Jul 8 2018

avivey requested review of D19513: Fix `arc diff` when adding large new file with new git.
Jul 8 2018, 11:39 PM

Jun 27 2018

avivey added a comment to Q268: There is a way to "personlize" arcanist default template? (Answer 304).

I think the label Maniphest Tasks is no longer rendered, because the tasks are being parsed from the message body ("fixes Txxx").

Jun 27 2018, 4:12 AM

Jun 23 2018

avivey added a comment to T13158: View query results as annotatable "spreadsheets".

This sounds similar to "Customize Fields Shown In List View", except that it allows per-view customization (And a DSL for "view" instead of property on the Field, as in T418).

Jun 23 2018, 4:26 PM · Design

Jun 21 2018

avivey accepted D19500: Fix changeset construction special case for empty commits in pre-commit hooks.
Jun 21 2018, 11:24 PM
avivey added a comment to T13157: Provide more advanced tools for developing against Phabricator and discovering PHIDs.

I have P2080 and P2081 for this :)

Jun 21 2018, 7:47 PM · Infrastructure
avivey changed the visibility for P1993 GetDependenciesWorkflow.php.
Jun 21 2018, 7:46 PM
avivey awarded T13157: Provide more advanced tools for developing against Phabricator and discovering PHIDs a Love token.
Jun 21 2018, 7:45 PM · Infrastructure
avivey created T13155: Empty commit causes diffusion error output (but doesn't fail).
Jun 21 2018, 4:27 AM · Diffusion
avivey committed rGITTEST75cff161bdc4: empty commit! (authored by avivey).
empty commit!
Jun 21 2018, 4:24 AM

Jun 4 2018

avivey committed rPdbe72df55726: minor: fix translation error in exception (authored by avivey).
minor: fix translation error in exception
Jun 4 2018, 5:46 PM
avivey closed D19463: minor: fix translation error in exception.
Jun 4 2018, 5:46 PM
avivey added a comment to Q645: Aphlict start causes exception, seemingly when its log file location is changed (Answer 567).

Also, Support has basically moved to Discourse now.

Jun 4 2018, 6:25 AM
avivey requested review of D19463: minor: fix translation error in exception.
Jun 4 2018, 6:24 AM
avivey added Q645: Aphlict start causes exception, seemingly when its log file location is changed (Answer 567).
Jun 4 2018, 6:24 AM

Jun 2 2018

avivey added a comment to T418: Integrate CustomField into more interfaces.

From https://discourse.phabricator-community.org/t/how-to-get-custom-field-of-transactiontype/1532 (and my followup research), there doesn't appear to be a way to extract custom field information using conduit (or Herald Web Hooks).
transaction.search actually lists type as null and no fields.

Jun 2 2018, 6:12 PM · Restricted Project, Restricted Project, Restricted Project, Maniphest, Custom Fields

Jun 1 2018

avivey accepted D19456: Fix Javascript busy loop when trying to delete tokens from an empty tokenizer.

👍
Javascript is !!fun!!.

Jun 1 2018, 8:27 PM
avivey accepted D19457: Add "max-width: 100%;" to stop large images from overflowing the new rendering engine UI.

lgtm

Jun 1 2018, 8:24 PM

May 31 2018

avivey changed the visibility for T3071: add support for OpenSearch to phabricator.
May 31 2018, 11:49 PM
avivey added a comment to T12963: Aggregate similar stories in Feed, Notifications and Timelines.

See also long chatter in https://discourse.phabricator-community.org/t/request-less-obtrusive-status-updates/1530.

May 31 2018, 5:19 PM · Transactions

May 24 2018

avivey triaged T13148: css: ginormous images go over preview panel in Files as Low priority.
May 24 2018, 10:00 PM · Files
avivey renamed T13147: tab freeze when hitting backspace in empty tokenizer from tab freeze when hitting backspace in empty picker to tab freeze when hitting backspace in empty tokenizer.
May 24 2018, 9:51 PM · Typeahead
avivey created T13147: tab freeze when hitting backspace in empty tokenizer.
May 24 2018, 6:55 PM · Typeahead

May 22 2018

avivey added a comment to T8093: Evaluate virtualizing Git refs by proxying the protocol.

Very soon now, git is getting an exciting new wire protocol. Highlights are improving performance on repos with unholy amount of refs, and being "easier to expand".

May 22 2018, 11:37 PM · Restricted Project, Harbormaster

May 15 2018

avivey created T13139: Custom linters have no easy way to get line+char from char-offset in file.
May 15 2018, 6:08 PM · Lint

May 11 2018

avivey committed rP728130044652: Allow number in generated clone uri (authored by avivey).
Allow number in generated clone uri
May 11 2018, 4:18 PM
avivey closed D19447: Allow number in generated clone uri.
May 11 2018, 4:18 PM
avivey requested review of D19447: Allow number in generated clone uri.
May 11 2018, 5:07 AM

May 2 2018

avivey edited the content of 2018 Week 17 (Very Late April).
May 2 2018, 2:53 AM

Apr 30 2018

avivey updated the task description for T13132: `arc download` broken for non-CDN Phabricator .
Apr 30 2018, 6:10 AM · Conduit, Files
avivey created T13132: `arc download` broken for non-CDN Phabricator .
Apr 30 2018, 6:10 AM · Conduit, Files

Apr 24 2018

avivey accepted D19404: Fix a typo in the Diffusion importing user guide.

This is probably much clearer now.

Apr 24 2018, 11:08 PM

Apr 22 2018

avivey added a comment to rP15e6e2adea61: Update install_ubuntu.sh to the new age.

Want to counter-diff, @eadler?

Apr 22 2018, 9:26 PM
avivey added a comment to T13130: Plans: 2018 Week 17/18 Bonus Content.

See PHI251. This requests an "Ignore generated changes." option for Owners.

Historically, an issue with this was my hesitance to add more "Add Owner As Reviewer If Moon is Full" builtin rules to Owners: Herald already allows you to implement arbitrary rules with Owners, and an implementation of Herald where every possible rule is a dropdown option obviously isn't very good.

Apr 22 2018, 6:40 PM · Plans

Apr 21 2018

avivey committed rP15e6e2adea61: Update install_ubuntu.sh to the new age (authored by avivey).
Update install_ubuntu.sh to the new age
Apr 21 2018, 4:58 PM
avivey closed D19394: Update install_ubuntu.sh to the new age.
Apr 21 2018, 4:58 PM
epriestley awarded D19394: Update install_ubuntu.sh to the new age a Doubloon token.
Apr 21 2018, 4:43 PM
avivey added a comment to D19394: Update install_ubuntu.sh to the new age.

Incidentally, the first page shown after the install (as of 4dc8e2de564f48) is a white exception page with [Core Exception/Exception] Define 'phabricator.base-uri' in your configuration to continue..

Apr 21 2018, 4:51 AM
avivey requested review of D19394: Update install_ubuntu.sh to the new age.
Apr 21 2018, 4:50 AM
avivey added a revision to T4200: Building OS packages and install scripts: D19394: Update install_ubuntu.sh to the new age.
Apr 21 2018, 4:49 AM · Guides, Setup

Apr 20 2018

avivey added a comment to T4200: Building OS packages and install scripts.

install_ubuntu.sh seems to be completely broken for modern Ubuntu. I don't mind updating it, but I think we discussed dumping it completely?

Apr 20 2018, 1:37 AM · Guides, Setup

Apr 18 2018

avivey added a revision to T5936: Support terminating builds, terminating remote processes and build steps: D19376: Add an "Abort Older Builds" build step to Harbormaster.
Apr 18 2018, 2:21 AM · Restricted Project, Harbormaster
avivey added a task to D19376: Add an "Abort Older Builds" build step to Harbormaster: T5936: Support terminating builds, terminating remote processes and build steps.
Apr 18 2018, 2:21 AM
avivey awarded T13127: Plans: Form Steering Committee For "+/-" Line Indicators a Dat Boi token.
Apr 18 2018, 2:17 AM · Design, Differential, Plans

Apr 12 2018

avivey added a comment to T3626: Detection of language for some file types isn't good.

Oh, good, it's about time this task be created!

Apr 12 2018, 3:04 PM · Customer Impact, Restricted Project, Differential

Apr 7 2018

avivey added a comment to T13118: Code block headers wrap in the dumbest way in Safari.


Chrome Windows

Apr 7 2018, 2:26 AM · Remarkup

Apr 6 2018

avivey changed the visibility for T1349: Warning about commenting on older diffs.
Apr 6 2018, 3:18 AM · Phabricator