Remove field selector on Diff view and Revision List View
ClosedPublic
Actions

Authored by epriestley on Mar 9 2014, 6:47 PM.

Details

Reviewers

btrahan

Maniphest Tasks

T2222: Implement ApplicationTransactions in Differential

Commits

Summary

Ref T2222. This has some minor functionality regressions:

The plain diff page no longer shows unit/test status. I want to give diffs separate custom fields for this.
It was technically possible to shove more data on the list view, although this doensn't affect the default config.

Test Plan

Looked at list view, diff detail view. Grepped for changes.

Repository

rP Phabricator

Lint

Lint Skipped

Unit

Tests Skipped

btrahan edited edge metadata.

This revision is now accepted and ready to land.Mar 10 2014, 6:20 PM

Closed by commit rP3910d0d5e19b (authored by @epriestley).

aik099 added inline comments.

src/applications/differential/view/DifferentialRevisionListView.php
119–133	The `$show_age` variable is no longer used after this change, which results in red clock icon being shown indefinitely for closed differential revisions.

src/applications/differential/view/DifferentialRevisionListView.php
106	Just removing this and the corresponding class property/set_method/usage would be better, because no matter from where you look at list of differential revisions you want to see if it's stale/old or not.