Kicking this out of Differential because this is reproducible in every application that allows you to edit comments.
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed All Stories
All Stories
All Stories
Dec 29 2016
Dec 29 2016
epriestley triaged T11171: When clicking an image in the comment edit modal, the image modal gets under the edit modal as Wishlist priority.
epriestley added a comment to T7838: Link to inline comment opens in new tab, scrolls to inline comment, then scrolls to bottom of page..
I'm going to merge this into T11784 since I think this is probably the same issue.
epriestley moved T7682: JS Errors when mousing over image diff comments, right side only from v2 (UI/Mobile) to Inline Infra on the Differential board.
epriestley added a comment to T12051: "Autoclose: Disabled" could provide a stronger hint that it means "You, the user, have disabled Autoclose by adjusting a setting.".
I think "Autoclose" is likely getting updates in connection with T12010 anyway, so work there may obsolete this.
epriestley renamed T12051: "Autoclose: Disabled" could provide a stronger hint that it means "You, the user, have disabled Autoclose by adjusting a setting." from changing autoclose setting on a repo does not reflect in UI to "Autoclose: Disabled" could provide a stronger hint that it means "You, the user, have disabled Autoclose by adjusting a setting.".
allixsenos added a comment to T12051: "Autoclose: Disabled" could provide a stronger hint that it means "You, the user, have disabled Autoclose by adjusting a setting.".
it's a "fresh" repo, created yesterday, with no commits. I immediately
disabled those upon creation and then circled back the next day considering
it "completely new"
epriestley added a comment to T12051: "Autoclose: Disabled" could provide a stronger hint that it means "You, the user, have disabled Autoclose by adjusting a setting.".
How did you disable this option in a newly created Git repository without realizing you had made the change?
allixsenos added a comment to T12051: "Autoclose: Disabled" could provide a stronger hint that it means "You, the user, have disabled Autoclose by adjusting a setting.".
ah. yes. I turned those off.
epriestley moved T731: Allow revisions to have alternate acceptance conditions from v3 (Infrastructure) to Reviewer Rules on the Differential board.
epriestley added a comment to T9758: Diff context for Objective-C doesn't show method name if open brace is on newline.
I'm going to merge this into T11738, which has a more detailed and general discussion of this.
epriestley moved T1081: Ability to undo a diff from v2 (UI/Mobile) to v3 (Infrastructure) on the Differential board.
epriestley moved T3462: In Differential, expose "featurename (branched from master)" via Conduit from Backlog to Branch Handling on the Differential board.
epriestley moved T10607: Remote target/landing branch in Diff details from Backlog to Branch Handling on the Differential board.
epriestley moved T7903: Conduit differential.query search by branches is broken from Backlog to Branch Handling on the Differential board.
epriestley moved T7870: List of cases where ghost comments end up somewhere confusing or unexpected from Backlog to Inline Infra on the Differential board.
epriestley moved T7470: show the base branch name in Differential revision info from Backlog to Branch Handling on the Differential board.
epriestley moved T3960: Add capability to hide lint messages when viewing a diff from Backlog to Inline Infra on the Differential board.
epriestley moved T3216: "Browse in Diffusion" always going to default branch from Backlog to Branch Handling on the Differential board.
epriestley moved T10574: A pathway toward "All Reviewers Must Accept" from v3 (Infrastructure) to Reviewer Rules on the Differential board.
epriestley moved T11401: Add ability to quote, edit, view raw, view history, and remove inline comments from Backlog to Inline Infra on the Differential board.
epriestley moved T11093: DifferentialInlineCommentEditor retains state across Quicksand requests from Backlog to Inline Infra on the Differential board.
epriestley moved T6273: Inline comments do not support editing (Pholio, Differential, Diffusion) from Backlog to Inline Infra on the Differential board.
epriestley moved T10136: Show warning in Revision when build failed from Backlog to v3 (Infrastructure) on the Differential board.
epriestley moved T8131: Clicking "Done" breaks keyboard navigation from Backlog to Inline Infra on the Differential board.
epriestley moved T8130: Keyboard shortcut for "Done" from Backlog to Inline Infra on the Differential board.
epriestley moved T8909: Provide ability to hide all inline or done comments from Backlog to Inline Infra on the Differential board.
Dec 29 2016, 4:28 PM · Inline Comments, Prioritized, Restricted Project, Restricted Project, Differential, FreeBSD
epriestley moved T8800: Inline comments on a diff cause subscribe event instead of comment event from Backlog to Inline Infra on the Differential board.
epriestley moved T8573: All reviewers should be allowed to mark a comment as done from Backlog to Reviewer Rules on the Differential board.
epriestley moved T8420: Hidden inlines don't work properly with anchor-based navigation from Backlog to Inline Infra on the Differential board.
epriestley moved T5654: Show more context for inline comments in Differential timeline from Backlog to Inline Infra on the Differential board.
epriestley moved T5232: Keyboard shortcut to create inline comment from Backlog to Inline Infra on the Differential board.
epriestley moved T10323: "Action With No Effect" when marking inline comments as done from Backlog to v3 (Infrastructure) on the Differential board.
epriestley moved T11363: Differential "revision updated" mail preference is pretty useless from Backlog to v3 (Infrastructure) on the Differential board.
epriestley closed T4043: Provide a keyboard shortcut to focus the comment textarea in Differential as Resolved.
After D17105 (Maniphest) and D17106 (Differential), comment forms can be pinned on screen in any modern application by pressing Z. This also focuses the comment area. This pinned mode no longer has multiple different modal toggles (they're somewhat obsoleted by inline preview, and by scrolling improvements) so focusing the comment area no longer conflicts with pressing the key multiple times to cycle modes.
epriestley closed T11659: Differential comment panel haunter does not allow scrolling to bottom of differential revision when no ui.footer-items configured as Resolved.
This should be resolved by T12049 + T11114, once Differential moves to the new comment area UI. The new universal haunted mode puts a spacer into the document while the panel is haunted, so if the panel is 500px tall we put a 500px empty space at the bottom of the document. This means that all content is always visible while scrolling.
epriestley added subtasks for T12049: Give EditEngine universal support for "Haunted Mode": T4043: Provide a keyboard shortcut to focus the comment textarea in Differential, T11659: Differential comment panel haunter does not allow scrolling to bottom of differential revision when no ui.footer-items configured.
epriestley moved T12049: Give EditEngine universal support for "Haunted Mode" from Backlog to v3 (Infrastructure) on the Differential board.
epriestley added a comment to T12051: "Autoclose: Disabled" could provide a stronger hint that it means "You, the user, have disabled Autoclose by adjusting a setting.".
I can't immediately reproduce this.
Followup from the same instance as above (T7607#198199) with the same request (put their contact details on the invoice). All of the prior changes put our contact details on the invoice but printable invoices are currently hard-coded to always be billed "To" the real name of the paying user.
So should Arcanist be modified to just call differential.revision.edit directly then?
epriestley moved T12033: Large diffs can still repeatedly fail to insert from Backlog to Future Work on the Differential board.
From D17067:
rayzyar awarded T2443: Make "arc cover" more powerful a The World Burns token.
chad added a comment to T12050: Ask a question: Only Herald-compliant file paths are shown in Mail or Diffusion .
As I mentioned over email, you'll have to update Phabricator before asking for help. That version looks at least 18-24 months old and there have been significant changes.
ivan.wang added a comment to T12050: Ask a question: Only Herald-compliant file paths are shown in Mail or Diffusion .
thanks
chad added a comment to T12050: Ask a question: Only Herald-compliant file paths are shown in Mail or Diffusion .
Please read Support Resources for where we take questions about Phabricator. This doesn't appear to be a feature request.
Dec 28 2016
Dec 28 2016
epriestley added a revision to T11114: Move Differential to EditEngine: Unknown Object (Differential Revision).
FWIW #Twitter has multiple users of this feature and we'd likely get complaints if it broke
You have installed multiple versions of PHP, some of which have cURL and some of which do not.