(Resolved by D12489) Old comments on the right-hand side port forward to the right-hand side, even if the left-hand side would be more appropriate.
- Create diff 1, leave comments on the right-hand side.
- Create diff 2, leave comments on the right-hand side.
- Create diff 3, leave comments on the right-hand side.
- Diff 2 vs 3.
- Comments on diff 1 are shown on the right, but showing them on the left makes more sense.
- Diff 1 vs 2.
- Comments on diff 3 are shown on the right. This is desirable.
(Resolved by D12491) If a file is shortened (for example, it is mostly deleted), comments do not port forward into it.
- Create diff 1, leave comments on the right-hand side in the middle/bottom of the file.
- Delete almost all of the file.
- Create diff 2.
- View diff 2 vs base.
- Expect to see comments at the end of right-hand side (maybe with annotations).
- Actually see nothing.
(Resolved by D12492) Clicking "Reply" on comments which have been ported forward or backward does not work.
(Resolved by D12493) Comments do not port forward or backward across file moves, but could reasonably be expected to.
- Create diff 1, leave comments on "A".
- Rename "A" to "B".
- Create diff 2.
- View diff 2 vs base.
- Expect to see comments port forward.
- Actually see nothing.
- Add comments to "B".
- View diff 1 vs base.
- Expect to see comments port backward.
- Actually see nothing.
(Resolved by D12495) Ghost inlines do not expand changesets on very large revisions.
- Create diff 1.
- Add inlines.
- Update to diff 2, affecting more than 100 files.
- View diff 2 vs base.
- Expect files with comments from diff 1 to auto-expand.
- Actually, files do not auto-expand.
(Resolved by D12497) Ghostly inlines visible on the current screen are marked as appearing on other diffs and link to other diffs in the timeline view, when they could reasonably link to some anchor on the same page.
- Create diff 1.
- Add comments.
- Upload diff 2.
- View diff 2 vs base.
- Expect timeline view to show that the inlines are visible on the current page.
- Actually see little arrow and link elsewhere.
Ghostly comments may show up twice in the same diff-of-diffs.
- Create diff 1 with file "A".
- Create diff 2, moving "A" to "B".
- View diff 2 vs diff 1.
- Comments on either "A" or "B" show on both files.
Comment not porting here:
https://secure.phabricator.com/D13036?vs=on&id=31479&whitespace=ignore-most#136453
Might be the "move to last visible line" code interacting with the "port across rebases" code.
Ghost comments may port oddly in new files with removed lines? Repro case is:
- Create a file with "a..z".
- Remove a couple lines, update.
- Add a comment somewhere near the bottom.
- When viewed Diff 2 vs base, comment is not adjusted for removed lines.
Diff 1 with comment:
Diff 2 vs diff 1:
Diff 2 vs base (comment position is wrong):
