Page MenuHomePhabricator
Create Task
Maniphest T9269

Undoing multiple inline comments on the same line will restore the comment out of position.
Closed, ResolvedPublic
Actions

Description

  1. On a diff revision, click on a line to leave a comment
  2. Type a comment in the field
  3. Hit Cancel which will cause an "Undo" link to appear
  4. On the same line click again to create new comment
  5. Type a comment in the field
  6. Hit Cancel which will cause an "Undo" link to appear
  7. Click "Undo" - this will cause the comment to restore way below where it should

Screen Shot 2015-08-26 at 11.51.34 AM.png (1×3 px, 646 KB)

One of the first times I did this (though possibly slightly different set of steps), an error appeared on the page. I couldn't get it to happen again. The stacktrace on the server is: P1847

Phabricator is on f2b2264e8def0a69d1431f38c1d202273f95842b

Related Objects

Event Timeline

cspeckmim created this task.Aug 26 2015, 3:58 PM
cspeckmim updated the task description. (Show Details)
cspeckmim added a project: Differential.
cspeckmim added a subscriber: cspeckmim.
joshuaspence added a subscriber: joshuaspence.Aug 26 2015, 8:37 PM
cspeckmim mentioned this in T7870: List of cases where ghost comments end up somewhere confusing or unexpected.Sep 29 2015, 2:40 PM
epriestley added a subscriber: epriestley.Sep 29 2015, 2:45 PM

Here's a similar failure case:

  • Click line X, type comment, click Cancel, leaving "Undo".
  • Click any other line, opening editor.
  • Click "Undo".

Screen Shot 2015-09-29 at 7.44.36 AM.png (1×1 px, 202 KB)

In both cases, I think opening the editor thrashes the internal "Undo" state but doesn't wipe the UI.

epriestley merged a task: T9484: Attempting to undo deletion of inline comments in a differential after starting to write a new inline comment results in 'Unhandled Exception ("InvalidArgumentException")'.Sep 30 2015, 1:07 AM
epriestley added a subscriber: kojik1010.
epriestley moved this task from Backlog to Inline Infra on the Differential board.Dec 29 2016, 4:28 PM
Herald added a subscriber: eadler. · View Herald TranscriptDec 29 2016, 4:28 PM
epriestley added a project: Inline Comments.Apr 21 2017, 12:20 PM
epriestley moved this task from Backlog to Glitches on the Inline Comments board.Apr 21 2017, 12:24 PM
epriestley moved this task from Glitches to Editor on the Inline Comments board.Apr 24 2017, 10:32 AM
epriestley closed this task as Resolved.May 16 2017, 8:09 PM
epriestley claimed this task.

This no longer reproduces after D17916.

Note that, broadly, inline editing used to be very singleton-ey and modal and to use a bunch of global state (you could only edit one comment at a time on the whole page).

Inline editing is now very flexible, and each entity supports independent simultaneous editing. It is possibly too flexible and we may need to lock down how this works a bit, but you can currently open a thousand editors and put half of them into undo states all at once if you want.

cspeckmim added a comment.May 16 2017, 8:12 PM

only half of them :/

🐕

epriestley added a comment.May 16 2017, 8:13 PM

Sorry, yes, that was a disappointing way to phrase it. You may open a thousand editors and put any number of them between zero and all of them, inclusive, into any of the various undo states.

cspeckmim added a comment.May 16 2017, 8:15 PM

doggo.png (31×35 px, 7 KB)

Phabricator · Built by Phacility