Page MenuHomePhabricator
Create Task
Maniphest T8288

Hovering over "Edit" dialog for inline comments which are replies to right-hand-side inline comments shows reticle on wrong side of diff
Closed, ResolvedPublic
Actions

Description

Apparent repro steps:

  • Create an inline comment on the right side of a diff.
  • Use "reply" to reply to it.
  • Edit your reply.
  • Hover over the edit dialog.

Expected:

  • Reticle appears on correct side (right).

Actual:

  • Reticle appears on left.

Related Objects

Event Timeline

epriestley created this task.May 21 2015, 4:41 PM
epriestley raised the priority of this task from to Normal.
epriestley updated the task description. (Show Details)
epriestley added a project: Differential.
epriestley added a subscriber: epriestley.
epriestley mentioned this in T8909: Provide ability to hide all inline or done comments.Jun 17 2016, 4:23 PM
epriestley moved this task from Backlog to Inline Infra on the Differential board.Dec 29 2016, 4:27 PM
Herald added a subscriber: eadler. · View Herald TranscriptDec 29 2016, 4:27 PM
epriestley added a project: Inline Comments.Apr 21 2017, 12:20 PM
epriestley moved this task from Backlog to Glitches on the Inline Comments board.Apr 21 2017, 12:25 PM
epriestley added a comment.Apr 24 2017, 10:32 AM

This reproduces for me at HEAD:

Screen Shot 2017-04-24 at 3.32.17 AM.png (629×1 px, 54 KB)

epriestley moved this task from Glitches to Editor on the Inline Comments board.Apr 24 2017, 10:33 AM
epriestley moved this task from Editor to Reticle on the Inline Comments board.May 16 2017, 6:11 PM
epriestley closed this task as Resolved.EditedMay 17 2017, 1:11 PM
epriestley claimed this task.

This no longer reproduces for me at HEAD of master.

I suspect it was resolved by the series of changes associated with T12616. Particularly, inlines are now much more self-contained and much less entangled with piles of weird global state.

Phabricator · Built by Phacility