Page MenuHomePhabricator

Hovering over "Edit" dialog for inline comments which are replies to right-hand-side inline comments shows reticle on wrong side of diff
Closed, ResolvedPublic


Apparent repro steps:

  • Create an inline comment on the right side of a diff.
  • Use "reply" to reply to it.
  • Edit your reply.
  • Hover over the edit dialog.


  • Reticle appears on correct side (right).


  • Reticle appears on left.

Event Timeline

epriestley raised the priority of this task from to Normal.
epriestley updated the task description. (Show Details)
epriestley added a project: Differential.
epriestley added a subscriber: epriestley.

This reproduces for me at HEAD:

Screen Shot 2017-04-24 at 3.32.17 AM.png (629×1 px, 54 KB)

epriestley closed this task as Resolved.EditedMay 17 2017, 1:11 PM
epriestley claimed this task.

This no longer reproduces for me at HEAD of master.

I suspect it was resolved by the series of changes associated with T12616. Particularly, inlines are now much more self-contained and much less entangled with piles of weird global state.