Page MenuHomePhabricator
Create Task
Maniphest T10668

When replying to a ghost inline comment, it is possible for the reticle to cover the reply UI
Closed, WontfixPublic
Actions

Description

This is a little tricky to reproduce reliably, but here's a screenshot:

Screen Shot 2016-03-25 at 10.11.21 AM.png (549×876 px, 58 KB)

We should cut the reticle off so that it can never extend below the reply.

Related Objects

Event Timeline

epriestley created this task.Mar 25 2016, 5:12 PM
Herald added a subscriber: eadler. · View Herald TranscriptMar 25 2016, 5:12 PM
eadler added a project: Restricted Project.Mar 28 2016, 8:19 PM
eadler moved this task from Restricted Project Column to Restricted Project Column on the Restricted Project board.Mar 28 2016, 8:29 PM
eadler moved this task from Restricted Project Column to Restricted Project Column on the Restricted Project board.Apr 7 2016, 6:08 PM
richardvanvelzen added a subscriber: richardvanvelzen.Jun 2 2016, 9:06 AM
epriestley mentioned this in T8909: Provide ability to hide all inline or done comments.Jun 17 2016, 4:23 PM
eadler moved this task from Restricted Project Column to Restricted Project Column on the Restricted Project board.Jul 4 2016, 9:05 PM
epriestley moved this task from Backlog to Inline Infra on the Differential board.Dec 29 2016, 4:36 PM
epriestley added a project: Inline Comments.Apr 21 2017, 12:20 PM
epriestley moved this task from Backlog to Glitches on the Inline Comments board.Apr 21 2017, 12:23 PM
epriestley moved this task from Glitches to Editor on the Inline Comments board.Apr 24 2017, 10:33 AM
epriestley moved this task from Editor to Reticle on the Inline Comments board.May 16 2017, 6:11 PM
epriestley closed this task as Wontfix.May 17 2017, 7:26 PM
epriestley claimed this task.

This is effectively not a problem at HEAD, although I may make it a problem again soon. But I'm also not sure if anyone else has actually hit this, and it's a pain to fix, and even in the worst case it's less bad now because we pointer-events this. I'm just going to punt for now, let the dust settle on T12616, and we can revisit this if anyone's actually hitting it after all that.

A reasonable solution might just be "ghost inlines don't highlight lines" or something indirect like that.

Phabricator · Built by Phacility