Page MenuHomePhabricator

When replying to a ghost inline comment, it is possible for the reticle to cover the reply UI
Closed, WontfixPublic

Description

This is a little tricky to reproduce reliably, but here's a screenshot:

Screen Shot 2016-03-25 at 10.11.21 AM.png (549×876 px, 58 KB)

We should cut the reticle off so that it can never extend below the reply.

Event Timeline

eadler added a project: Restricted Project.Mar 28 2016, 8:19 PM
eadler moved this task from Restricted Project Column to Restricted Project Column on the Restricted Project board.Mar 28 2016, 8:29 PM
eadler moved this task from Restricted Project Column to Restricted Project Column on the Restricted Project board.Apr 7 2016, 6:08 PM
eadler moved this task from Restricted Project Column to Restricted Project Column on the Restricted Project board.Jul 4 2016, 9:05 PM
epriestley claimed this task.

This is effectively not a problem at HEAD, although I may make it a problem again soon. But I'm also not sure if anyone else has actually hit this, and it's a pain to fix, and even in the worst case it's less bad now because we pointer-events this. I'm just going to punt for now, let the dust settle on T12616, and we can revisit this if anyone's actually hitting it after all that.

A reasonable solution might just be "ghost inlines don't highlight lines" or something indirect like that.