Page MenuHomePhabricator

Draft comments which reply to ghost inlines from lines which no longer exist can not be edited or deleted until the page is reloaded
Closed, ResolvedPublic


Reproduction instructions:

  • Create a revision with long.txt, which has about 100 lines.
  • Add an inline comment near the end of the file, saving and then submitting it.
  • Delete about half the file locally, so the new file is shorter than the original file was.
  • Update the revision.
  • Reload the page so you see the most up-to-date version, then reply to the comment (which is now a ghost). Save the reply, but do not submit it yet.
  • Try to edit the reply (which is still a draft).

Expected behavior:

  • Editing (and deleting) work properly.

Actual behavior:

  • The JS gets tripped up because the reply is placed "on line 100", but the file now only has about 50 lines. Javascript console spews some noise and the click is ignored.


  • Reload the page first, then edit the inline comment.


Screen Shot 2016-09-19 at 1.42.11 PM.png (1×1 px, 156 KB)

This is related to the issue discussed in T10563#164374.

Event Timeline

I tagged this with Phacility because a Phacility customer was the original reporter. I think it's useful to keep track of bugs which impact customers, but maybe I should make a different tag?

I think it's useful to keep track of bugs which impact customers

Specifically, because I'm willing to spend more effort/resources solving problems experienced by customers than other users, and having this information may lead to a different outcome for the bug.

No worries. I was like... weird there is a random task in "Phacility", so I removed one, then I saw like 50 more... and stopped.

I can no longer reproduce the edit issue at HEAD.

I suspect the cluster of changes connected to T12616 (which generally improved workflow robustness here) also corrected this.

We still get a warning about highlighting; I'm going to fix that by just skipping the line highlighting because there isn't truly a valid range of lines to highlight.