Page MenuHomePhabricator

DifferentialInlineCommentEditor retains state across Quicksand requests
Closed, ResolvedPublic

Description

See T11092, T8852. I think the root issue here is that DifferentialInlineCommentEditor objects are being bound to URIs including revision IDs:

editor = new JX.DifferentialInlineCommentEditor(config.uri)
  .setTemplates(view.getUndoTemplates())
  .setOperation(op)

Here, config.uri contains the revision ID. This editor and the attendant listeners do not scope their action to the original revision, and may fire for different revisions after a Quicksand navigation.