I created a code review for changes that I made in branch x. Clicking on "Browse in DIffusion" always take me branch y which is the default branch set up for the project. It should take me to the file in branch x instead.
Description
Description
Related Objects
Related Objects
Event Timeline
Comment Actions
This is a little tricky because a commit may be on a local branch, which is a branch of a local branch, which is a branch of a local branch, and so on, an arbitrary number of levels deep. That said, we can make a reasonable effort to find a better branch than the default branch:
- If the commit's branch does exist, use that.
- Record the upstream branch if the local branch uses --track and check it that exists (this is somewhat rare).
- If the revision's base commit is in the repository and does not appear on the default branch, use a branch it appears on (choosing at random?).
- Maybe allow users to specify an alternate default branch when coming from Differential.
Comment Actions
Yes your scheme below seems reasonable. At the minimum, please allow a user to choose a branch for "Browse in Diffusion". Thank in advance for your efforts.
From: epriestley (Evan Priestley) [noreply@phabricator.com]
Sent: Saturday, May 18, 2013 3:12 AM
To: Helene Lau; Helene Lau
Subject: [Maniphest] [Triaged] T3216: "Browse in Diffusion" always going to default branch
epriestley triaged this task as "Normal" priority.
This is a little tricky because a commit may be on a local branch, which is a branch of a local branch, which is a branch of a local branch, and so on, an arbitrary number of levels deep. That said, we can make a reasonable effort to find a better branch than the default branch:
- If the commit's branch does exist, use that.
- Record the upstream branch if the local branch uses --track and check it that exists (this is somewhat rare).
- If the revision's base commit is in the repository and does not appear on the default branch, use a branch it appears on (choosing at random?).
- Maybe allow users to specify an alternate default branch when coming from Differential.
TASK DETAIL
https://secure.phabricator.com/T3216
REPLY HANDLER ACTIONS
Reply to comment or attach files, or !close, !claim, or !unsubscribe.
To: epriestley
Cc: hlau