Always interpret the first line of commit messages as a title, even if it begins with a recognized label like "Test Plan:"
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	kugel-
	Feb 10 2016, 7:35 AM

Description

I attempted to create a review with the following data:

tests: change to criterion

Summary: criterion rocks

Test Plan: make check

Reviewers: xxx

Subscribers:

arc diff then complained:

Field "testPlan" occurs twice in commit message!

Invalid or missing field "Title": You must provide a revision title in the first line of your commit message.

You must resolve these errors to continue.
Do you want to edit the message? [Y/n] y

I could work around by changing the title to "unit tests: change to criterion" but in my opinion my choice for the title (and summary) should not be limited.

To me it looks like the regex is too greedy?

Revisions and Commits

rP Phabricator
	D17122	rP81e2a1cf6b22 Always parse the first line of a commit message as a title

Related Objects

Mentioned In: T12197: Audits are no longer triggered using singular "Auditor:"
T12119: `arc diff --reviewers foo` puts reviewers into Summary field
T12053: Arcanist tries to parse phpunit output in the test plan as another test plan field
D16438: Add patch to remove conduit_connectionlog table (Fixes T9982)
Mentioned Here: T5028: Commit message text formatting in remote git repository (SSH) is not preserved
T11485: Diffusion & Auditing with GIT (Windows style newlines)

Event Timeline

kugel- created this task.Feb 10 2016, 7:35 AM

"Tests:" and "Test Plans:" are both valid labels. See https://secure.phabricator.com/diffusion/P/browse/master/src/applications/differential/customfield/DifferentialTestPlanField.php;aa6c993848797d792a886b4a570f20ca897ade7e$164-170

In general you'll have to steer clear of any "label: field" in your titles.

I encountered this on a svn repository, but what do you do for git repositoires where "label: one line summary" is considered best practice for commit messages?

Can I workaround with manual "Title: " label?

chad merged a task: T11500: unable to submit a diff with "tests:" in git commit title.Aug 19 2016, 4:53 PM

chad added a subscriber: kparal.

@chad, what is the rationale behind processing the very first line of the git commit message (the title)? I can't find any reason to do so, the first line is always the title. If you just ignored the first line and not performed any extra arc processing, this issue would go away. What am I missing?

I agree with that (and actually believed we already did that, see T11485 for me claiming that this is the current behavior). We'll change this.

See also T5028 for git shenanigans with %s / %b / %B which vaguely affect things here.

epriestley renamed this task from arc complains when tests is in the title to Always interpret the first line of commit messages as a title, even if it begins with a recognized label like "Test Plan:".Aug 22 2016, 8:48 AM

epriestley claimed this task.

epriestley triaged this task as Normal priority.

epriestley added projects: Differential, Diffusion.

Herald added a subscriber: eadler. · View Herald TranscriptAug 22 2016, 8:48 AM

fooishbar added a subscriber: fooishbar.Aug 22 2016, 9:59 AM

epriestley mentioned this in D16438: Add patch to remove conduit_connectionlog table (Fixes T9982).Aug 24 2016, 2:59 PM

eadler added a project: Restricted Project.Sep 15 2016, 6:11 PM

epriestley moved this task from Backlog to v3 (Infrastructure) on the Differential board.Dec 29 2016, 4:22 PM

chad mentioned this in T12053: Arcanist tries to parse phpunit output in the test plan as another test plan field.Dec 31 2016, 4:32 AM

epriestley added a revision: D17122: Always parse the first line of a commit message as a title.Jan 1 2017, 4:30 PM

epriestley closed this task as Resolved by committing rP81e2a1cf6b22: Always parse the first line of a commit message as a title.Jan 1 2017, 5:56 PM

epriestley added a commit: rP81e2a1cf6b22: Always parse the first line of a commit message as a title.