Page MenuHomePhabricator
Create Task
Maniphest T10954

Differential keyboard shortcut inline selection reticle is visually unclear (bad z-index?)
Closed, ResolvedPublic
Actions

Description

In my tiny bit of experience with phabricator, I noticed that first time users have a hard time discovering that there is something as a selected change when using the shortcuts j/k.

screenshot.png (1×1 px, 282 KB)

I would propose making this more obvious, for instance by changing the yellowish color of the "selector" to something more opaque.

Revisions and Commits

rP Phabricator
D17784rP27bdc322fc11 Put the keyboard focus reticle back on top of diffs

Related Objects

Event Timeline

Chiel92 created this task.May 12 2016, 9:31 AM
Herald added a subscriber: eadler. · View Herald TranscriptMay 12 2016, 9:31 AM
chad added a subscriber: chad.May 13 2016, 3:06 AM

I think this is likely a bug.

epriestley renamed this task from Make selected change more obvious to Differential keyboard inline selection reticle is visually unclear (bad z-index?).May 22 2016, 1:02 PM
epriestley renamed this task from Differential keyboard inline selection reticle is visually unclear (bad z-index?) to Differential keyboard shortcut inline selection reticle is visually unclear (bad z-index?).
epriestley mentioned this in T8909: Provide ability to hide all inline or done comments.Jun 17 2016, 4:23 PM
epriestley moved this task from Backlog to Inline Infra on the Differential board.Dec 29 2016, 4:30 PM
epriestley added a project: Inline Comments.Apr 21 2017, 12:20 PM
epriestley moved this task from Backlog to Glitches on the Inline Comments board.Apr 21 2017, 12:23 PM
epriestley moved this task from Glitches to Reticle on the Inline Comments board.Apr 24 2017, 10:05 AM
epriestley added a subscriber: epriestley.Apr 24 2017, 10:08 AM

I'm going to try putting this on top of everything and using pointer-events: none to fix all the attendant click/hover/select issues.

Once, this was layered under the text but over the background, but I think this is pretty unavoidably error-prone.

If there's still click/hover/select stuff, I think we can make the element run away from the cursor onmouseover.

epriestley added a revision: D17784: Put the keyboard focus reticle back on top of diffs.Apr 24 2017, 10:21 AM
epriestley closed this task as Resolved by committing rP27bdc322fc11: Put the keyboard focus reticle back on top of diffs.Apr 24 2017, 5:24 PM
epriestley added a commit: rP27bdc322fc11: Put the keyboard focus reticle back on top of diffs.
Phabricator · Built by Phacility