Page MenuHomePhabricator

Differential keyboard shortcut inline selection reticle is visually unclear (bad z-index?)
Closed, ResolvedPublic

Description

In my tiny bit of experience with phabricator, I noticed that first time users have a hard time discovering that there is something as a selected change when using the shortcuts j/k.

screenshot.png (1×1 px, 282 KB)

I would propose making this more obvious, for instance by changing the yellowish color of the "selector" to something more opaque.

Event Timeline

I think this is likely a bug.

epriestley renamed this task from Make selected change more obvious to Differential keyboard inline selection reticle is visually unclear (bad z-index?).May 22 2016, 1:02 PM
epriestley renamed this task from Differential keyboard inline selection reticle is visually unclear (bad z-index?) to Differential keyboard shortcut inline selection reticle is visually unclear (bad z-index?).

I'm going to try putting this on top of everything and using pointer-events: none to fix all the attendant click/hover/select issues.

Once, this was layered under the text but over the background, but I think this is pretty unavoidably error-prone.

If there's still click/hover/select stuff, I think we can make the element run away from the cursor onmouseover.