Page MenuHomePhabricator

Saving draft inlines on left hand side of files not present in newer diff in diff-of-diffs fails
Closed, ResolvedPublic

Description

Repro steps:

  • Create diff 1, which affects only file A.
  • Update revision with diff 2, which affects only files other than A.
  • Show diff of diffs between diffs 2 and 1.
  • Leave a comment on the left hand side of file A.
  • Save draft.

Actual result:

Invalid changeset ID!
Depth	Library	File	Where
5	phabricator	infrastructure/diff/PhabricatorInlineCommentController.php : 187	DifferentialInlineCommentEditController::createComment()
4	phabricator	aphront/AphrontController.php : 33	PhabricatorInlineCommentController::processRequest()
3	phabricator	aphront/configuration/AphrontApplicationConfiguration.php : 226	AphrontController::handleRequest()
2	phabricator	aphront/configuration/AphrontApplicationConfiguration.php : 140	AphrontApplicationConfiguration::processRequest()
1		/Users/epriestley/dev/core/lib/phabricator/webroot/index.php : 19	AphrontApplicationConfiguration::runHTTPRequest()

Expected result:

  • not that

Revisions and Commits

Restricted Differential Revision

Event Timeline

epriestley claimed this task.
epriestley raised the priority of this task from to Normal.
epriestley updated the task description. (Show Details)
epriestley added a project: Differential.
epriestley added subscribers: epriestley, csilvers.
epriestley added a revision: Restricted Differential Revision.May 17 2017, 3:27 PM
epriestley closed this task as Resolved by committing Restricted Diffusion Commit.May 17 2017, 3:54 PM
epriestley added a commit: Restricted Diffusion Commit.