Page MenuHomePhabricator

show the base branch name in Differential revision info
Closed, DuplicatePublic


In a differential patch, the web shows many fields of description including the author, reviewers, branch name, repo name,etc.

However, the base branch (landonto targeting branch) is not master at some case.

It would be great to see the 'landonto branch: xxx' field in such case.

Event Timeline

lianghu assigned this task to epriestley.
lianghu raised the priority of this task from to Normal.
lianghu updated the task description. (Show Details)
lianghu added a project: Differential.
lianghu added a subscriber: lianghu.

how about naming the fields as

base branch: xxx
feature branch: yyy

chad raised the priority of this task from Normal to Needs Triage.

a side topic,

I saw "chad placed this task up for grabs".

What's grabs? I'm not aware of it.

It means the task is unassigned.

I think it should be assigned to Evan.

It's similar to D8359

chad added a subscriber: epriestley.

The is no need to assign a task, thanks!

OK. Thanks for reminder.

Do you think this is a reasonable change request or not?

When same code repo have different branches for different products.

It would be useful to identify a differential patch is for which branch.

T4778 covers how we prioritize tasks. Specifically we have thousands of requests, and are a very small team. We cannot provide any estimates when we'll even look to see if we should build this.

You may modify your local copy of Phabricator in the meantime to provide the functionality you need if the request is urgent.

I'm going to merge this into T10607.

We've showed this for some time:

Branch: feature (branched from master)

This is the brach that the feature branch was branched from.

However, the target branch (where the change will land) and the source branch (where the feature brach was branched from) are not necessarily the same. T10607 discusses that. If we made that change, we might show:

Branch: feature (branched from master, landing to development)

(This is rare.)

Actually, that description is a little misleading, but I'll follow up in T10607.